RE: About ppp_receive()

Hi Steven, Steven wrote: Hi, In function ppp_receive, we first check the protocol type of this frame like: guint16 protocol = ppp_proto(buf); and here we assumed the length of the protocol field is 16 bits, but in RFC 1661, the protocol field should be one or two octets. The

RE: About ppp_receive()

Hi Steven, Steven wrote: Hi Zhenhua Zhang, Zhenhua wrote: Hi Steven, Steven wrote: Hi, In function ppp_receive, we first check the protocol type of this frame like: guint16 protocol = ppp_proto(buf); and here we assumed the length of the protocol field is 16 bits, but in RFC

Re: About ppp_receive()

Hi Zhenhua, Zhang, Zhenhua wrote: Hi Steven, Steven wrote: Hi Zhenhua Zhang, Zhenhua wrote: Hi Steven, Steven wrote: Hi, In function ppp_receive, we first check the protocol type of this frame like: guint16 protocol = ppp_proto(buf); and here we assumed the length of the protocol

Re: About ppp_receive()

Hi Zhenhua, Zhang, Zhenhua wrote: Hi Steven, Steven wrote: Hi Zhenhua Zhang, Zhenhua wrote: Hi Steven, Steven wrote: Hi, In function ppp_receive, we first check the protocol type of this frame like: guint16 protocol = ppp_proto(buf); and here we assumed the length of the protocol

Re: About ppp_receive()

Hi Steven, But some carriers, like China Telecom or Sprint Network etc, will support the full configuration options(Magic-Number,Protocol-Field-Compression,Address-and-Control-Field-Compression), So if PFC option is used ,our code will got wrong with ppp_receive(). We explicitly do not

Re: About ppp_receive()

Denis Kenzior wrote: Hi Steven, But some carriers, like China Telecom or Sprint Network etc, will support the full configuration options(Magic-Number,Protocol-Field-Compression,Address-and-Control-Field-Compression), So if PFC option is used ,our code will got wrong with ppp_receive(). We

Re: About ppp_receive()

Hi Steven, NO, just as the above have said ,we only negotiate two options, it's ok for our PPP stack and it runs correctly. Then I'm confused. What is your concern here? :) Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: About ppp_receive()

Hi Denis, Denis Kenzior wrote: Hi Steven, NO, just as the above have said ,we only negotiate two options, it's ok for our PPP stack and it runs correctly. Then I'm confused. What is your concern here? :) currently, we worked on a Qualcomm CDMA chip, and it worked on a Relay mode, just

Re: About ppp_receive()

Hi Steven, NO, just as the above have said ,we only negotiate two options, it's ok for our PPP stack and it runs correctly. Then I'm confused. What is your concern here? :) currently, we worked on a Qualcomm CDMA chip, and it worked on a Relay mode, just relay the air PPP packet to

Re: About ppp_receive()

Marcel Holtmann wrote: Hi Steven, NO, just as the above have said ,we only negotiate two options, it's ok for our PPP stack and it runs correctly. Then I'm confused. What is your concern here? :) currently, we worked on a Qualcomm CDMA chip, and it worked on a Relay mode, just relay the air

Re: About ppp_receive()

Hi Steven, NO, just as the above have said ,we only negotiate two options, it's ok for our PPP stack and it runs correctly. Then I'm confused. What is your concern here? :) currently, we worked on a Qualcomm CDMA chip, and it worked on a Relay mode, just relay the air PPP packet to

Re: About ppp_receive()

Hi Marcel, Marcel Holtmann wrote: Hi Steven, NO, just as the above have said ,we only negotiate two options, it's ok for our PPP stack and it runs correctly. Then I'm confused. What is your concern here? :) currently, we worked on a Qualcomm CDMA chip, and it worked on a Relay mode, just

Re: About ppp_receive()

Hi Marcel, Steven wrote: Hi Marcel, Marcel Holtmann wrote: Hi Steven, NO, just as the above have said ,we only negotiate two options, it's ok for our PPP stack and it runs correctly. Then I'm confused. What is your concern here? :) currently, we worked on a Qualcomm CDMA chip, and it

Re: About ppp_receive()

Hi Steven, In function ppp_receive, we first check the protocol type of this frame like: guint16 protocol = ppp_proto(buf); and here we assumed the length of the protocol field is 16 bits, but in RFC 1661, the protocol field should be one or two octets. The Protocol field is one