Re: [Ohrrpgce] svn - git bridge, nohrio

2009-08-20 Thread David Gowers
my comments on coloruse.py: * record() appears to be dead code * unpackpt and friends need an alternate set of nohrio dtypes that have a proper shape, then ptshape would not be required here. I've added these as 'alt-pt%d' to my local NOHRIO -- but it's looking like they may end up as something

Re: [Ohrrpgce] svn - git bridge, nohrio

2009-08-20 Thread David Gowers
Further: offset = 0 if lumptype in self.lumpheaders: offset = self.lumpheaders[lumptype] try this instead: offset = self.lumpheaders.get (lumptype, 0) dict.get is very handy :D btw, I failed to read the documentation (which is in-code!) for gfx4bpp -- it is actually completely