Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] Text box Instead run script conditionals don't properly skip the text box (Issue #1252)

2023-04-11 Thread Ralph Versteegen via Ohrrpgce
One unrelated thing I noticed is that before conversion to text slices, the first line (or two?) of a textbox appears at the same time as the box, while afterwards it seems to appear one tick later. I don't know which is preferable. The modern is probably better for people trying to modify the b

Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] Text box Instead run script conditionals don't properly skip the text box (Issue #1252)

2023-04-11 Thread Ralph Versteegen via Ohrrpgce
Well this is already an incompatibility between different versions. We should fix this (I want to add an actual "Trigger script" conditional) but not without a backcompat bit, it would probably break a huge number of games because it's easy to stumble upon, and before ypsiliform "Instead: run sc

Re: [Ohrrpgce] [ohrrpgce/ohrrpgce] Text box Instead run script conditionals don't properly skip the text box (Issue #1252)

2023-04-11 Thread James Paige via Ohrrpgce
I can confirm that the intention was always for instead scripts to completely skip the text box. The behavior was supposed to be the same as an instead text box. If a text box has an "instead" box or script that is always run, then one of the other settings are supposed to matter. Does this bu

[Ohrrpgce] [ohrrpgce/ohrrpgce] Text box Instead run script conditionals don't properly skip the text box (Issue #1252)

2023-04-11 Thread Ralph Versteegen via Ohrrpgce
The problem is that in `loadsay`, if an Instead condition runs a script instead of the box, then the rest of `loadsay` is skipped, so the box isn't displayed, `txt.id` isn't set to the new ID, and `txt.showing` isn't set. But all the textbox data is actually loaded into `txt`, and `txt.id` and `