Re: [Oiio-dev] TBB question

2012-04-09 Thread Matteo F. Vescovi
Hi! On 10/04/2012 07:28, Larry Gritz wrote: In light of this, should we: 0. Do nothing -- use TBB by default, but allow optional build time USE_TBB=0 to turn it off (necessary for platforms that TBB does not support). 1. Use our own code (i.e. USE_TBB=0) by default, but allow USE_TBB=1 to opt

Re: [Oiio-dev] TBB question

2012-04-09 Thread Larry Gritz
I'm pretty sure that OSL just uses whatever threading and atomics that OIIO uses, so if OIIO loses TBB dependency, so does OSL. On Apr 9, 2012, at 10:30 PM, Erich Ocean wrote: > Hi Larry, > > Would TBB still be required by OSL with options 2 and 3? > > If not, that'd be my vote (I'm pretty mu

Re: [Oiio-dev] TBB question

2012-04-09 Thread Erich Ocean
Hi Larry, Would TBB still be required by OSL with options 2 and 3? If not, that'd be my vote (I'm pretty much always in favor of reducing dependencies). Best, Erich On Apr 9, 2012, at 10:28 PM, Larry Gritz wrote: > Related to this pull request: https://github.com/OpenImageIO/oiio/pull/273 >

[Oiio-dev] TBB question

2012-04-09 Thread Larry Gritz
Related to this pull request: https://github.com/OpenImageIO/oiio/pull/273 I made some benchmarks and determined that our own homegrown atomic_int is exactly the same performance as what we get from TBB. After beefing up our spin_mutex implementation, we are still slower than TBB's, but with

Re: [Oiio-dev] Building iv on OSX?

2012-04-09 Thread P. Martin
The short version for Unix geeks: Install Homebrew ( http://mxcl.github.com/homebrew/ ) into /usr/local brew update brew doctor brew install qt Copy the raw formula from https://github.com/mxcl/homebrew/pull/8458 into /usr/local/Library/Formula brew install -vd --with-tests openimageio Then get

Re: [Oiio-dev] Building iv on OSX?

2012-04-09 Thread Jonathan Gibbs
On Mon, Apr 9, 2012 at 11:52 AM, Colin Doncaster wrote: > I realize that you're looking for the path of least resistance, but I guess > my point is that being clear on using the QTDIR variable and what that means > for CMake vs. having users rely on macports feels more general and safer - I > thin

Re: [Oiio-dev] Building iv on OSX?

2012-04-09 Thread Simon Eves
+1 Also, not that I've tried it myself, but to ensure that OIIO can be built against Qt installed as a Framework. Simon Colin Doncaster wrote: > > Would it not be easier just to explain to users to specify the QTDIR > environment variables to make sure that CMake finds them?  The only > differe

Re: [Oiio-dev] Building iv on OSX?

2012-04-09 Thread Colin Doncaster
Would it not be easier just to explain to users to specify the QTDIR environment variables to make sure that CMake finds them? The only difference between the macports method and yours is that macports will push the libs and binaries into /usr/local/ vs. some arbitrary location. Homebrew is a

Re: [Oiio-dev] Building iv on OSX?

2012-04-09 Thread Daniel Wexler
More generally, I think there should be step-by-step instructions which show how to install all the required dependencies and test images so that you can build all the OIIO tools and run the tests with no errors. The current docs recommend downloading Qt from a broken link. Maybe they should inst

Re: [Oiio-dev] Building iv on OSX?

2012-04-09 Thread Daniel Wexler
Can you provide the exact line required for installation? I don't use MacPorts except that long ago you told me how to install it. Maybe we should put the instructions for installing MacPorts into the INSTALL doc and wiki page? I think that's how I magically got a bunch of the other requirements

Re: [Oiio-dev] Building iv on OSX?

2012-04-09 Thread Larry Gritz
I installed Qt with Macports, fire and forget. -- lg On Apr 9, 2012, at 8:35 AM, Daniel Wexler wrote: > The Wiki and Google Code docs are a bit light on the external dependencies > and build instructions required to enable iv. I think we should have a > section in the INSTALL doc and

[Oiio-dev] Building iv on OSX?

2012-04-09 Thread Daniel Wexler
The Wiki and Google Code docs are a bit light on the external dependencies and build instructions required to enable iv. I think we should have a section in the INSTALL doc and on the wikis that describe the steps needed to download, build and install the dependencies required for iv. I'm happy to

[Oiio-dev] [oiio] Testsuite fixes and improvements (#280)

2012-04-09 Thread Edgar Velázquez-Armendáriz
1. Cleaned up the testsuite main script and made the appropriate fixes so that the tests run properly when using the Visual Studio generators. 2. Removed the external commands for comparing non-image files and replaced them by pure Python versions using the ```difflib``` (for text files) and ``

[Oiio-dev] [oiio] Minor MSVC fixes (#281)

2012-04-09 Thread Edgar Velázquez-Armendáriz
1. Fixed the image spec test under MSVC: its ```std::string``` internal layout is different than the gcc one. 2. Fixed a runtime exception in ```Strutil::unescape_chars``` under MSVC in debug mode due to an out of bounds string access. 3. Link against psapi.lib not only when using MSVC but also f

[Oiio-dev] [oiio] Better looking README for GitHub (#282)

2012-04-09 Thread Henri Fousse
rename README so that it is interpreted as REstructured Text by GitHub and looks nicer + tiny cosmetic changes You can merge this Pull Request by running: git pull https://github.com/darkhorse64/oiio master Or you can view, comment on it, or merge it online at: https://github.com/OpenImage