Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

2013-08-15 Thread Eugene Shalygin
> On Aug. 15, 2013, 11:03 p.m., Albert Astals Cid wrote: > > > > Eugene Shalygin wrote: > Thanks for the review! I've tried to fix the issues. The only one left is > question with Generator::DPI. I've replaced it with QSizeF (not the best > choice, I know). Somehow keeping both X and Y dpi

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

2013-08-15 Thread Albert Astals Cid
> On Aug. 15, 2013, 9:03 p.m., Albert Astals Cid wrote: > > > > Eugene Shalygin wrote: > Thanks for the review! I've tried to fix the issues. The only one left is > question with Generator::DPI. I've replaced it with QSizeF (not the best > choice, I know). Somehow keeping both X and Y dpis

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

2013-08-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111829/#review37905 --- Agreed with you, a QSizeF is not good either, why you don't wan

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

2013-08-15 Thread Eugene Shalygin
> On Aug. 15, 2013, 11:03 p.m., Albert Astals Cid wrote: > > Thanks for the review! I've tried to fix the issues. The only one left is question with Generator::DPI. I've replaced it with QSizeF (not the best choice, I know). Somehow keeping both X and Y dpis together makes me happy :) Is it go

[Okular-devel] [okular] [Bug 323563] incorrect rendering while viewing PDF; it does print correctly

2013-08-15 Thread jdietrch
https://bugs.kde.org/show_bug.cgi?id=323563 --- Comment #5 from jdiet...@fastmail.fm --- I do have Trim Margins enabled, and unchecking it makes the PDF display correctly. Though it is a mystery to me how that box got checked. I am quite certain I didn't check it myself. Is it perhaps turned on b

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

2013-08-15 Thread Eugene Shalygin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111829/ --- (Updated Aug. 16, 2013, 12:46 a.m.) Review request for Okular and Albert A

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

2013-08-15 Thread Eugene Shalygin
> On Aug. 15, 2013, 11:03 p.m., Albert Astals Cid wrote: > > core/generator.h, line 214 > > > > > > Do we really need this class? I think I'd do with just > > > > setDPI(qreal dpiX, qreal dpiY) > > >

[Okular-devel] [okular] [Bug 308683] Okular does not remember display preferences for documents on refresh or reopen

2013-08-15 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=308683 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[Okular-devel] [okular] [Bug 308683] Okular does not remember display preferences for documents on refresh or reopen

2013-08-15 Thread reescf
https://bugs.kde.org/show_bug.cgi?id=308683 --- Comment #9 from ree...@gmail.com --- Yes. As far as I am concerned, this bug has been wholly superseded. Thanks for help clarifying my request. -- You are receiving this mail because: You are the assignee for the bug. __

[Okular-devel] [okular] [Bug 310343] Okular crashed while watching embedded video

2013-08-15 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=310343 Albert Astals Cid changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[Okular-devel] [okular] [Bug 303607] Opening a document

2013-08-15 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=303607 Albert Astals Cid changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[Okular-devel] [okular] [Bug 311037] Okular Crashs

2013-08-15 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=311037 Albert Astals Cid changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[Okular-devel] [okular] [Bug 315354] okular crashed when i opened a .mobi format file

2013-08-15 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=315354 Albert Astals Cid changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[Okular-devel] [okular] [Bug 313986] various lines are displayed at one line

2013-08-15 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=313986 Albert Astals Cid changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[Okular-devel] [okular] [Bug 311885] Bottom page bar waste to much vertical space

2013-08-15 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=311885 Albert Astals Cid changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[Okular-devel] [okular] [Bug 311775] crash if I use button 'Previous' in finding words in pdf

2013-08-15 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=311775 Albert Astals Cid changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

2013-08-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111829/#review37877 --- CMakeLists.txt

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

2013-08-15 Thread Albert Astals Cid
> On Aug. 15, 2013, 9:03 p.m., Albert Astals Cid wrote: > > generators/poppler/generator_pdf.cpp, line 683 > > > > > > Don't use this-> makes me unhappy to see it in C++ code :D Forgot to add: Do we really need

[Okular-devel] [okular] [Bug 323563] incorrect rendering while viewing PDF; it does print correctly

2013-08-15 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=323563 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO CC|

[Okular-devel] [okular] [Bug 323563] incorrect rendering while viewing PDF; it does print correctly

2013-08-15 Thread jdietrch
https://bugs.kde.org/show_bug.cgi?id=323563 --- Comment #2 from jdiet...@fastmail.fm --- Created attachment 81732 --> https://bugs.kde.org/attachment.cgi?id=81732&action=edit This is the wrong rendering seen in okular -- You are receiving this mail because: You are the assignee for the bug. __

[Okular-devel] [okular] [Bug 323563] incorrect rendering while viewing PDF; it does print correctly

2013-08-15 Thread jdietrch
https://bugs.kde.org/show_bug.cgi?id=323563 --- Comment #3 from jdiet...@fastmail.fm --- Created attachment 81733 --> https://bugs.kde.org/attachment.cgi?id=81733&action=edit This is the correct rendering seen in evince -- You are receiving this mail because: You are the assignee for the bug.

[Okular-devel] [okular] [Bug 323563] incorrect rendering while viewing PDF; it does print correctly

2013-08-15 Thread jdietrch
https://bugs.kde.org/show_bug.cgi?id=323563 --- Comment #1 from jdiet...@fastmail.fm --- Created attachment 81731 --> https://bugs.kde.org/attachment.cgi?id=81731&action=edit PDF that doesn't render correctly -- You are receiving this mail because: You are the assignee for the bug. ___

[Okular-devel] [okular] [Bug 323563] New: incorrect rendering while viewing PDF; it does print correctly

2013-08-15 Thread jdietrch
https://bugs.kde.org/show_bug.cgi?id=323563 Bug ID: 323563 Summary: incorrect rendering while viewing PDF; it does print correctly Classification: Unclassified Product: okular Version: unspecified Platform: Debian stabl

[Okular-devel] [Active] [Bug 308240] active-documentviewer crashes by using zoom gestures

2013-08-15 Thread Fabio D'Urso
https://bugs.kde.org/show_bug.cgi?id=308240 Fabio D'Urso changed: What|Removed |Added CC||fabiodu...@hotmail.it -- You are receiving this

[Okular-devel] [okular] [Bug 323484] Okular crashes with a particular PDF

2013-08-15 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=323484 Albert Astals Cid changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO