[Okular-devel] [okular] [Bug 353401] Feature requst: "typewriter" annotation tool

2015-12-02 Thread noric via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=353401 --- Comment #9 from noric --- I asked Poppler's devs and they say FreeText is already implemented in Poppler. They say the actual typewriter tool needs to be implemented by Okular (and other readers relying on Poppler). -- You are receiving this mail

[Okular-devel] [okular] [Bug 353401] Feature requst: "typewriter" annotation tool

2015-12-02 Thread Sumit Sahrawat via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=353401 --- Comment #10 from Sumit Sahrawat --- Thanks for the info noric. I'm willing to work on this, and will start soon if nobody has already begun. -- You are receiving this mail because: You are the assignee for the bug.

Re: [Okular-devel] Review Request 126214: Allow enqueuing of sound annotations for playback

2015-12-02 Thread Sumit Sahrawat
> On Dec. 2, 2015, 12:03 a.m., Albert Astals Cid wrote: > > core/audioplayer.h, line 69 > > > > > > Do not change public API without a good reason (it's a typo is not a > > good reason :D) It was not a typo. It

Re: [Okular-devel] Review Request 126214: Allow enqueuing of sound annotations for playback

2015-12-02 Thread Sumit Sahrawat
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126214/#review89054 --- Looking at the code, it seems like the 'Stop Sound' option onl

Re: [Okular-devel] Greetings - William Oliver

2015-12-02 Thread William Oliver
Thanks Sumit. I'll get it to build when I get home. On Dec 2, 2015 2:05 AM, "Sumit Sahrawat, Maths & Computing, IIT (BHU)" < sumit.sahrawat.ap...@iitbhu.ac.in> wrote: > Hi William, > > I've also just started contributing to Okular, so I think I can help. > > I didn't know anything when I started,

Re: [Okular-devel] Review Request 126214: Allow enqueuing of sound annotations for playback

2015-12-02 Thread Albert Astals Cid
> On des. 2, 2015, 12:03 a.m., Albert Astals Cid wrote: > > core/audioplayer.h, line 69 > > > > > > Do not change public API without a good reason (it's a typo is not a > > good reason :D) > > Sumit Sahrawat wro

Re: [Okular-devel] Review Request 126214: Allow enqueuing of sound annotations for playback

2015-12-02 Thread Albert Astals Cid
> On des. 2, 2015, 5:11 p.m., Sumit Sahrawat wrote: > > Looking at the code, it seems like the 'Stop Sound' option only appears > > when sound is playing. Which means that there is nothing left to be done > > before the enqueuing bit. After reading the code and thinking a bit more about it, I

Re: [Okular-devel] Review Request 126214: Allow enqueuing of sound annotations for playback

2015-12-02 Thread Sumit Sahrawat
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126214/ --- (Updated Dec. 3, 2015, 7:23 a.m.) Status -- This change has been dis

Re: [Okular-devel] Review Request 126214: Allow enqueuing of sound annotations for playback

2015-12-02 Thread Sumit Sahrawat
> On Dec. 2, 2015, 5:11 p.m., Sumit Sahrawat wrote: > > Looking at the code, it seems like the 'Stop Sound' option only appears > > when sound is playing. Which means that there is nothing left to be done > > before the enqueuing bit. > > Albert Astals Cid wrote: > After reading the code a