[okular] [Bug 368229] [Frameworks] 'change light & dark colors' broken

2016-09-04 Thread Christoph Feck via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368229 Christoph Feck changed: What|Removed |Added CC||cf...@kde.org --- Comment #1

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-09-04 Thread Oliver Sander
> On Sept. 4, 2016, 3:38 p.m., Anthony Fieroni wrote: > > ui/pageview.cpp, line 1504 > > > > > > Martin wants early return for code clarification > > if (!pinch) { > > return false; > > } I

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-09-04 Thread Oliver Sander
> On Sept. 4, 2016, 3:35 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ui/pageview.h, line 134 > > > > > > nitpick; inconsistent spacing Okay - Oliver

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-09-04 Thread Oliver Sander
> On Sept. 4, 2016, 10:14 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > ui/pageview.cpp, line 1500 > > > > > > Don't put assignments in the if condition. > > > > Also, prefer to do an early exit,

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-09-04 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/ --- (Updated Sept. 4, 2016, 7:48 p.m.) Review request for Okular. Changes

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-09-04 Thread Martin Tobias Holmedahl Sandsmark
> On Sept. 4, 2016, 10:14 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > ui/pageview.cpp, line 1505 > > > > > > potentially uninitialized, add some default value. > > Oliver Sander wrote: > Okay. > >

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-09-04 Thread Anthony Fieroni
> On Септ. 4, 2016, 1:14 след обяд, Martin Tobias Holmedahl Sandsmark wrote: > > ui/pageview.cpp, line 1505 > > > > > > potentially uninitialized, add some default value. > > Oliver Sander wrote: > Okay.

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-09-04 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/#review98878 --- Early return to don't have semicolumn below.

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-09-04 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/#review98876 --- Ship it! just some nitpicks, but nothing I think should

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-09-04 Thread Martin Tobias Holmedahl Sandsmark
> On Sept. 4, 2016, 10:14 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > ui/pageview.cpp, line 1500 > > > > > > Don't put assignments in the if condition. > > > > Also, prefer to do an early exit,

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-09-04 Thread Oliver Sander
> On Sept. 4, 2016, 10:14 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > I don't have a touch screen to test with, unfortunately. To bad. :-) Thanks for the reviews. > On Sept. 4, 2016, 10:14 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > ui/pageview.cpp, line 1490 > >

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-09-04 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/ --- (Updated Sept. 4, 2016, 3:16 p.m.) Review request for Okular. Changes

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-09-04 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/#review98864 --- I don't have a touch screen to test with, unfortunately.

[okular] [Bug 368220] Animated GIFs don't play

2016-09-04 Thread kmi via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368220 kmi changed: What|Removed |Added Resolution|--- |INVALID Status|UNCONFIRMED

[okular] [Bug 368229] New: [Frameworks] 'change light & dark colors' broken

2016-09-04 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368229 Bug ID: 368229 Summary: [Frameworks] 'change light & dark colors' broken Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED