[okular] [Bug 366781] [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-10-05 Thread Simon Andric via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366781 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com -- You are receiving thi

Re: Review Request 128858: [frameworks] Hide cursor when tablet pen leaves proximity of the screen

2016-10-05 Thread Oliver Sander
> On Oct. 4, 2016, 9:21 p.m., Albert Astals Cid wrote: > > > I had to add code to the mouseMoveEvent class, to make the arrow cursor > > > appear when the mouse is moved. > > > Otherwise, after a TabletLeaveProximity event causes the cursor to > > > disappear, moving the mouse will > > > ot mak

Re: Review Request 128858: [frameworks] Hide cursor when tablet pen leaves proximity of the screen

2016-10-05 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128858/ --- (Updated Oct. 5, 2016, 4:20 p.m.) Review request for Okular. Changes --

Re: Review Request 128858: [frameworks] Hide cursor when tablet pen leaves proximity of the screen

2016-10-05 Thread Oliver Sander
> On Oct. 4, 2016, 9:21 p.m., Albert Astals Cid wrote: > > ui/presentationwidget.cpp, line 544 > > > > > > You should return true for the events you actually handle i guess Not sure, but so far I have read the d

[okular] [Bug 267350] filling out a PDF form saves data to some file i ~/.kde/share/apps/okular/docdata/

2016-10-05 Thread Niels Elgaard via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=267350 Niels Elgaard changed: What|Removed |Added CC||elga...@agol.dk --- Comment #48 from Niels Elga

[okular] [Bug 368598] Zoom Out does not work when zoom is set to Fit Page or Fit Width

2016-10-05 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368598 a...@rossberg.net changed: What|Removed |Added CC||a...@rossberg.net --- Comment #1 from a...@r

Re: Review Request 129099: Make m_drawingEngine a std::unique_ptr

2016-10-05 Thread Oliver Sander
> On Oct. 4, 2016, 9 p.m., Albert Astals Cid wrote: > > I honestly don't see the benefit > > > > You changed a delete by a reset, is there any benefit at all other than > > making the code harder to read? > > Oliver Sander wrote: > I see three benefits: > a) I can see by looking at the