rkflx added a comment.
Do you suggest I should write my own bool-based RAII wrapper, which would be
racy, less efficient, buggy, more verbose and harder to read? Using a mutex
solves the maintainability risk outlined in
https://phabricator.kde.org/D7495#141032 with no costs. Also, when resea
aacid added a comment.
Using a mutex when threads are not involved is wrong in my book, and that's
why my branch uses a bool as customary
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7595
To: rkflx, #okular
Cc: aacid
rkflx added a comment.
Good catch, I stumbled upon this bug before. This even prevents segfaults on
exit.
However, I think there's a potentially costly maintainability risk: When
someone wants to change some code in slotDoFileDirty(), it's quite easy to
forget resetting your new bool, c
rkflx created this revision.
Restricted Application added a project: Okular.
REVISION SUMMARY
When pressing and holding [F5], Okular would reload the current
document multiple times and eventually get stuck with no document
showing and the "Reloading the document..." message reappearing ever
https://bugs.kde.org/show_bug.cgi?id=383980
Henrik Fehlauer changed:
What|Removed |Added
CC||rk...@lab12.net
Status|UNCONFIRME
https://bugs.kde.org/show_bug.cgi?id=383915
Henrik Fehlauer changed:
What|Removed |Added
CC||eugene.shalygin+bugzilla.kd
https://bugs.kde.org/show_bug.cgi?id=383915
Henrik Fehlauer changed:
What|Removed |Added
Status|CONFIRMED |ASSIGNED
--- Comment #9 from Henrik Fehlauer
rkflx created this revision.
Restricted Application added a project: Okular.
REVISION SUMMARY
This should prevent crashes when reloading some synctex-enabled pdf
files created with newer versions of TeXLive. We also gain bugfixes,
features and improved accuracy from the last 6 years of synct
https://bugs.kde.org/show_bug.cgi?id=383915
Henrik Fehlauer changed:
What|Removed |Added
CC||rk...@lab12.net
--- Comment #8 from Henrik Fe
