[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #12 from Nate Graham --- Ah, thanks Albert. Changed. -- You are receiving this mail because: You are the assignee for the bug.

D7662: Draw a dark rectangle around highlighted search results

2017-09-02 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7662 To: sander, #okular Cc: aacid, ngraham

D7662: Draw a dark rectangle around highlighted search results

2017-09-02 Thread Albert Astals Cid
aacid added a comment. This applies to all highlights, i.e. text selection too, are you sure we want that? There's something weird going on with the drawing, i can easily get a bad state, see http://i.imgur.com/wDAQlcP.png which is https://ev.kde.org/reports/2017-en.pdf having searched

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #11 from Albert Astals Cid --- I don't think that's going to work, i'm 92.46% sure that BUG: needs to be at the beginning of the line at alone, not in a sentence like you wrote it. -- You are receiving this mail because: You are the assign

Re: Review Request 130238: Draw a dark rectangle around highlighted search results

2017-09-02 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130238/ --- (Updated set. 2, 2017, 8:01 p.m.) Status -- This change has been dis

Re: Review Request 130238: Draw a dark rectangle around highlighted search results

2017-09-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130238/#review103687 --- I'm confused, did you open a reviewboard request and a phabr

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=384267 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED

D7662: Draw a dark rectangle around highlighted search results

2017-09-02 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7662 To: sander, #okular Cc: ngraham, aacid

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #9 from Oliver Sander --- https://phabricator.kde.org/D7662 -- You are receiving this mail because: You are the assignee for the bug.

D7662: Draw a dark rectangle around highlighted search results

2017-09-02 Thread Oliver Sander
sander created this revision. Restricted Application added a project: Okular. REVISION SUMMARY This makes it easier to distinguish them from text with a 'highlight' annotation. This fixes https://bugs.kde.org/show_bug.cgi?id=355043 REPOSITORY R223 Okular REVISION DETAIL https://

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #8 from Nate Graham --- Reviewboard is going away soon. Can you upload your to our Phabricator instance? https://phabricator.kde.org -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #7 from Oliver Sander --- No need for KColorUtils, QColor has 'darken' natively. Feel free to play with the parameter. Patch is at https://git.reviewboard.kde.org/r/130238/ -- You are receiving this mail because: You are the assignee

[okular] [Bug 355043] Cannot differentiate between review and search highlights

2017-09-02 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=355043 --- Comment #6 from Oliver Sander --- My patch is at https://git.reviewboard.kde.org/r/130238/ The above-mentioned preparatory patch has been committed as 024d25cdeca11f9cd012b4e5099b1b4cb91826de -- You are receiving this mail because: You ar

Review Request 130238: Draw a dark rectangle around highlighted search results

2017-09-02 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130238/ --- Review request for Okular. Bugs: 355043 http://bugs.kde.org/show_bug.

[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

2017-09-02 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=384185 Albert Astals Cid changed: What|Removed |Added Version|1.3.70 |1.2.70 -- You are receiving this mail beca

[okular] [Bug 383943] HiDPI: Rendering glitches near the page boundaries

2017-09-02 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=383943 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Version|1.3.70

[okular] [Bug 383589] Annotation toolbar icons are blurry on a Hidpi screen

2017-09-02 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=383589 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Version|1.3.70

[okular] [Bug 383980] Okular crashes when latex updates synctex

2017-09-02 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=383980 Albert Astals Cid changed: What|Removed |Added Version|1.3.70 |1.2.70 CC|

[okular] [Bug 384143] HiPDI: freehand line in presentation mode is blocky

2017-09-02 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=384143 Albert Astals Cid changed: What|Removed |Added Version|1.3.70 |1.2.70 CC|

D7594: Update to synctex 1.19

2017-09-02 Thread Albert Astals Cid
aacid added a comment. In https://phabricator.kde.org/D7594#141938, @rkflx wrote: > When I run the command you specified, I only get QtTest output. Did you run cmake with `-DECM_ENABLE_SANITIZERS=leak`? address instead of clang, but the output should be the same > Did you use

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

2017-09-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=384267 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com -- You are receiving this