Re: Review Request 128858: [frameworks] Hide cursor when tablet pen leaves proximity of the screen

2017-09-06 Thread Oliver Sander
> On Sept. 6, 2017, 8:24 p.m., Albert Astals Cid wrote: > > ui/presentationwidget.cpp, line 1305 > > > > > > Why this change? Previously, the code there was slotChangeDrawingToolEngine( QDomElement() );

Re: Review Request 126406: Okular should warn if closing with multiple tabs opened

2017-09-06 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126406/#review103695 --- I'm going to close this one in favour of

D7714: Show dialog to ask when closing when more than tab open

2017-09-06 Thread Albert Astals Cid
aacid created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. REVISION SUMMARY The checkbox is checked and says "Warn me on closing more than one tab", for that reason we can't use the default KMessageBox::questionYesNo since

Re: Review Request 128858: [frameworks] Hide cursor when tablet pen leaves proximity of the screen

2017-09-06 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128858/#review103694 --- ui/presentationwidget.cpp (line 1305)

Re: Review Request 130226: CHM Generator Lib Update

2017-09-06 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130226/#review103693 --- Ship it! I don't have many files to test not many

Re: Review Request 130057: Bug 288042 - Option to reset forms

2017-09-06 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130057/#review103692 --- When you open

D7671: Fix automatic reload of files saved with QSaveFile

2017-09-06 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. In https://phabricator.kde.org/D7671#143401, @progwolff wrote: > In https://phabricator.kde.org/D7671#143269, @aacid wrote: > > > Have you read my email? There clearly says what

D7671: Fix automatic reload of files saved with QSaveFile

2017-09-06 Thread Albert Astals Cid
aacid added a comment. In https://phabricator.kde.org/D7671#143360, @rkflx wrote: > In https://phabricator.kde.org/D7671#143117, @aacid wrote: > > > It was added to make this work, and it did work at some point, i don't add code for nothing ;) > > > Of course, and your code

D7688: Implement rasterized printing with QPrinter with hidden annotations

2017-09-06 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7688 To: sander, #okular, aacid Cc: aacid

D7688: Implement rasterized printing with QPrinter with hidden annotations

2017-09-06 Thread Oliver Sander
sander added a comment. Indeed. I was somehow expecting this to happen automatically. :-) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7688 To: sander, #okular Cc: aacid

D7688: Implement rasterized printing with QPrinter with hidden annotations

2017-09-06 Thread Oliver Sander
sander updated this revision to Diff 19240. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7688?vs=19165=19240 REVISION DETAIL https://phabricator.kde.org/D7688 AFFECTED FILES generators/poppler/CMakeLists.txt

[okular] [Bug 362856] [Frameworks] Wrong render resolution, possibly caused by Plasma 5 "Scale Display"

2017-09-06 Thread Fest
https://bugs.kde.org/show_bug.cgi?id=362856 Fest changed: What|Removed |Added CC||fest...@gmail.com -- You are

D7671: Fix automatic reload of files saved with QSaveFile

2017-09-06 Thread Julian Wolff
progwolff added a comment. In https://phabricator.kde.org/D7671#143269, @aacid wrote: > Have you read my email? There clearly says what happens and what the documentation says it should happen (at least to my understanding of reading it). Sure, I read your mail. But I still