[okular] [Bug 384147] Hovering over annotations no longer shows contents in tooltip

2017-09-17 Thread Michael D
https://bugs.kde.org/show_bug.cgi?id=384147 --- Comment #7 from Michael D --- Created attachment 107893 --> https://bugs.kde.org/attachment.cgi?id=107893&action=edit Sample pdf I'm using -- You are receiving this mail because: You are the assignee for the bug.

D7662: Draw a dark rectangle around highlighted search results

2017-09-17 Thread Christoph Feck
cfeck added a comment. See http://doc.qt.io/qt-5/coordsys.html for differences in coordinate system between aliased rectangles and anti-aliased rectangles. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7662 To: sander, #okular Cc: cfeck, aacid, ngraham

[okular] [Bug 384147] Hovering over annotations no longer shows contents in tooltip

2017-09-17 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=384147 --- Comment #6 from Christoph Feck --- If you can provide the information requested in comment #5, please add it. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 383877] Vertical okular_part toolbar should split page number widget

2017-09-17 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=383877 Christoph Feck changed: What|Removed |Added Severity|normal |wishlist -- You are receiving this mail becau

D7714: Show dialog to ask when closing when more than tab open

2017-09-17 Thread Albert Astals Cid
aacid abandoned this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7714 To: aacid, #okular, #kde_applications Cc: alexeymin, ngraham, colomar, rkflx, #okular, aacid

D7714: Show dialog to ask when closing when more than tab open

2017-09-17 Thread Albert Astals Cid
aacid requested review of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7714 To: aacid, #okular, #kde_applications Cc: alexeymin, ngraham, colomar, rkflx, #okular, aacid

[okular] [Bug 334019] Okular should warn if closing with multiple tabs opened

2017-09-17 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=334019 Albert Astals Cid changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|---

D7714: Show dialog to ask when closing when more than tab open

2017-09-17 Thread Albert Astals Cid
aacid planned changes to this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7714 To: aacid, #okular, #kde_applications Cc: alexeymin, ngraham, colomar, rkflx, #okular, aacid

D7714: Show dialog to ask when closing when more than tab open

2017-09-17 Thread Albert Astals Cid
aacid added a comment. I'm going to commit this since it seems Henrik has a plan for the bigger thing. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7714 To: aacid, #okular, #kde_applications Cc: alexeymin, ngraham, colomar, rkflx, #okular, aacid

Re: Review Request 129893: Implement continuous search

2017-09-17 Thread Albert Astals Cid
> On set. 17, 2017, 10:20 a.m., Elvis Angelaccio wrote: > > Ping? Or should I re-upload the patch on phabricator for better visibility? Code is still wrong, what more visibility do you want? If you're not going to allow for yes/no, why do you need a roundtrip to the ui to decide to continue th

Re: Review Request 130219: Enable background color to be changed from settings

2017-09-17 Thread Albert Freeman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130219/ --- (Updated Sept. 17, 2017, 1:05 p.m.) Review request for Okular. Changes

Re: Review Request 130219: Enable background color to be changed from settings

2017-09-17 Thread Albert Freeman
> On Aug. 9, 2017, 6:24 p.m., Albert Astals Cid wrote: > > Thanks for contributing to Okular :) > > > > Why would you need a different background color? > > Albert Freeman wrote: > I personally much prefer black as a background color. > > Albert Astals Cid wrote: > Maybe you could edit

Re: Review Request 129893: Implement continuous search

2017-09-17 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/#review103715 --- Ping? Or should I re-upload the patch on phabricator for bet

D7714: Show dialog to ask when closing when more than tab open

2017-09-17 Thread Henrik Fehlauer
rkflx added a comment. That's great, now code can be written. To track progress (but not to discuss with other application developers as requested, at least for now) I opened https://phabricator.kde.org/T7022. Any help is welcome, please add your name if you start working on an item and/