[okular] [Bug 384970] Esc after reading a comment

2017-10-01 Thread Luciana
https://bugs.kde.org/show_bug.cgi?id=384970 --- Comment #2 from Luciana --- I appreciate your prompt response and I'm sorry for my late reply. I had my problem solved with a newer version. Thanks. -- You are receiving this mail because: You are the assignee for the

[okular] [Bug 374539] Crash when viewing a rotated PDF

2017-10-01 Thread Mariusz Libera
https://bugs.kde.org/show_bug.cgi?id=374539 Mariusz Libera changed: What|Removed |Added CC|

D8051: Custom background color

2017-10-01 Thread Luigi Toscano
ltoscano added a comment. It is, but when you did `arc patch `, the patch committed locally ended up with you as author because the patch had no authorship information. So yes, arc patch, then check the author and if incorrect fix it (see the message in

D8051: Custom background color

2017-10-01 Thread Nathaniel Graham
ngraham added a comment. Sorry about that, guys. I just did `arc land`. Was that not the right approach to land this? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8051 To: albertfreeman, #okular, aacid, elvisangelaccio, rkflx, ngraham Cc: aacid, ltoscano, ngraham

D8051: Custom background color

2017-10-01 Thread Luigi Toscano
ltoscano added a comment. Both are In https://phabricator.kde.org/D8051#151095, @rkflx wrote: > In https://phabricator.kde.org/D8051#151091, @ltoscano wrote: > > > this was committed with the wrong authorship. please revert and commit again with the right author. > > > I

D8051: Custom background color

2017-10-01 Thread Henrik Fehlauer
rkflx added a comment. In https://phabricator.kde.org/D8051#151091, @ltoscano wrote: > this was committed with the wrong authorship. please revert and commit again with the right author. I already raised this in

D8051: Custom background color

2017-10-01 Thread Albert Freeman
albertfreeman added a comment. I didn't use Arcanist. I recreated it via the phabricator.kde.org interface. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8051 To: albertfreeman, #okular, aacid, elvisangelaccio, rkflx, ngraham Cc: aacid, ltoscano, ngraham

D8051: Custom background color

2017-10-01 Thread Luigi Toscano
ltoscano added a comment. Ok, reverted and repushed. @albertfreeman I've got your email from the old review on phabricator. Unfortunately this review did not contain the details. How did you send this review here? Did you use arcanist? REPOSITORY R223 Okular REVISION DETAIL

[okular] [Bug 182994] Allow user to change background colour

2017-10-01 Thread Luigi Toscano
https://bugs.kde.org/show_bug.cgi?id=182994 Luigi Toscano changed: What|Removed |Added Latest Commit|https://commits.kde.org/oku

D8051: Custom background color

2017-10-01 Thread Luigi Toscano
ltoscano added a comment. this was committed with the wrong authorship. please revert and commit again with the right author. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8051 To: albertfreeman, #okular, aacid, elvisangelaccio, rkflx, ngraham Cc: aacid, ltoscano,

Re: Review Request 130219: Enable background color to be changed from settings

2017-10-01 Thread Albert Freeman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130219/ --- (Updated Oct. 1, 2017, 6:34 a.m.) Status -- This change has been

Re: Review Request 130219: Enable background color to be changed from settings

2017-10-01 Thread Albert Freeman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130219/ --- (Updated Oct. 1, 2017, 6:33 a.m.) Status -- This change has been