D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

2017-10-25 Thread Henrik Fehlauer
rkflx added a comment. > So, if there are a lot of products with new features, they're bundled to some new version? Like from 16.12 to 17.04 . Is this also controlled by any kind of CI, to bundle them? Sorry, if I ask too much, I'm just curious about the whole process :) You can look

D7662: Draw a dark rectangle around highlighted search results

2017-10-25 Thread Albert Astals Cid
aacid added a comment. leave it around i'll try to have a look somewhen/sometime or maybe someone else picks it up. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7662 To: sander, #okular Cc: cfeck, aacid, ngraham

[okular] [Bug 385951] Some applications dont show menubar after disabling global menu again

2017-10-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=385951 Nate Graham changed: What|Removed |Added Target Milestone|1.0 |---

[okular] [Bug 386176] okular: CMake Error in generators/spectre/CMakeLists.txt

2017-10-25 Thread Eugene Shalygin
https://bugs.kde.org/show_bug.cgi?id=386176 --- Comment #4 from Eugene Shalygin --- I use cmake 3.10 rc3. Maybe this version is stricter. Anyway, okular_add_generator() calls a function from kf5 which creates a plugin. Could a plugin be not a MODULE? --

[okular] [Bug 386176] okular: CMake Error in generators/spectre/CMakeLists.txt

2017-10-25 Thread Luigi Toscano
https://bugs.kde.org/show_bug.cgi?id=386176 Luigi Toscano changed: What|Removed |Added CC|

[okular] [Bug 386176] okular: CMake Error in generators/spectre/CMakeLists.txt

2017-10-25 Thread Eugene Shalygin
https://bugs.kde.org/show_bug.cgi?id=386176 --- Comment #2 from Eugene Shalygin --- > Would you be able to submit a patch on https://phabricator.kde.org/? No, this is a trivial change. -- You are receiving this mail because: You are the assignee for the

[okular] [Bug 386176] okular: CMake Error in generators/spectre/CMakeLists.txt

2017-10-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=386176 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com ---

[okular] [Bug 385852] Okular ignored non-ascii characters in inline notes

2017-10-25 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=385852 Christoph Feck changed: What|Removed |Added Resolution|--- |DUPLICATE

[okular] [Bug 305534] Anotation don't show all non-ASCII letters

2017-10-25 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=305534 Christoph Feck changed: What|Removed |Added CC||stas-fo...@yandex.ru ---

[okular] [Bug 385423] Okular print dialog doesn't offer "landscape" nor "portrait" options for paper rotation

2017-10-25 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=385423 --- Comment #5 from Christoph Feck --- If you can provide the information requested in comment #4, please add it. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 386176] New: okular: CMake Error in generators/spectre/CMakeLists.txt

2017-10-25 Thread Eugene Shalygin
https://bugs.kde.org/show_bug.cgi?id=386176 Bug ID: 386176 Summary: okular: CMake Error in generators/spectre/CMakeLists.txt Product: okular Version: unspecified Platform: Other OS: Linux

D8378: Start the text generation request via a queued connection

2017-10-25 Thread Laurent Montel
mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > generator_p.h:135 > > +public slots: > +void startGeneration( Okular::Page *page ); it seems that okular use Q_SLOTS REPOSITORY R223

D8379: PDF: Support the new poppler renderToImage with update callback

2017-10-25 Thread Laurent Montel
mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > generator.h:584 > + */ > +void signalPartialPixmapRequest( Okular::PixmapRequest * request, > const QImage ); > + Coding style: void

[okular] [Bug 386111] Selecting text moves it one pixel towards the bottom

2017-10-25 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=386111 --- Comment #2 from Oliver Sander --- > I don't think i can reproduce it either (you mean Ctrl+4, right?) No, I mean Ctrl+3. I found out that it has to do with display scaling. On my system, ~/okular(master)> echo

[okular] [Bug 386110] ctrl+f highlighting only works for low zoom levels

2017-10-25 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=386110 --- Comment #2 from Oliver Sander --- No, it doesn't. The searching itself works, but there is no highlighting. I found out that it has to do with display scaling. On my system, ~/okular(master)> echo

D7662: Draw a dark rectangle around highlighted search results

2017-10-25 Thread Oliver Sander
sander added a comment. Thanks for testing. However, I don't really know what do to now. Given that I am not very attached to this patch I might simply abandon it. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7662 To: sander, #okular Cc: cfeck, aacid, ngraham