[okular] [Bug 386408] Text color printed incorrectly

https://bugs.kde.org/show_bug.cgi?id=386408 --- Comment #9 from SP --- (In reply to Christoph Feck from comment #8) > Please also test 'qpdfview', which is a pure Qt program. If this reproduces > the issue, the bug would be in the way Qt interacts with the printer drivers. Thank you for your res

D8832: Fix highlight/annotation clipping with Qt scaling

davidedmundson created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. REVISION SUMMARY pixelValue/pixelValue will give us a normalised value. Normalised values shouldn't be modified by a device pixel ratio. We want scaledR

[okular] [Bug 386408] Text color printed incorrectly

https://bugs.kde.org/show_bug.cgi?id=386408 --- Comment #8 from Christoph Feck --- Please also test 'qpdfview', which is a pure Qt program. If this reproduces the issue, the bug would be in the way Qt interacts with the printer drivers. -- You are receiving this mail because: You are the assign

D8642: Rework saving of annotations and form data

aacid marked an inline comment as done. aacid added a comment. > - 27. It is still very confusing when using Save, because for the user Continue and Cancel are exactly the same. Can we special-case with a flag and hide the last sentence and the button here? As Save is the more common operati

D8642: Rework saving of annotations and form data

aacid marked 2 inline comments as done. aacid added inline comments. INLINE COMMENTS > aacid wrote in documenttest.cpp:105 > Should be doable, i'll have a look. Done in the branch. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8642 To: aacid, mlaurent, rkflx Cc: mwol

D8642: Rework saving of annotations and form data

aacid added a comment. In https://phabricator.kde.org/D8642#167919, @aacid wrote: > In https://phabricator.kde.org/D8642#167903, @rkflx wrote: > > > > I can't seem to reproduce this. Which file and which annotation are you using? > > > > IIRC, I did Open `autotests/data/file1.pdf`

D8642: Rework saving of annotations and form data

aacid marked 5 inline comments as done. aacid added inline comments. INLINE COMMENTS > mwolff wrote in documenttest.cpp:112 > phabricator UI issue: the comment is for the line above, i.e. there are now > no more annotations. Before, there was one, which is why I wonder Ok, this is because we "f

D8642: Rework saving of annotations and form data

mwolff added inline comments. INLINE COMMENTS > aacid wrote in documenttest.cpp:112 > i don't understand why we would use QEXECTED_FAIL here, yes the annotations > have been migrated so we compare docdata migration to false, at most we could > use a qverify since one could argue qcompare with

D8642: Rework saving of annotations and form data

aacid marked 7 inline comments as done. aacid added inline comments. INLINE COMMENTS > mwolff wrote in documenttest.cpp:105 > can we test the actual migration, too? i.e. instead of pretending, actually > do it? Should be doable, i'll have a look. > mwolff wrote in documenttest.cpp:112 > should

D8690: Fix use of OpenUrlArguments

progwolff added inline comments. INLINE COMMENTS > progwolff wrote in part.cpp:1400 > Sorry for the delay... > > From my understanding of that commit, my changes won't break it. > argMime is only set, if an external application sets the mimeType via > OpenUrlArguments. So, the order in 1355 is

D8642: Rework saving of annotations and form data

aacid added a comment. In https://phabricator.kde.org/D8642#167903, @rkflx wrote: > > I can't seem to reproduce this. Which file and which annotation are you using? > > IIRC, I did Open `autotests/data/file1.pdf`, used pen tool, [Ctrl] + [S] + [Z] + [S]. Ok, i can reproduce i

D8690: Fix use of OpenUrlArguments

progwolff added inline comments. INLINE COMMENTS > aacid wrote in part.cpp:1400 > I don't think this is a good idea, do you have an actual case in which this > helps or is it just a guess? > > Also have you tried that this doesn't break the fixes that > https://phabricator.kde.org/R223:fba9067

D8642: Rework saving of annotations and form data

rkflx added a comment. https://phabricator.kde.org/source/okular/history/dont-use-docdata-for-annots-and-forms/ REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8642 To: aacid, mlaurent, rkflx Cc: mwolff, rkflx, lueck, mlaurent, michaelweghorn, ngraham, #okular, aacid

D8642: Rework saving of annotations and form data

mwolff added a comment. I started with a cursory glance at the changes, but the change set is huge, which makes it really hard to review, especially for people who have no extensive prior experience with okular. I think some of my comments could be "solved" by adding a comment here or there,

D8642: Rework saving of annotations and form data

rkflx added a comment. > I can't seem to reproduce this. Which file and which annotation are you using? IIRC, I did Open `autotests/data/file1.pdf`, used pen tool, [S] + [Z] + [S]. > Are you sure we want the filename only? what about if you have two files with the same filename and

D8642: Rework saving of annotations and form data

aacid marked 8 inline comments as done. aacid added a comment. In https://phabricator.kde.org/D8642#167826, @rkflx wrote: > Latest version is much improved, but still not there yet (see below). I'm giving this my approval nevertheless, because I'm confident that you'll be able to do the

D8642: Rework saving of annotations and form data

aacid added a comment. In https://phabricator.kde.org/D8642#167837, @rkflx wrote: > One more thing: Please also grep the docbook for `&okular; archive`, still some `document` missing. Fixed too REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8642 To: aac