KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/22/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 22:41:01 + Build duration: 14 min and counting JUnit

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/28/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 22:27:45 + Build duration: 17 min and counting JUnit Tests

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/21/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 22:27:19 + Build duration: 12 min and counting JUnit

D9328: Add support for cancellable image rendering and text extraction

rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. Yay, `make test` looks much better now. (I still get some failures, but those are also present without the patch – no time to bisect right now though, sorry. Let's see what the CI says.)

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/27/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 18:41:51 + Build duration: 14 min and counting JUnit Tests

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/20/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 18:11:18 + Build duration: 38 min and counting JUnit

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 26 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/26/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 18:07:03 + Build duration: 34 min and counting JUnit Tests

KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 49 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/49/ Project: Applications okular stable-kf5-qt5 SUSEQt5.9 Date of build: Wed, 31 Jan 2018 18:11:18 + Build duration: 6 min 3 sec and counting JUnit

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla added a comment. Thank you so much. I'm checking it out. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla, #okular, ngraham Cc: ngraham, #okular, michaelweghorn, aacid

D10209: Use correct arrow cursor for Annotations' close buttons

ngraham added a comment. Congratulations on your first patch! May it be the first of many more. If you're looking for inspiration, might I suggest checking out https://phabricator.kde.org/T6831? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To:

[okular] [Bug 384381] Cursor over X to close note should be an arrow

https://bugs.kde.org/show_bug.cgi?id=384381 Nate Graham changed: What|Removed |Added Latest Commit|https://commits.kde.org/oku

[okular] [Bug 384381] Cursor over X to close note should be an arrow

https://bugs.kde.org/show_bug.cgi?id=384381 Nate Graham changed: What|Removed |Added Status|CONFIRMED |RESOLVED

D10209: Use correct arrow cursor for Annotations' close buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R223:de56b9c9c165: Use correct arrow cursor for Annotations close buttons (authored by dileepsankhla, committed by ngraham). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla added a comment. Sure :) REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla, #okular, ngraham Cc: ngraham, #okular, michaelweghorn, aacid

D10209: Use correct arrow cursor for Annotations' close buttons

ngraham added a comment. Thanks! One more thing. The commit message has the following for your name: Author: RobStat Date: Wed Jan 31 10:54:37 2018 -0700 Would you mind using "Dileep Sankhla" instead of RobStat? for future patches? I'll correct it

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla added a comment. In https://phabricator.kde.org/D10209#198608, @ngraham wrote: > Lovely. Tested it out and it works as expected. Fix the BUG: string and I'll land this. Thank you so much. Fixed it. REPOSITORY R223 Okular BRANCH master REVISION DETAIL

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla edited the summary of this revision. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla, #okular, ngraham Cc: ngraham, #okular, michaelweghorn, aacid

D10209: Use correct arrow cursor for Annotations' close buttons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely. Tested it out and it works as expected. Fix the BUG: string and I'll land this. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D10209

D10209: Use correct arrow cursor for Annotations' close buttons

ngraham added a comment. Actually, the BUG: line can't be a link, I'm afraid. It has to be just: "BUG: " See https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To:

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla, #okular Cc: ngraham, #okular, michaelweghorn, aacid

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla added a comment. BUG: 384381 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla, #okular Cc: ngraham, #okular, michaelweghorn, aacid

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla added a comment. In https://phabricator.kde.org/D10209#198568, @ngraham wrote: > Thanks for the patch! Can you indicate your testing, and perhaps provide a screenshot that shows this working? > > Also, the title of the revision is really better suited to being in the

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla retitled this revision from "Added setCursor() call in the CloseButton constructor" to "Use correct arrow cursor for Annotations' close buttons". dileepsankhla edited the summary of this revision. dileepsankhla edited the test plan for this revision. REPOSITORY R223 Okular

D10209: Added setCursor() call in the CloseButton constructor

ngraham added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla, #okular Cc: ngraham, #okular, michaelweghorn, aacid

D10209: Added setCursor() call in the CloseButton constructor

ngraham added a comment. Thanks for the patch! Can you indicate your testing, and perhaps provide a screenshot that shows this working? Also, the title of the revision is really better suited to being in the summary. For the title, try to briefly explain the overall purpose. Maybe

D10209: Added setCursor() call in the CloseButton constructor

ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla Cc: #okular, michaelweghorn, ngraham, aacid

D10209: Added setCursor() call in the CloseButton constructor

dileepsankhla created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. dileepsankhla requested review of this revision. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D10209 AFFECTED FILES

KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 48 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/48/ Project: Applications okular stable-kf5-qt5 SUSEQt5.9 Date of build: Wed, 31 Jan 2018 11:32:08 + Build duration: 10 min and counting JUnit Tests

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 25 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/25/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 11:14:57 + Build duration: 24 min and counting JUnit Tests

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/19/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 11:14:07 + Build duration: 21 min and counting JUnit

D9328: Add support for cancellable image rendering and text extraction

aacid added a comment. In https://phabricator.kde.org/D9328#198101, @rkflx wrote: > In https://phabricator.kde.org/D9328#197788, @aacid wrote: > > > In https://phabricator.kde.org/D9328#196555, @rkflx wrote: > > > > > >> 5. `ASSERT: "page()" in file okular/core/generator_p.cpp,

D9328: Add support for cancellable image rendering and text extraction

aacid updated this revision to Diff 26246. aacid edited the summary of this revision. aacid removed subscribers: rkflx, ervin, michaelweghorn, ngraham. aacid added a comment. Fix crash found by the tests. Good we have them! REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

KDE CI: Applications okular stable-kf5-qt5 WindowsMSVCQt5.9 - Build # 56 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20WindowsMSVCQt5.9/56/ Project: Applications okular stable-kf5-qt5 WindowsMSVCQt5.9 Date of build: Wed, 31 Jan 2018 10:18:42 + Build duration: 30 min and counting

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/24/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 10:19:22 + Build duration: 16 min and counting JUnit Tests

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 18 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/18/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 10:18:42 + Build duration: 16 min and counting JUnit

KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 46 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/46/ Project: Applications okular stable-kf5-qt5 SUSEQt5.9 Date of build: Wed, 31 Jan 2018 10:18:42 + Build duration: 8 min 2 sec and counting JUnit