date:20180204

[okular] [Bug 383651] Custom/image stamp annotations are not saved into the PDF file in a way that can be printed or that other readers can see

2018-02-04 Thread Tobias Deiminger

https://bugs.kde.org/show_bug.cgi?id=383651 Tobias Deiminger changed: What|Removed |Added CC||haxti...@posteo.de ---

D10249: Option to exit after printing

2018-02-04 Thread Dileep Sankhla

dileepsankhla updated this revision to Diff 26550. dileepsankhla added a comment. Updating https://phabricator.kde.org/D10249: Option to exit after printing local variable to slotPrint function REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D10249: Option to exit after printing

2018-02-04 Thread Albert Astals Cid

aacid added a comment. That's even worse. I'll give you the answer myself. Why do you need to have that variable be global at all? It is used *exactly* in one function. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10249 To: dileepsankhla, aacid,

D10249: Option to exit after printing

2018-02-04 Thread Dileep Sankhla

dileepsankhla updated this revision to Diff 26547. dileepsankhla added a comment. Updating https://phabricator.kde.org/D10249: Option to exit after printing I was trying to get rid of extern keyword while declaring "isError" inside the namespace of the header file. Hence I declared it as

D10313: Option to exit after printing

2018-02-04 Thread Dileep Sankhla

dileepsankhla created this revision. dileepsankhla added a reviewer: aacid. dileepsankhla added a project: Okular. dileepsankhla requested review of this revision. REVISION SUMMARY When running okular with the parameter --print to directly open the print mode, it doesn't exit after

D10249: Option to exit after printing

2018-02-04 Thread Albert Astals Cid

aacid added a comment. Why is "isError" a class member variable? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10249 To: dileepsankhla, aacid, #okular, ngraham Cc: ngraham, aacid, #okular, michaelweghorn

[okular] [Bug 207748] LTR languages searches text backwards

2018-02-04 Thread Nate Graham

https://bugs.kde.org/show_bug.cgi?id=207748 --- Comment #18 from Nate Graham --- Fahad submitted a patch for this, which I've migrated to Phabricator: https://phabricator.kde.org/D10298 -- You are receiving this mail because: You are the assignee for the bug.

D10298: Fix searching in RTL PDFs

2018-02-04 Thread Nathaniel Graham

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10298 To: ngraham, #okular Cc: ltoscano, michaelweghorn, ngraham, aacid

D10298: Fix searching in RTL PDFs

2018-02-04 Thread Luigi Toscano

ltoscano resigned from this revision. ltoscano added a comment. Please change "migrated from..." with the proper content from the old reviewboard patch, and resubmit it using the original author. The note about "this was in reviewboard" should not be in the final commit message, but the

D10298: Fix searching in RTL PDFs

2018-02-04 Thread Nathaniel Graham

ngraham updated this revision to Diff 26510. ngraham added a comment. Update author REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10298?vs=26509=26510 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10298 AFFECTED FILES

Re: Review Request 125442: [okular] fix Arabic & Hebrew search

2018-02-04 Thread Nathaniel Graham

> On July 21, 2016, 9:19 a.m., Olivier Churlaud wrote: > > ui/searchlineedit.cpp > > Lines 219 (patched) > > > > > > Before submitting patches, check with a `git diff` that you don't add > > whitespaces...

D10298: Fix searching in RTL PDFs

2018-02-04 Thread Nathaniel Graham

ngraham created this revision. ngraham added a reviewer: Okular. Restricted Application added a project: Okular. ngraham requested review of this revision. REVISION SUMMARY BUG: 207748 Migrated this patch from https://git.reviewboard.kde.org/r/125442/ since it had whitespace errors and