D10566: Add support for code tags in fictionbook

2018-02-15 Thread Christoph Feck
cfeck added a comment. Thanks for the patch! Please adjust the spaces around parents to follow the surrounding code. Bonus points if you also add the missing support for 'sup' and 'sub', as investigated in the bug ticket. REPOSITORY R223 Okular REVISION DETAIL https://phabricat

D9857: Smooth Scrolling

2018-02-15 Thread Ronald Macmaster
rmacmaster abandoned this revision. rmacmaster added a comment. Sorry, I sort of abandoned this patch because I got caught up in other things. * Smooth scrolling: Scrolling using the scroll wheel, arrow keys, PageUp/PageDown keys, or the spacebar will results in an animated transition

[okular] [Bug 169847] split view feature

2018-02-15 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=169847 --- Comment #28 from Nate Graham --- Feel free to read the documentation I linked to, which will help you find what you're looking for! -- You are receiving this mail because: You are the assignee for the bug.

D9857: Smooth Scrolling

2018-02-15 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Finally got a chance to give this a whirl. First, let's make sure we're talking about the same thing, because scroll terminology can otherwise be a bit imprecise: - **S

[okular] [Bug 169847] split view feature

2018-02-15 Thread Musikolo
https://bugs.kde.org/show_bug.cgi?id=169847 --- Comment #27 from Musikolo --- Sounds fair! Can you please pass me a link to the source code? This said, I had no intention of pushing, because as you said, open source software is all good will... ;-) -- You are receiving this mail because: You a

[okular] [Bug 169847] split view feature

2018-02-15 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=169847 --- Comment #26 from Nate Graham --- There's always a chance! But this is a mostly volunteer project, and it needs a developer to do the work. You, maybe? ;) https://community.kde.org/Get_Involved/development -- You are receiving this mail because: Y

[okular] [Bug 169847] split view feature

2018-02-15 Thread Musikolo
https://bugs.kde.org/show_bug.cgi?id=169847 --- Comment #25 from Musikolo --- Is there any chance this feature gets eventually implemented? I'm asking because it was originally requested over 9 years ago, and I see nothing that suggests it's coming anytime in the future. Thank you and long liv

[okular] [Bug 389909] Allow dragging navigation panel to the right

2018-02-15 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=389909 Christoph Feck changed: What|Removed |Added See Also||https://bugs.kde.org/show_b

[okular] [Bug 141289] Allow navigation panel on the bottom instead of side

2018-02-15 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=141289 Christoph Feck changed: What|Removed |Added See Also||https://bugs.kde.org/show_b

[okular] [Bug 389951] Add option to open new window/tab with the same document

2018-02-15 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=389951 Christoph Feck changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED

[okular] [Bug 169847] split view feature

2018-02-15 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=169847 Christoph Feck changed: What|Removed |Added CC||david.cortes.rivera@gmail.c

D10566: Add support for code tags in fictionbook

2018-02-15 Thread Nathaniel Graham
ngraham added a comment. Thanks for your patch! For the summary section, please see https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch for information about how to format the BUG: tag to connect this patch with the Bugzilla ticket. REPOSITORY R223 Okular REVISION

[okular] [Bug 387426] FB2 module do not display content inside tags

2018-02-15 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=387426 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail beca

[okular] [Bug 387426] FB2 module do not display content inside tags

2018-02-15 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=387426 --- Comment #2 from abogi...@gmail.com --- patch pending approval: https://phabricator.kde.org/D10566 -- You are receiving this mail because: You are the assignee for the bug.

D10566: Add support for code tags in fictionbook

2018-02-15 Thread Abdel-Rahman A .
abogical created this revision. abogical added a reviewer: Okular. Restricted Application added a project: Okular. abogical requested review of this revision. REVISION SUMMARY Fixes https://bugs.kde.org/show_bug.cgi?id=387426 TEST PLAN Open this

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-15 Thread Michael Weghorn
https://bugs.kde.org/show_bug.cgi?id=389953 Michael Weghorn changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-15 Thread Attila
https://bugs.kde.org/show_bug.cgi?id=389953 --- Comment #35 from Attila --- I have got great news. The following did it: $ sudo systemctl stop cups-browsed.service $ sudo rm /var/cache/cups/cups-browsed-options-tofile-hp $ sudo systemctl start cups-browsed.service The file /var/cache/cups/cups

D10547: [PATCH] Recalculate forms after command form changes

2018-02-15 Thread Andre Heinecke
aheinecke added a comment. In D10547#207085 , @ltoscano wrote: > (I can't comment on the content of the stream of the patches, but I think you don't need the [PATCH] in the title in any of them - they are clearly patches if they are defined here

D10547: [PATCH] Recalculate forms after command form changes

2018-02-15 Thread Luigi Toscano
ltoscano added a comment. (I can't comment on the content of the stream of the patches, but I think you don't need the [PATCH] in the title in any of them - they are clearly patches if they are defined here. And probably not even the (1/3) in the other patches) REPOSITORY R223 Okular REVI

D10547: [PATCH] Recalculate forms after command form changes

2018-02-15 Thread Andre Heinecke
aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY notifyFormChanged is called by documentcommands when Form fields are changed. E.g. by Undo / Redo. We need to recalculate afte

D10547: [PATCH] Recalculate forms after command form changes

2018-02-15 Thread Andre Heinecke
aheinecke added a task: T7805: Okular: Add support for JavaScript AFSimple_Calculate and textfield content calculation. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10547 To: aheinecke, #okular Cc: michaelweghorn, ngraham, simgunz, aacid

D10073: [PATCH 1/4] Add JavaScript Event Object handling

2018-02-15 Thread Andre Heinecke
aheinecke marked 3 inline comments as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10073 To: aheinecke, #okular Cc: aacid, michaelweghorn, ngraham, simgunz

D10048: [PATCH 2/4] Add refresh widgets if underlying field changes

2018-02-15 Thread Andre Heinecke
aheinecke updated this revision to Diff 27266. aheinecke added a comment. Update to build event with non const page ref after change in D10073 REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10048?vs=27257&id=27266 REVIS

D10073: [PATCH 1/4] Add JavaScript Event Object handling

2018-02-15 Thread Andre Heinecke
aheinecke updated this revision to Diff 27264. aheinecke added a comment. Use non const page refs for source and target page. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10073?vs=26760&id=27264 REVISION DETAIL https://phabricator.kde.org/D10073 AFFECT

D10073: [PATCH 1/4] Add JavaScript Event Object handling

2018-02-15 Thread Andre Heinecke
aheinecke added inline comments. INLINE COMMENTS > aacid wrote in kjs_field.cpp:222 > Or just don't store the page as const pointer? I passed it as const as I only saw API in document to get a const page reference and recalculateForms also used a const reference. But yes I see now that document

D10048: [PATCH 2/4] Add refresh widgets if underlying field changes

2018-02-15 Thread Andre Heinecke
aheinecke marked 6 inline comments as done. aheinecke added a comment. So I only changed the version to 1.4 here. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10048 To: aheinecke, #okular Cc: aacid, michaelweghorn, ngraham, simgunz

D10048: [PATCH 2/4] Add refresh widgets if underlying field changes

2018-02-15 Thread Andre Heinecke
aheinecke updated this revision to Diff 27257. aheinecke added a comment. Changed comment about version which added the new signal. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10048?vs=26761&id=27257 REVISION DETAIL https://phabricator.kde.org/D10048

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 36 - Still Unstable!

2018-02-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/36/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 15 Feb 2018 09:15:18 + Build duration: 16 min and counting JUnit Tests Nam