[okular] [Bug 390708] Allow to move backward in presentations using touch

2018-02-18 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=390708 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #1 from

D10455: Add RTL support for search, copy & paste in pdf

2018-02-18 Thread Fahad Al-Saidi
fahadalsaidi added a comment. @aacid Thanks for the feedback. > I'm still unconvinced the text reversion is happening at the proper level. I really a new to okular's code, so please guide me to the right direction. > And you have a memory leak in your function as reported by

D10455: Add RTL support for search, copy & paste in pdf

2018-02-18 Thread Fahad Al-Saidi
fahadalsaidi updated this revision to Diff 27517. fahadalsaidi added a comment. - use QTRY_COMPARE REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10455?vs=27043&id=27517 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10455 AFFECTED FILES

[okular] [Bug 390709] New: Create a reader mode/horizontal continous mode

2018-02-18 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390709 Bug ID: 390709 Summary: Create a reader mode/horizontal continous mode Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severit

[okular] [Bug 390708] New: Allow to move backward in presentations using touch

2018-02-18 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390708 Bug ID: 390708 Summary: Allow to move backward in presentations using touch Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Se

[okular] [Bug 390707] New: Two-finger touchscreen zoom gesture should respect finger position

2018-02-18 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390707 Bug ID: 390707 Summary: Two-finger touchscreen zoom gesture should respect finger position Product: okular Version: unspecified Platform: Other OS: Linux

[okular] [Bug 390706] New: Two-finger touchscreen zoom gesture needs final refresh

2018-02-18 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390706 Bug ID: 390706 Summary: Two-finger touchscreen zoom gesture needs final refresh Product: okular Version: unspecified Platform: Other OS: Linux Status:

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 39 - Still Unstable!

2018-02-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/39/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 18 Feb 2018 22:31:54 + Build duration: 13 min and counting JUnit Tests Nam

[okular] [Bug 387426] FB2 module do not display content inside tags

2018-02-18 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=387426 Albert Astals Cid changed: What|Removed |Added Resolution|--- |FIXED CC|

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 38 - Still Unstable!

2018-02-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/38/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 18 Feb 2018 22:17:23 + Build duration: 14 min and counting JUnit Tests Nam

D10566: Fictionbook: Add support for code, superscript, & subscript tags

2018-02-18 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R223:ce7fa7b9d879: Fictionbook: Add support for code, superscript, & subscript tags (authored by abogical, committed by aacid). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.

D10566: Fictionbook: Add support for code, superscript, & subscript tags

2018-02-18 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10566 To: abogical, #okular, aacid Cc: aacid, cfeck, ngraham, michaelweghorn

D10504: Bug 288042 - Option to reset forms

2018-02-18 Thread Albert Astals Cid
aacid added a comment. Do you plan to work on the autotest? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10504 To: ahmadosama, aacid Cc: aacid, ngraham, #okular, michaelweghorn

D10455: Add RTL support for search, copy & paste in pdf

2018-02-18 Thread Albert Astals Cid
aacid added a comment. In D10455#208549 , @fahadalsaidi wrote: > @aacid any feedback? I'm still unconvinced the text reversion is happening at the proper level. Anyway meanwhile please change the test so that uses qtry_compare inste

D10566: Fictionbook: Add support for code, superscript, & subscript tags

2018-02-18 Thread Abdel-Rahman A .
abogical added a comment. Full name is 'Abdel-Rahman Abdel-Rahman'. but I just like to hide my last name. REVISION DETAIL https://phabricator.kde.org/D10566 To: abogical, #okular, aacid Cc: aacid, cfeck, ngraham, michaelweghorn

D10566: Fictionbook: Add support for code, superscript, & subscript tags

2018-02-18 Thread Albert Astals Cid
aacid added a comment. is your surname really "A." ? REVISION DETAIL https://phabricator.kde.org/D10566 To: abogical, #okular, aacid Cc: aacid, cfeck, ngraham, michaelweghorn

D10566: Fictionbook: Add support for code, superscript, & subscript tags

2018-02-18 Thread Abdel-Rahman A .
abogical added a comment. Name is Abdel-Rahman A. I'll modify my profile. REVISION DETAIL https://phabricator.kde.org/D10566 To: abogical, #okular, aacid Cc: aacid, cfeck, ngraham, michaelweghorn

D10566: Fictionbook: Add support for code, superscript, & subscript tags

2018-02-18 Thread Albert Astals Cid
aacid added a comment. We're going to need your name before being able to commit this. REVISION DETAIL https://phabricator.kde.org/D10566 To: abogical, #okular, aacid Cc: aacid, cfeck, ngraham, michaelweghorn

D10566: Fictionbook: Add support for code, superscript, & subscript tags

2018-02-18 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Looks reasonable. REVISION DETAIL https://phabricator.kde.org/D10566 To: abogical, #okular, aacid Cc: aacid, cfeck, ngraham, michaelweghorn

D10566: Fictionbook: Add support for code, superscript, & subscript tags

2018-02-18 Thread Albert Astals Cid
aacid added a comment. In D10566#207668 , @abogical wrote: > Just a question, what tools does the KDE developers use for linting the formatting of their code? there's no general linting solution, in particular we don't use anything in ok

[okular] [Bug 383651] Custom/image stamp annotations are not saved into the PDF file in a way that can be printed or that other readers can see

2018-02-18 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=383651 --- Comment #13 from Oliver Sander --- Albert, you are not the only busy person on this planet. Last time I tried I couldn't log in to the wiki page. Now it works all of a sudden. What do I know... -- You are receiving this mail because: You are th

[okular] [Bug 383651] Custom/image stamp annotations are not saved into the PDF file in a way that can be printed or that other readers can see

2018-02-18 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=383651 --- Comment #12 from Albert Astals Cid --- You should really add it to the wiki for yourself, *personally* i've like 100 unread emails, half of which are people waiting for me to review their code, so I really don't have time to add it myself. -- You

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 37 - Still Unstable!

2018-02-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/37/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 18 Feb 2018 18:23:12 + Build duration: 14 min and counting JUnit Tests Nam

D10415: Fix realDpi function for Mac

2018-02-18 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10415 To: sbragin, #okular, rjvbb Cc: rjvbb, cullmann, aacid, kde-mac, ltoscano, #okular, michaelweghorn, ngraham, simgunz

D10415: Fix realDpi function for Mac

2018-02-18 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R223:54c741844b76: Fix realDpi function for Mac (authored by sbragin, committed by aacid). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10415?vs=26841&id=27486 REVISIO

D10415: Fix realDpi function for Mac

2018-02-18 Thread Sergio Bragin
sbragin added a comment. In D10415#209003 , @aacid wrote: > So should i commit this or is there a better patch coming? (yes, i didn't really read all those posts) Please, go ahead. REPOSITORY R223 Okular BRANCH master REVISION DETA

D10415: Fix realDpi function for Mac

2018-02-18 Thread Albert Astals Cid
aacid added a comment. So should i commit this or is there a better patch coming? (yes, i didn't really read all those posts) REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D10415 To: sbragin, #okular, rjvbb Cc: rjvbb, cullmann, aacid, kde-mac, ltosc