D10865: [1/5] Access readOnly state of FormWidgets dynamically

aacid added inline comments. INLINE COMMENTS > aheinecke wrote in formwidgets.cpp:310 > As I understand it there is a case where Forms are bisible, but disabled. > This is if in "PageView::notifySetup" the check for: > > const bool allowfillforms = d->document->isAllowed( Okular::AllowFillForm

D10932: [Okular] Option to reset forms

aacid requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10932 To: ahmadosama, #okular, aacid Cc: ngraham, aacid, #okular, michaelweghorn

D10792: Raise annotation window when clicking on annotation

aacid added a comment. ping? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10792 To: simgunz, #okular, aacid Cc: ngraham, #okular, michaelweghorn, aacid

D11051: Remembering side navigation panel state

aacid requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11051 To: dileepsankhla, #okular, aacid Cc: aacid, sander, #okular, michaelweghorn, ngraham

D10797: Add asterisk when an annotation is associated to non-empty popup

aacid requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10797 To: simgunz, #okular, aacid Cc: aacid, ngraham, michaelweghorn

D10504: Bug 288042 - Option to reset forms

aacid added a comment. So will you cancel this one in favor of the other one? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10504 To: ahmadosama, aacid Cc: aacid, ngraham, #okular, michaelweghorn

[okular] [Bug 391352] Trim margins breaks mouse wheel zoom out

https://bugs.kde.org/show_bug.cgi?id=391352 Albert Astals Cid changed: What|Removed |Added Status|NEEDSINFO |CONFIRMED Summary|Okular does no

D11051: Remembering side navigation panel state

aacid added a comment. In D11051#222803 , @dileepsankhla wrote: > In D11051#05 , @aacid wrote: > > > Also i'm not convinced it's a good idea to save the settings in sidebar.cpp but read them in

D10932: [Okular] Option to reset forms

aacid added a comment. Have you thought how this should interact with the undo/redo history stack? INLINE COMMENTS > resetformstest.cpp:182 > +{ > +verifyTextForm( m_textLineForm ); > +} what does this test do? > part.cpp:3359 > m_formsMessage->addAction( m_pageView->toggleFormsAct

[okular] [Bug 288042] Option to reset forms (PDF)

https://bugs.kde.org/show_bug.cgi?id=288042 --- Comment #9 from Ahmad Osama --- I created an auto-test for this option that is working fine on the created test cases, the new test along with the implementation for this option are in this patch: https://phabricator.kde.org/D10932 -- You are rec

D10932: [Okular] Option to reset forms

ahmadosama updated this revision to Diff 29396. ahmadosama edited the test plan for this revision. ahmadosama added a comment. I added an auto-test for this option, the test is working fine on all the created test cases. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricato

D10932: [Okular] Option to reset forms

ahmadosama retitled this revision from "Bug 288042 - Option to reset forms (Implemented using FormFields)" to "[Okular] Option to reset forms". ahmadosama edited the summary of this revision. ahmadosama edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://ph

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/49/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 13 Mar 2018 08:29:27 + Build duration: 1 hr 12 min and counting JUnit Tests