D8980: Fix rubber band selection drawing contents misaligned with scaling

2018-03-21 Thread David Edmundson
davidedmundson marked an inline comment as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8980 To: davidedmundson, aacid Cc: sander, rkflx, anthonyfieroni, #okular, michaelweghorn, ngraham, aacid

D8980: Fix rubber band selection drawing contents misaligned with scaling

2018-03-21 Thread David Edmundson
davidedmundson updated this revision to Diff 30123. davidedmundson added a comment. Update to fix Anthony's well spotted comment REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8980?vs=22864&id=30123 BRANCH master REVISION DETAIL https://phabricator.kde

GSoC Proposal: Implementing the FreeText annotation (Draft)

2018-03-21 Thread Dileep Sankhla
Hello, I am interested to participate with Okular in GSoC this year. I have written a draft proposal for the project. Here is the link to my proposal: https://docs.google.com/document/d/1STBOz7Qcw1Wj6qB7XBg9er-wbsVx3g7Sw945WcHJfWU/edit?usp=sharing Any feedback or suggestion will be highly appre

Re: GSoC Proposal: Implementing the FreeText annotation (Draft)

2018-03-21 Thread Tobias Deiminger
Hi Dileep, your proposal looks nice. There's just one important thing missing: Okular already let's you create FreeText annotations. The confusing thing is that they're called "inline notes" in Okulars manual, and they're represented as class TextAnnotation (with m_textType == TextAnnotation::I