[okular] [Bug 394822] New: Incorrent rendering of Czech characters in embedded Forms

2018-05-29 Thread Dan
https://bugs.kde.org/show_bug.cgi?id=394822 Bug ID: 394822 Summary: Incorrent rendering of Czech characters in embedded Forms Product: okular Version: 1.3.1 Platform: Archlinux Packages OS: Linux

[okular] [Bug 394822] Incorrent rendering of Czech characters in embedded Forms

2018-05-29 Thread Dan
https://bugs.kde.org/show_bug.cgi?id=394822 --- Comment #1 from Dan --- Created attachment 112946 --> https://bugs.kde.org/attachment.cgi?id=112946&action=edit The screenshot of the ocular when editing the form When editing the form, the characters are displayed correctly. -- You are receivi

[okular] [Bug 394822] Incorrent rendering of Czech characters in embedded Forms

2018-05-29 Thread Dan
https://bugs.kde.org/show_bug.cgi?id=394822 --- Comment #2 from Dan --- Created attachment 112947 --> https://bugs.kde.org/attachment.cgi?id=112947&action=edit The screenshot of the ocular when displaying the form But when displaying the form, many of the acented characters are missing. -- Y

D13170: Add test for additional form actions

2018-05-29 Thread Andre Heinecke
aheinecke added a comment. In D13170#269657 , @aacid wrote: > QTest::qWait( 100 ); is bad as you probably already guessed since it's "machine dependant". Yeah, looked fishy ;-) Although stuff like that is used in part test on other place

[okular] [Bug 394822] Incorrent rendering of Czech characters in embedded Forms

2018-05-29 Thread Dan
https://bugs.kde.org/show_bug.cgi?id=394822 --- Comment #3 from Dan --- I forgot to add that when the form is filled (edited), the characters are displayed correctly. But when the filled form is displayed, many of the accented characters are missing. (In reply to Dan from comment #0) > Created a

[okular] [Bug 394822] Incorrent rendering of Czech characters in embedded Forms

2018-05-29 Thread Dan
https://bugs.kde.org/show_bug.cgi?id=394822 Dan changed: What|Removed |Added CC||roze...@volny.cz -- You are receiving this mail because:

D13170: Add test for additional form actions

2018-05-29 Thread Andre Heinecke
aheinecke updated this revision to Diff 35084. aheinecke added a comment. Use QTRY instead of QTest::wait. This is acutally much faster. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13170?vs=35022&id=35084 REVISION DETAIL https://phabricator.kde.org/D13

D13170: Add test for additional form actions

2018-05-29 Thread Andre Heinecke
aheinecke added a comment. In D13170#270082 , @aheinecke wrote: > In D13170#269657 , @aacid wrote: > > > QTest::qWait( 100 ); is bad as you probably already guessed since it's "machine dependant".

D13172: Add AFNumber_Format and l10n AFSimple_Calculate

2018-05-29 Thread Andre Heinecke
aheinecke planned changes to this revision. aheinecke added inline comments. INLINE COMMENTS > aacid wrote in builtin.js:91 > QLocale::toString ? *facepalm* I thought that didn't do separators. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13172 To: aheinecke, aa

D13172: Add AFNumber_Format and l10n AFSimple_Calculate

2018-05-29 Thread Andre Heinecke
aheinecke updated this revision to Diff 35086. aheinecke added a comment. Removed to currency and extended numberToString to handle this, too. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13172?vs=35028&id=35086 REVISION DETAIL https://phabricator.kde.o

D13172: Add AFNumber_Format and l10n AFSimple_Calculate

2018-05-29 Thread Andre Heinecke
aheinecke updated this revision to Diff 35087. aheinecke added a comment. Remove spurious comment REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13172?vs=35086&id=35087 REVISION DETAIL https://phabricator.kde.org/D13172 AFFECTED FILES core/script/built

[okular] [Bug 394824] New: Presentation crash with video

2018-05-29 Thread niive
https://bugs.kde.org/show_bug.cgi?id=394824 Bug ID: 394824 Summary: Presentation crash with video Product: okular Version: 1.4.0 Platform: Neon Packages OS: Linux Status: UNCONFIRMED Severity: normal

[okular] [Bug 394824] Presentation crash with video

2018-05-29 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=394824 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de Severity|

D13171: Add support for form text formatting

2018-05-29 Thread Andre Heinecke
aheinecke updated this revision to Diff 35089. aheinecke added a comment. - Simplyfy page lookup in processFormatAction - Clarify comment about the need to refresh calculated fields in processFormatAction. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org

[okular] [Bug 394834] New: Okular not release memory (ram) taken by closed documents

2018-05-29 Thread CnZhx
https://bugs.kde.org/show_bug.cgi?id=394834 Bug ID: 394834 Summary: Okular not release memory (ram) taken by closed documents Product: okular Version: 1.4.1 Platform: openSUSE RPMs OS: Linux Stat

D13203: Add Typewriter annotation tool in Okular

2018-05-29 Thread Dileep Sankhla
dileepsankhla created this revision. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. dileepsankhla requested review of this revision. REVISION SUMMARY This patch adds the typewriter annotation tool in Okular with a new typewriter icon and

D13203: Add Typewriter annotation tool in Okular

2018-05-29 Thread Dileep Sankhla
dileepsankhla added subscribers: aacid, tobiasdeiminger. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13203 To: dileepsankhla Cc: tobiasdeiminger, aacid, okular-devel, ngraham

D13203: Add Typewriter annotation tool in Okular

2018-05-29 Thread Dileep Sankhla
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:c344c5e31b6a: Added Typewriter annotation tool (authored by dileepsankhla). REPOSITORY R223 Okular CHANGES SINCE LA

D13203: Add Typewriter annotation tool in Okular

2018-05-29 Thread Nathaniel Graham
ngraham added a comment. Hmm, what can this do that the regular text annotation tool can't? Also, why land it immediately without waiting for review? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13203 To: dileepsankhla Cc: ngraham, tobiasdeiminger, aacid, okul

D13203: Add Typewriter annotation tool in Okular

2018-05-29 Thread Luigi Toscano
ltoscano reopened this revision. ltoscano added a comment. Pushed to the gsoc branch, but reopening. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13203 To: dileepsankhla Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel

D13203: Add Typewriter annotation tool in Okular

2018-05-29 Thread Dileep Sankhla
dileepsankhla added a comment. @ngraham This is the part of my GSoC project: https://summerofcode.withgoogle.com/projects/#6053164340477952 I have committed the same to my separate branch: https://cgit.kde.org/okular.git/log/?h=gsoc2018_typewriter but don't know how it got landed! It ne

D13203: Add Typewriter annotation tool in Okular

2018-05-29 Thread Nathaniel Graham
ngraham added a comment. Ah, I see, you committed it to a branch, not to master. Still, by committing anywhere, Phabricator figured that it had been landed. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13203 To: dileepsankhla Cc: ltoscano, ngraham, tobiasdeimi

D13203: Add Typewriter annotation tool in Okular

2018-05-29 Thread Tobias Deiminger
tobiasdeiminger added a comment. In D13203#270423 , @dileepsankhla wrote: > I have committed the same to my separate branch: https://cgit.kde.org/okular.git/log/?h=gsoc2018_typewriter but don't know how it got landed! It needs to be reviewed fi

D13203: Add Typewriter annotation tool in Okular

2018-05-29 Thread Tobias Deiminger
tobiasdeiminger added a comment. If I use the new tool to typewrite onto a plain text file, I get opaque white background instead of transparent background. Transparency does work for PDF documents (i.e. rendered by poppler). In the former case the typewriter annotation is drawn in ui/pagepa