D13471: Expose 'change colors' through dbus interface

2018-06-11 Thread Michael Eden
michaeleden updated this revision to Diff 36025. michaeleden added a comment. Rebase back to v17.12.2 REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13471?vs=36024&id=36025 BRANCH feature/dbus-changecolors REVISION DETAIL https://phabricator.kde.org/D1

D13471: Expose 'change colors' through dbus interface

2018-06-11 Thread Michael Eden
michaeleden updated this revision to Diff 36024. michaeleden added a comment. Rebased onto Applications/18.04 REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13471?vs=35969&id=36024 BRANCH feature/dbus-changecolors REVISION DETAIL https://phabricator.kd

D13366: Add SignatureEdit widget for FormFieldSignature

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D13484: Show signature validation summary as popup. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13366 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D11723: Add FormFieldSignature to Okular namespace

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11723 To: chinmoyr, aacid Cc: sander, ngraham, okular-devel, aacid

D13366: Add SignatureEdit widget for FormFieldSignature

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr edited dependencies, added: D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog; removed: D11723: Add FormFieldSignature to Okular namespace. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13366 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D11723: Add FormFieldSignature to Okular namespace

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a dependent revision: D13366: Add SignatureEdit widget for FormFieldSignature. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11723 To: chinmoyr, aacid Cc: sander, ngraham, okular-devel, aacid

D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D13366: Add SignatureEdit widget for FormFieldSignature. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13483 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D13484: Show signature validation summary as popup

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependency: D13366: Add SignatureEdit widget for FormFieldSignature. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13484 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependency: D11723: Add FormFieldSignature to Okular namespace. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13483 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

[okular] [Bug 384700] Setting a shortcut for "Toggle Change Colors" is not remembered

2018-06-11 Thread Kai
https://bugs.kde.org/show_bug.cgi?id=384700 --- Comment #5 from Kai --- I can confirm this bug for Okular 1.3.3 with: Qt: 5.9.5 KDE Frameworks: 5.44.0 -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 384700] Setting a shortcut for "Toggle Change Colors" is not remembered

2018-06-11 Thread Kai
https://bugs.kde.org/show_bug.cgi?id=384700 Kai changed: What|Removed |Added CC||hatesh...@web.de -- You are receiving this mail because:

D13484: Show signature validation summary as popup

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added a reviewer: aacid. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. chinmoyr requested review of this revision. REVISION SUMMARY This patch adds support for validating all signatures present in

D13366: Add SignatureEdit widget for FormFieldSignature

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 36014. chinmoyr added a comment. Rebased on master Made use of SignatureSummaryDialog and SignaturePropertiesDialog REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13366?vs=35637&id=36014 BRANCH master REVISION DET

D13483: Add SignatureSummaryDialog and SignaturePropertiesDialog

2018-06-11 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added a reviewer: aacid. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. chinmoyr requested review of this revision. REVISION SUMMARY SignatureSummaryDialog will display the signature validation sum

[okular] [Bug 395132] Okular doesn't display some non-ascii characters in main view only. Print preview and text select work fine.

2018-06-11 Thread Luigi Toscano
https://bugs.kde.org/show_bug.cgi?id=395132 --- Comment #5 from Luigi Toscano --- It's not an Okular bug. See these previous bugs: https://bugs.kde.org/show_bug.cgi?id=379057 https://bugs.kde.org/show_bug.cgi?id=357822 https://bugs.kde.org/show_bug.cgi?id=335058 https://bugs.kde.org/show_bug.cgi

[okular] [Bug 395132] Okular doesn't display some non-ascii characters in main view only. Print preview and text select work fine.

2018-06-11 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=395132 --- Comment #4 from triffid.hun...@gmail.com --- Wow that seems to have done it! Care to inform me why they were breaking things? I don't know much about fonts in general, or how linux specifically handles them. Those fonts apparently come from the tex

[okular] [Bug 395132] Okular doesn't display some non-ascii characters in main view only. Print preview and text select work fine.

2018-06-11 Thread Luigi Toscano
https://bugs.kde.org/show_bug.cgi?id=395132 --- Comment #3 from Luigi Toscano --- Please try to remove the tex-gyre fonts (or configure fontconfig to not use them as primary choice for Helvetica & co). -- You are receiving this mail because: You are the assignee for the bug.

D13203: Add Typewriter annotation tool in Okular

2018-06-11 Thread Tobias Deiminger
tobiasdeiminger added inline comments. INLINE COMMENTS > parttest.cpp:117 > void testAnnotWindow(); > +<<< HEAD > void testAdditionalActionTriggers(); Please resolve local merge conflict before submitting the diff. > parttest.cpp:1511 > > +<<< HEAD > // Helper for t

[okular] [Bug 395150] Okular print dialog always resets to duplex: none

2018-06-11 Thread Sergio
https://bugs.kde.org/show_bug.cgi?id=395150 --- Comment #6 from Sergio --- @ Nate, Albert, thanks for the clarification, I was almost sure that the issue was on Qt. And indeed, bionic is stuck at QT 5.9.5. Good to know that at least is a matter of waiting and that qt 5.11 has a better print dial