D14816: Add signature panel

chinmoyr created this revision. chinmoyr added a reviewer: aacid. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. chinmoyr requested review of this revision. REVISION SUMMARY Signature panel is a sidebar widget that lists all the signature

D13366: Add SignatureEdit widget for FormFieldSignature

chinmoyr added a dependent revision: D14816: Add signature panel. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13366 To: chinmoyr, aacid Cc: okular-devel, ngraham, aacid

D10298: Fix searching in RTL PDFs

userkde added a comment. @ngraham Thank you for your job on this bug . I want to know what is the new about this bug, the problem is not only with search even if you copy a RTL text the copying generates mirrored texts. maybe the problem is deeper than it seems. I think Okular deals all

D10298: Fix searching in RTL PDFs

userkde added a comment. @ngraham Thank you for your job on this bug . I want to know what is the new about this bug, the problem is not only with search even if you copy a RTL text the copying generates mirrored texts. maybe the problem is deeper than it seems. REPOSITORY R223 Okular

D14310: Fixes url whitespaces in epub documents

ngraham added a comment. In D14310#307943 , @aacid wrote: > Yes he can. > > @ngraham when you want to check if someone has commit rights you can check https://websvn.kde.org/trunk/kde-common/accounts?view=markup Thanks Albert! And I s

D14809: Make 'configure generators' dialog open with current generator selected

sander created this revision. sander added a reviewer: Okular. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. sander requested review of this revision. REVISION SUMMARY The 'current generators' dialog has a page for each generator. The ch

[okular] [Bug 397429] New: Spurious empty file 'empty.cpp' in generators/spectre/conf

https://bugs.kde.org/show_bug.cgi?id=397429 Bug ID: 397429 Summary: Spurious empty file 'empty.cpp' in generators/spectre/conf Product: okular Version: 1.3.0 Platform: Other OS: Linux Status: UNC

D14310: Fixes url whitespaces in epub documents

aacid added a comment. Yes he can. @ngraham when you want to check if someone has commit rights you can check https://websvn.kde.org/trunk/kde-common/accounts?view=markup REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D14310 To: gassaf, #okular,

D14310: Fixes url whitespaces in epub documents

ngraham added a comment. Can you commit this yourself, @gassaf? REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D14310 To: gassaf, #okular, aacid Cc: ngraham, aacid, okular-devel

[okular] [Bug 397383] Calculation with many trailing zeros - Rounding doesn't work

https://bugs.kde.org/show_bug.cgi?id=397383 Albert Astals Cid changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Ever confirmed|0

[okular] [Bug 389668] Saving a pdf switches from thumbnail view in sidebar to contents view

https://bugs.kde.org/show_bug.cgi?id=389668 --- Comment #12 from Michael D --- Great, thanks for the fix Albert. -- You are receiving this mail because: You are the assignee for the bug.

D14752: Fix links being "lost" on save

aacid added inline comments. INLINE COMMENTS > tobiasdeiminger wrote in generator_pdf.cpp:653 > Guess this is the same sanity check as in document.cpp, > Document::swapBackingFile, probably meaning "is it still the same document?". > Could there be situations where old page count != new page co

D14752: Fix links being "lost" on save

aacid updated this revision to Diff 39574. aacid added a comment. add small comment Fix leak of poppler page REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14752?vs=39477&id=39574 BRANCH arcpatch-D14752 REVISION DETAIL https://phabricator.kde.org/

D14740: Fix problem of saving pdf switches from thumbnail view in sidebar to contents view

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:5e622484c874: Fix problem of saving pdf switches from thumbnail view in sidebar to contents… (authored by ahmadosama, c

[okular] [Bug 389668] Saving a pdf switches from thumbnail view in sidebar to contents view

https://bugs.kde.org/show_bug.cgi?id=389668 Albert Astals Cid changed: What|Removed |Added Latest Commit||https://commits.kde.org/oku

D14752: Fix links being "lost" on save

sander added a comment. That's more than enough as an explanation, and too much to put it in the text. Can we simply mention the bug and diff numbers in the code? IMO git blame is really only useful until somebody applies another change to the lines this patch introduces. REPOSITORY

D14752: Fix links being "lost" on save

tobiasdeiminger added inline comments. INLINE COMMENTS > generator_pdf.cpp:653 > > +if (oldRectsGenerated.count() == rectsGenerated.count()) { > +for (int i = 0; i < oldRectsGenerated.count(); ++i) { Guess this is the same sanity check as in document.cpp, Document::swapBackingFile

D14752: Fix links being "lost" on save

tobiasdeiminger added a comment. @sander Here's a bit of explanation how I understand it. Maybe you can extract comments / commit message / documentation from it. "ctrl+s" saves a modified PDF to file, and then uses "hot-swap" (43a3756e1

D14752: Fix links being "lost" on save

tobiasdeiminger added a comment. Alberts patch works for me and I don't know another solution that would be reasonable simple. BUG: 397373 is a side effect of deferred ("lazy") link setup inside PDFGenerator. Deferred link setup is an implementation detail of PDFGenerator, and so its side ef