D16941: Fix inconsistent viewport positioning in PageView

tobiasdeiminger edited the summary of this revision. tobiasdeiminger edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16941 To: tobiasdeiminger Cc: sander, aacid, okular-devel, ngraham

[okular] [Bug 341939] Reloading a PDF document with page-aligned view jumps up in the document

https://bugs.kde.org/show_bug.cgi?id=341939 Tobias Deiminger changed: What|Removed |Added CC||haxti...@posteo.de --- Comment #3 from

[okular] [Bug 350798] Okular opens large PDFs very slowly

https://bugs.kde.org/show_bug.cgi?id=350798 --- Comment #23 from Blase Johnson --- I can open that document in about 2 seconds. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 341945] Wrong rendering with scrolling in PDF

https://bugs.kde.org/show_bug.cgi?id=341945 Andrew Crouthamel changed: What|Removed |Added CC||andrew.crouthamel@kdemail.n

[okular] [Bug 348004] Deselecting 'Show scrollbars' setting freezes page view

https://bugs.kde.org/show_bug.cgi?id=348004 Andrew Crouthamel changed: What|Removed |Added Ever confirmed|0 |1 Version|0.22.1

[okular] [Bug 340833] Previously created annotation shouldn't be activated during continuously free hand writing

https://bugs.kde.org/show_bug.cgi?id=340833 Andrew Crouthamel changed: What|Removed |Added Keywords||investigated, triaged CC|

[okular] [Bug 344630] Particular EPS file does not show in okular but does in gs

https://bugs.kde.org/show_bug.cgi?id=344630 Andrew Crouthamel changed: What|Removed |Added CC||andrew.crouthamel@kdemail.n

[okular] [Bug 341939] Reloading a PDF document with page-aligned view jumps up in the document

https://bugs.kde.org/show_bug.cgi?id=341939 Andrew Crouthamel changed: What|Removed |Added Status|REPORTED|CONFIRMED CC|

D16941: Fix inconsistent viewport positioning in PageView

tobiasdeiminger added a comment. In D16941#361164 , @sander wrote: > It is still not perfect I can reproduce everything you describe there. After touching the file once, a cascade of several notifyViewportChanged and slotRelayoutPages

[okular] [Bug 363152] Form text not displayed for upside-down field

https://bugs.kde.org/show_bug.cgi?id=363152 Sebastian changed: What|Removed |Added Ever confirmed|0 |1 CC|

[okular] [Bug 400890] Touching file moves the view port

https://bugs.kde.org/show_bug.cgi?id=400890 --- Comment #4 from Oliver Sander --- Hmm, now I can't reproduce the 'scrolling' part of the previous post anymore... not sure what's happening. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 185908] render pages in individual threads

https://bugs.kde.org/show_bug.cgi?id=185908 Sebastian changed: What|Removed |Added CC||richard.l...@gmail.com --- Comment #2 from

[okular] [Bug 341161] Utilize more than one CPU core

https://bugs.kde.org/show_bug.cgi?id=341161 Sebastian changed: What|Removed |Added Status|REPORTED|RESOLVED CC|

D16941: Fix inconsistent viewport positioning in PageView

sander added a comment. This looks like a definite improvement. It is still not perfect -- see my description at https://bugs.kde.org/show_bug.cgi?id=400890#c3 . As you seem to have acquired quite some understanding of that viewport positioning logic, could you maybe add some extra

[okular] [Bug 400890] Touching file moves the view port

https://bugs.kde.org/show_bug.cgi?id=400890 --- Comment #3 from Oliver Sander --- It *almost* fixes the issue. Now, when I leave presentation mode the top of the viewport is the bottom of the previous page, i.e., I can see the entire grey horizontal stripe between the current page and the

[okular] [Bug 358068] Shape of drawn polygon is not previewed

https://bugs.kde.org/show_bug.cgi?id=358068 Sebastian changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED

[okular] [Bug 358069] Browse mode pointer should be an arrow not an hand to improve precision

https://bugs.kde.org/show_bug.cgi?id=358069 Sebastian changed: What|Removed |Added Keywords||investigated, triaged Severity|normal

[okular] [Bug 377459] Loading time for CHM files is slow !!

https://bugs.kde.org/show_bug.cgi?id=377459 Sebastian changed: What|Removed |Added CC||sebastian.englbre...@tum.de

[okular] [Bug 374806] Bing - you've made a spelling mistake when searching

https://bugs.kde.org/show_bug.cgi?id=374806 Oliver Sander changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[okular] [Bug 375220] mouse wheel scrolling broken after update to 16.12

https://bugs.kde.org/show_bug.cgi?id=375220 Sebastian changed: What|Removed |Added Keywords||investigated, triaged CC|

[okular] [Bug 357958] Viewport is selected inconsistently when navigating with left/right arrow keys

https://bugs.kde.org/show_bug.cgi?id=357958 Tobias Deiminger changed: What|Removed |Added CC||haxti...@posteo.de --- Comment #3 from

[okular] [Bug 375334] Closing a document changes focus to zoom window in the active document

https://bugs.kde.org/show_bug.cgi?id=375334 Sebastian changed: What|Removed |Added CC||sebastian.englbre...@tum.de

[okular] [Bug 375211] Table Select tool fails on large table

https://bugs.kde.org/show_bug.cgi?id=375211 Sebastian changed: What|Removed |Added Ever confirmed|0 |1 Version|0.20.3

[okular] [Bug 374806] Bing - you've made a spelling mistake when searching

https://bugs.kde.org/show_bug.cgi?id=374806 Sebastian changed: What|Removed |Added Resolution|--- |WAITINGFORINFO CC|

[okular] [Bug 357958] Viewport is selected inconsistently when navigating with left/right arrow keys

https://bugs.kde.org/show_bug.cgi?id=357958 Blase Johnson changed: What|Removed |Added Resolution|--- |WORKSFORME CC|

[okular] [Bug 357958] Viewport is selected inconsistently when navigating with left/right arrow keys

https://bugs.kde.org/show_bug.cgi?id=357958 Blase Johnson changed: What|Removed |Added Keywords||triaged -- You are receiving this mail

[okular] [Bug 372581] font too big for numbers in printed forms

https://bugs.kde.org/show_bug.cgi?id=372581 Sebastian changed: What|Removed |Added CC||sebastian.englbre...@tum.de Resolution|---

[okular] [Bug 246196] When filling in forms, make it possible to set the font size of the forms

https://bugs.kde.org/show_bug.cgi?id=246196 Sebastian changed: What|Removed |Added CC||li...@drmartinus.de --- Comment #16 from Sebastian

[okular] [Bug 370629] search function doesn't work until I click on a Filter Option

https://bugs.kde.org/show_bug.cgi?id=370629 Sebastian changed: What|Removed |Added Keywords||investigated, triaged Status|REPORTED

D16941: Fix inconsistent viewport positioning in PageView

tobiasdeiminger updated this revision to Diff 45688. tobiasdeiminger added a comment. Assert correctly. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16941?vs=45623=45688 BRANCH unify_vp_calc REVISION DETAIL https://phabricator.kde.org/D16941

[okular] [Bug 369043] links to local files do not interpret %20 as space

https://bugs.kde.org/show_bug.cgi?id=369043 Sebastian changed: What|Removed |Added Keywords||triaged -- You are receiving this mail because:

[okular] [Bug 369043] links to local files do not interpret %20 as space

https://bugs.kde.org/show_bug.cgi?id=369043 Sebastian changed: What|Removed |Added Resolution|--- |WAITINGFORINFO CC|

[okular] [Bug 363768] Font size is changed when form value is modified

https://bugs.kde.org/show_bug.cgi?id=363768 Sebastian changed: What|Removed |Added Version|0.24.0 |1.3.3 Ever confirmed|0

[okular] [Bug 350798] Okular opens large PDFs very slowly

https://bugs.kde.org/show_bug.cgi?id=350798 --- Comment #22 from Ruslan Kabatsayev --- (In reply to Blase Johnson from comment #21) > Does it still take you a long time to open the document with a more recent > version of Okular? Still 4 seconds with the document from comment 0 on Kubuntu

[okular] [Bug 246196] When filling in forms, make it possible to set the font size of the forms

https://bugs.kde.org/show_bug.cgi?id=246196 Sebastian changed: What|Removed |Added CC||sebastian.englbre...@tum.de --- Comment #15 from

[okular] [Bug 355856] Find button is at the top of the page but box to enter words is at the bottom

https://bugs.kde.org/show_bug.cgi?id=355856 Blase Johnson changed: What|Removed |Added Keywords||triaged CC|

[okular] [Bug 355856] Find button is at the top of the page but box to enter words is at the bottom

https://bugs.kde.org/show_bug.cgi?id=355856 Albert Astals Cid changed: What|Removed |Added Severity|normal |wishlist CC|

[okular] [Bug 350798] Okular opens large PDFs very slowly

https://bugs.kde.org/show_bug.cgi?id=350798 Blase Johnson changed: What|Removed |Added Resolution|--- |WAITINGFORINFO CC|

[okular] [Bug 350798] Okular opens large PDFs very slowly

https://bugs.kde.org/show_bug.cgi?id=350798 Blase Johnson changed: What|Removed |Added Keywords||triaged -- You are receiving this mail

[okular] [Bug 355599] Wrong rendering of bulleted list

https://bugs.kde.org/show_bug.cgi?id=355599 Blase Johnson changed: What|Removed |Added Keywords||triaged -- You are receiving this mail

[okular] [Bug 355599] Wrong rendering of bulleted list

https://bugs.kde.org/show_bug.cgi?id=355599 Blase Johnson changed: What|Removed |Added Resolution|--- |WAITINGFORINFO CC|

D16956: Remove Jovie from FAQ

aacid closed this revision. REPOSITORY R575 Okular Website (okular.kde.org) REVISION DETAIL https://phabricator.kde.org/D16956 To: lueck, aacid Cc: okular-devel, ngraham, aacid

D16956: Remove Jovie from FAQ

lueck added a comment. @aacid I have not enough karma to commit, please do it REPOSITORY R575 Okular Website (okular.kde.org) REVISION DETAIL https://phabricator.kde.org/D16956 To: lueck, aacid Cc: okular-devel, ngraham, aacid

D16956: Remove Jovie from FAQ

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R575 Okular Website (okular.kde.org) REVISION DETAIL https://phabricator.kde.org/D16956 To: lueck, aacid Cc: okular-devel, ngraham, aacid

[okular] [Bug 379296] Reloading file hides the annotation toolbar

https://bugs.kde.org/show_bug.cgi?id=379296 Jaime Torres changed: What|Removed |Added Keywords||triaged Resolution|---

[okular] [Bug 368598] Zoom Out does not work when zoom is set to Fit Page or Fit Width

https://bugs.kde.org/show_bug.cgi?id=368598 --- Comment #7 from a...@rossberg.net --- Yes, trim margins seems to be involved. I am running okular 1.3.3 on Ubuntu 18.04, and can confirm the problem occurs only when "trim margins" is on. I can turn the bug off and on by toggling "trim margins". It

[okular] [Bug 368598] Zoom Out does not work when zoom is set to Fit Page or Fit Width

https://bugs.kde.org/show_bug.cgi?id=368598 --- Comment #6 from Magnus Aagaard Sørensen --- After reviewing some other bugs, the behaviour seen here seems related to #342003. Can you confirm this is not related to "View -> Trim View -> Trim Margins"? -- You are receiving this mail because: You

[okular] [Bug 342003] Trim margins confuses ordering of zoom steps while zooming out

https://bugs.kde.org/show_bug.cgi?id=342003 Magnus Aagaard Sørensen changed: What|Removed |Added CC||yildirim.us...@gmail.com --- Comment

[okular] [Bug 366449] When viewing a pdf, if I trim margins (and go full screen), zoom out does not work properly

https://bugs.kde.org/show_bug.cgi?id=366449 Magnus Aagaard Sørensen changed: What|Removed |Added Component|PDF backend |general CC|

[okular] [Bug 351889] Switching viewmode/Rotating view can result in low-res page render

https://bugs.kde.org/show_bug.cgi?id=351889 Luigi Toscano changed: What|Removed |Added Resolution|WORKSFORME |--- CC|

[okular] [Bug 348117] tab title does not change when opening a new document via bookmark panel

https://bugs.kde.org/show_bug.cgi?id=348117 Luigi Toscano changed: What|Removed |Added CC||luigi.tosc...@tiscali.it

[okular] [Bug 401044] When "copying and pasting": Okular prints line breaks that don't really exist, and therefore some lines are "broken" :(

https://bugs.kde.org/show_bug.cgi?id=401044 Magnus Aagaard Sørensen changed: What|Removed |Added Ever confirmed|0 |1 Keywords|

[okular] [Bug 400327] Trim Margins does not work properly when applied to files opened in different tabs

https://bugs.kde.org/show_bug.cgi?id=400327 Magnus Aagaard Sørensen changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED

[okular] [Bug 342003] Trim margins confuses ordering of zoom steps while zooming out

https://bugs.kde.org/show_bug.cgi?id=342003 Magnus Aagaard Sørensen changed: What|Removed |Added Status|REPORTED|CONFIRMED CC|

[okular] [Bug 379634] Fails to load PDF files from SFTP filesystem

https://bugs.kde.org/show_bug.cgi?id=379634 Jaime Torres changed: What|Removed |Added Keywords||triaged CC|

[okular] [Bug 368598] Zoom Out does not work when zoom is set to Fit Page or Fit Width

https://bugs.kde.org/show_bug.cgi?id=368598 Magnus Aagaard Sørensen changed: What|Removed |Added Resolution|--- |WAITINGFORINFO

D16956: Remove Jovie from FAQ

lueck created this revision. lueck added a reviewer: aacid. Herald added a project: Okular. Herald added a subscriber: okular-devel. lueck requested review of this revision. REVISION SUMMARY Jovie is gone, replace it with Qt Speech REPOSITORY R575 Okular Website (okular.kde.org) REVISION

[okular] [Bug 368598] Zoom Out does not work when zoom is set to Fit Page or Fit Width

https://bugs.kde.org/show_bug.cgi?id=368598 Magnus Aagaard Sørensen changed: What|Removed |Added CC||mag...@aagaardsorensen.dk

[okular] [Bug 378515] Vertical text interfere with horizontal text highlighter annotation tool

https://bugs.kde.org/show_bug.cgi?id=378515 Jaime Torres changed: What|Removed |Added CC||jtam...@gmail.com Resolution|---

[okular] [Bug 377493] Music staff notation is often impossible to read due to object placement and line spacing

https://bugs.kde.org/show_bug.cgi?id=377493 Jaime Torres changed: What|Removed |Added CC||jtam...@gmail.com Resolution|---

[okular] [Bug 377493] Music staff notation is often impossible to read due to object placement and line spacing

https://bugs.kde.org/show_bug.cgi?id=377493 --- Comment #1 from Jaime Torres --- Created attachment 116369 --> https://bugs.kde.org/attachment.cgi?id=116369=edit screenshots of the same places as before -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 351889] Switching viewmode/Rotating view can result in low-res page render

https://bugs.kde.org/show_bug.cgi?id=351889 muzhit changed: What|Removed |Added Keywords||investigated, triaged CC|

D16941: Fix inconsistent viewport positioning in PageView

tobiasdeiminger added a comment. In D16941#360741 , @aacid wrote: > Can we have an autotest? Yes will try, but probably won't get to it today. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16941 To:

[okular] [Bug 400890] Touching file moves the view port

https://bugs.kde.org/show_bug.cgi?id=400890 Tobias Deiminger changed: What|Removed |Added Ever confirmed|0 |1 CC|

D16941: Fix inconsistent viewport positioning in PageView

aacid added a comment. Can we have an autotest? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16941 To: tobiasdeiminger Cc: aacid, okular-devel, ngraham

[okular] [Bug 401070] Feature request: Edit page order (rearrange, delete, add)

https://bugs.kde.org/show_bug.cgi?id=401070 Albert Astals Cid changed: What|Removed |Added Resolution|--- |INTENTIONAL CC|

D16941: Fix inconsistent viewport positioning in PageView

tobiasdeiminger created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. tobiasdeiminger requested review of this revision. REVISION SUMMARY This diff unifies the calculation of the viewport position from a given DocumentViewport.

[okular] [Bug 401098] Printing stops at first hyperlink, incomplete pages.

https://bugs.kde.org/show_bug.cgi?id=401098 Albert Astals Cid changed: What|Removed |Added Status|REPORTED|NEEDSINFO CC|

[okular] [Bug 169847] split view feature

https://bugs.kde.org/show_bug.cgi?id=169847 Albert Astals Cid changed: What|Removed |Added CC||ash...@linuxcomp.ru --- Comment #31 from

[okular] [Bug 401131] Several view ports of a single document

https://bugs.kde.org/show_bug.cgi?id=401131 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Resolution|---

[okular] [Bug 254306] Printing files processed by pdfcrop causes the margins to reappear on the printout.

https://bugs.kde.org/show_bug.cgi?id=254306 muzhit changed: What|Removed |Added Keywords||triaged -- You are receiving this mail because: You

[okular] [Bug 348117] tab title does not change when opening a new document via bookmark panel

https://bugs.kde.org/show_bug.cgi?id=348117 muzhit changed: What|Removed |Added Keywords||investigated, triaged CC|

[okular] [Bug 339176] feature request: fit to page

https://bugs.kde.org/show_bug.cgi?id=339176 Muzhi Tian changed: What|Removed |Added CC||b.weggenmann+...@gmail.com --- Comment #7 from