D18744: Add action in Edit menu to select the text on current page

shubham updated this revision to Diff 52576. shubham added a comment. 1. Try to fix crash case 2. Improve comment REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=52502&id=52576 REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES

D18816: Accept and ignore event

shubham added a comment. In D18816#419557 , @aacid wrote: > The ping is on your side, you still haven't explained why this is needed and what it fixes I told you in my previous comment that it was handled the same way in ktexteditor, tha

D18744: Add action in Edit menu to select the text on current page

shubham added a comment. In D18744#419287 , @yurchor wrote: > In D18744#419212 , @shubham wrote: > > > @yurchor what about the crash case, is it fixed now? > > > No. I think that the action sho

[okular] [Bug 403524] in "save as" the drop down list of recent places doesn't contain recent places

https://bugs.kde.org/show_bug.cgi?id=403524 --- Comment #4 from Nate Graham --- you can get a screenshot by using Spectacle's timer with Full Screen or Rectangular Region mode. Set the delay to 2 seconds, click "take screenshot", then open the menu before it takes the screenshot. -- You are rec

[okular] [Bug 403524] in "save as" the drop down list of recent places doesn't contain recent places

https://bugs.kde.org/show_bug.cgi?id=403524 --- Comment #3 from davidblunkett --- To be sure: I'm referring to the path that appears above the file list. If you click the path it becomes a text entry box with a pull down list of recent places. If you pull the recent places down it doesn't upda

[okular] [Bug 404803] please restore old behaviour for storing PDF annotations in separate file

https://bugs.kde.org/show_bug.cgi?id=404803 --- Comment #4 from Albert Astals Cid --- explaining my time -> spending my time -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 404803] please restore old behaviour for storing PDF annotations in separate file

https://bugs.kde.org/show_bug.cgi?id=404803 --- Comment #3 from Albert Astals Cid --- There's various blogs, mailing lists discussions and bugs about it, so yes, i do mind explaining my time explaining it again. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 404803] please restore old behaviour for storing PDF annotations in separate file

https://bugs.kde.org/show_bug.cgi?id=404803 --- Comment #2 from Gerald Weber --- (In reply to Albert Astals Cid from comment #1) > Not going to happen. Would you mind to explain why? -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 404803] please restore old behaviour for storing PDF annotations in separate file

https://bugs.kde.org/show_bug.cgi?id=404803 Albert Astals Cid changed: What|Removed |Added Resolution|--- |INTENTIONAL Status|REPORTED

D18816: Accept and ignore event

aacid added a comment. The ping is on your side, you still haven't explained why this is needed and what it fixes REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18816 To: shubham, aacid Cc: ngraham, okular-devel, tfella, darcyshen, aacid

[okular] [Bug 402033] Okular "typewriter" annotation tool - can't change text font or colour

https://bugs.kde.org/show_bug.cgi?id=402033 --- Comment #11 from Daniel Borek --- The problem still exist in snap version 1.6.2 -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 402033] Okular "typewriter" annotation tool - can't change text font or colour

https://bugs.kde.org/show_bug.cgi?id=402033 Daniel Borek changed: What|Removed |Added CC||dtbo...@gmail.com -- You are receiving this mai

D18744: Add action in Edit menu to select the text on current page

yurchor added a comment. In D18744#419212 , @shubham wrote: > @yurchor what about the crash case, is it fixed now? No. I think that the action should be created in part.cpp, setEnabled(false) by default, then setEnabled(true) in the Part:

[okular] [Bug 404803] New: please restore old behaviour for storing PDF annotations in separate file

https://bugs.kde.org/show_bug.cgi?id=404803 Bug ID: 404803 Summary: please restore old behaviour for storing PDF annotations in separate file Product: okular Version: 1.3.3 Platform: openSUSE RPMs OS: Linux

D18744: Add action in Edit menu to select the text on current page

shubham added a comment. @yurchor what about the crash case, is it fixed now? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-de

D18744: Add action in Edit menu to select the text on current page

yurchor added a comment. Tested. Works as expected. INLINE COMMENTS > index.docbook:1296 > + > + > Trailing spaces > pageview.cpp:737 > kredo->setEnabled(false); > + > +// Setup select all action for the curren