D19123: Added option to search for whole words only

yurchor added a comment. Many thanks in advance for fixing this minor typo. INLINE COMMENTS > textpage.cpp:857 > + > +// If I'm at the beggining/end of the text, I don't need to check > after/before > +if( start == m_words.constBegin() ) Typo: beggining -> beginning REPOSITORY R

D19123: Added option to search for whole words only

joaonetto edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19123 To: joaonetto, #okular Cc: aacid, ngraham, okular-devel, tfella, darcyshen

D19123: Added option to search for whole words only

joaonetto updated this revision to Diff 52697. joaonetto added a comment. Removed useless code, remodeled tests and fixed corner case REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19123?vs=52404&id=52697 BRANCH arcpatch-D19123 REVISION DETAIL https://

D19123: Added option to search for whole words only

aacid added inline comments. INLINE COMMENTS > searchtest.cpp:368 > > +void SearchTest::testWholeWords(){ > + #define TEST_WHOLE_WORDS_SITUATION_COUNT 4 Seems like using a _data function here so that "test data" and "test code" are separated may be a good idea. Can you please investigate?

D18658: Modify search bar in the contextDrawer

aacid added inline comments. INLINE COMMENTS > CMakeLists.txt:12 > set(QT_REQUIRED_VERSION "5.8.0") > -set(KF5_REQUIRED_VERSION "5.44.0") > I don't like this. If you need a new kirigami or something make a vesion check and then enable kirigami only if X verison is available, but i don't lik

D19183: Use logically correct icon for direction arrows

aacid added a comment. Isn't this broken when using a RTL layout? REPOSITORY R223 Okular BRANCH icon REVISION DETAIL https://phabricator.kde.org/D19183 To: shubham, #vdg, ngraham, #okular Cc: aacid, abetts, davidhurka, ngraham, okular-devel, tfella, darcyshen

D18816: Accept and ignore event

davidhurka added a comment. You have little conversation output, and I have little understanding of QEvent. But lets start to explain why the event should not be propagated to another widget, although there was no annotation or the mouseMode is not TextSelect? Alternatively: Which other

[okular] [Bug 404549] Printing N copies results in N^2 copies printed instead

https://bugs.kde.org/show_bug.cgi?id=404549 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Resolution|WAITINGFOR

D18816: Accept and ignore event

aacid added a comment. I know how to read, apparently you don't. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18816 To: shubham, aacid Cc: ngraham, okular-devel, tfella, darcyshen, aacid

[frameworks-kio] [Bug 403524] URL navigator's drop down list of recent places doesn't contain recent places

https://bugs.kde.org/show_bug.cgi?id=403524 Nate Graham changed: What|Removed |Added CC||kdelibs-b...@kde.org Component|general

[okular] [Bug 404803] please restore old behaviour for storing PDF annotations in separate file

https://bugs.kde.org/show_bug.cgi?id=404803 --- Comment #5 from David Hurka --- This dates back to... long ago? There are basically these commits (and probably others) which introduced this message (KMessageWidget *Okular::Part::m_migrationMessage): commit 34f40b2c6f301a8eab1ea244aab5d281a0384a

[okular] [Bug 403524] in "save as" the drop down list of recent places doesn't contain recent places

https://bugs.kde.org/show_bug.cgi?id=403524 --- Comment #5 from davidblunkett --- Created attachment 118370 --> https://bugs.kde.org/attachment.cgi?id=118370&action=edit dialog picture -- You are receiving this mail because: You are the assignee for the bug.