D18744: Add action in Edit menu to select the text on current page

aacid requested changes to this revision. aacid added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > shubham wrote in pageview.cpp:5598 > If removed, it causes crash. Sorry but that's not a valid answer, you'll have to explain why sometimes you have to delete

D18744: Add action in Edit menu to select the text on current page

ngraham accepted this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna,

D18744: Add action in Edit menu to select the text on current page

shubham added a comment. In D18744#437473 , @ngraham wrote: > In D18744#437461 , @shubham wrote: > > > Try to fix the crash. I could not test it because for me I could not see the entry added to

D18744: Add action in Edit menu to select the text on current page

shubham added inline comments. INLINE COMMENTS > aacid wrote in pageview.cpp:5598 > Why this return? If removed, it causes crash. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english,

D18744: Add action in Edit menu to select the text on current page

ngraham added a comment. In D18744#437461 , @shubham wrote: > Try to fix the crash. I could not test it because for me I could not see the entry added to the menu. You gotta fix that. :) Try deleting

D18744: Add action in Edit menu to select the text on current page

shubham updated this revision to Diff 54700. shubham added a comment. Try to fix the crash REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=54493=54700 BRANCH arcpatch-D18744 REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES

D18744: Add action in Edit menu to select the text on current page

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I just re-tested and now the menu item crashes when used, no matter which PDF I try. :( Again, please test before submitting or updating a patch. REPOSITORY R223 Okular

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

sander added a comment. I do use my stylus for drawing on slides in presentation mode. I am not particularly happy with the quality of that, but compressing tablet events doesn't seem to make it worse. So no objections from my side. REPOSITORY R223 Okular REVISION DETAIL

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

kezik added a comment. Hi, thanks for the feedback. I think uncompressed tablet events are useful for example on krita, when you don't want to lose the "high frequency" content of the drawing on the screen, and latency is not a big issue. I don't see any downsides for okular, mouse

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

sander added a comment. I tried this on my ThinkPad Yoga 12, which comes with a stylus to write on the screen with. I confirm that this patch noticeably improves the scrolling behavior when using the stylus for scrolling. I am curious though: what are the downsides to enabling tablet

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

kezik updated this revision to Diff 54655. kezik retitled this revision from "Don't call scrollTo every time there's a mouseMoveEvent, use a timer instead" to "Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet". kezik edited the summary of this revision.