D19702: Page changes triggered by mouse clicks should all happen on button release

2019-03-25 Thread Oliver Sander
sander added a comment. Is this okay now? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19702 To: sander, #okular, ngraham, aacid Cc: aacid, okular-devel, joaonetto, tfella, ngraham, darcyshen

D18744: Add action in Edit menu to select the text on current page

2019-03-25 Thread Albert Astals Cid
aacid added a comment. besides "delete nullptr" is perfectly fine and non crashy. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okula

D18744: Add action in Edit menu to select the text on current page

2019-03-25 Thread David Hurka
davidhurka added a comment. In D18744#438076 , @shubham wrote: > @aacid area is a RegularAreaRect object which is a QRect bounding the selected text. "area" is to be deleted in all the cases except the case in which it is not possible to delete

[okular] [Bug 367959] Okular mangles some characters (non embedded fonts)

2019-03-25 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=367959 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com --- Comment #9 from Patrick

[okular] [Bug 368588] Okular preview of certain PDF documents shows empty pages with Okular logo only

2019-03-25 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=368588 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com Ever confirmed|0

[okular] [Bug 368598] Zoom Out does not work when zoom is set to Fit Page or Fit Width and "Trim margins" is enabled

2019-03-25 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=368598 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com Summary|Zoom Out

[okular] [Bug 375334] Closing a document changes focus to zoom window in the active document

2019-03-25 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=375334 --- Comment #5 from Patrick Silva --- ops, I meant "Open new files in tabs" -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 375334] Closing a document changes focus to zoom window in the active document

2019-03-25 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=375334 Patrick Silva changed: What|Removed |Added Resolution|UNMAINTAINED|--- Status|RESOLVED

D18744: Add action in Edit menu to select the text on current page

2019-03-25 Thread Shubham
shubham added a comment. @aacid area is a RegularAreaRect object which is a QRect bounding the selected text. "area" is to be deleted in all the cases except the case in which it is not possible to delete it since "area" will not contain any text in it and hence it will be nullptr. (case: if

Re: Okular on Windows again?

2019-03-25 Thread Oliver Sander
>> a) Place a link on the Okular download page to those nightly builds, >> marking it clearly as "Experimental, may eat your $whatever". >> >> b) Do actual windows releases as described under >> >>http://kfunk.org/2017/11/17/kde-binary-factory/ "Now what to do..." >> >> Is that a possibility