D20351: Improve Legibility of preview of rectangle annotation and make it same color as resulting rectangle

ngraham added a comment. In D20351#445664 , @aacid wrote: > 3 is an arbitrary width, so -1 for this change I'm not a huge fan either, but not because it's arbitrary (everything visual is arbitrary) but rather because this makes it look to

D20351: Improve Legibility of preview of rectangle annotation and make it same color as resulting rectangle

aacid added a comment. 3 is an arbitrary width, so -1 for this change I'm also not really convinced about he color, but that's less contentious than having a random 3 in there. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20351 To: ahmedbilal, #okular, okular

D20351: Improve Legibility of preview of rectangle annotation and make it same color as resulting rectangle

ahmedbilal retitled this revision from "Increase width of preview of rectangle annotation (dashed rectangle) and set its color same as the color of rectangle that will be created once mouseup event happen." to "Improve Legibility of preview of rectangle annotation and make it same color as resul

D20351: Increase width of preview of rectangle annotation (dashed rectangle) and set its color same as the color of rectangle that will be created once mouseup event happen.

ahmedbilal added a comment. Before F6758346: image.png After F6758354: image.png Result in both cases F6758349: image.png Note, that the preview of rectangle is the

D20351: Increase width of preview of rectangle annotation (dashed rectangle) and set its color same as the color of rectangle that will be created once mouseup event happen.

ahmedbilal added a reviewer: ngraham. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20351 To: ahmedbilal, #okular, okular-devel, ngraham Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

[okular] [Bug 406269] pdf document with empty signature field is claimed to be signed

https://bugs.kde.org/show_bug.cgi?id=406269 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org --- Comment #1 from Albert As

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

aacid added a comment. That's your (plural) conclusion not mine, i disagree with that conclusion so i will voice my concern each time that happens. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16519 To: kezik, #okular, ngraham Cc: ngraham, sander, aacid, okular-de

Re: GSoC Mentors, please

PING On Fri, Apr 5, 2019 at 7:33 PM Valorie Zimmerman < valorie.zimmer...@gmail.com> wrote: > Please login to the GSoC webapp, click the Proposals tab, and find your > students' proposals. Click the title, and scroll down on that page for > where you can comment to the other mentors and admins. >

D20351: Increase width of preview of rectangle annotation (dashed rectangle) and set its color same as the color of rectangle that will be created once mouseup event happen.

ahmedbilal edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20351 To: ahmedbilal, #okular, okular-devel Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D20351: Increase width of preview of rectangle annotation (dashed rectangle) and set its color same as the color of rectangle that will be created once mouseup event happen.

ahmedbilal added reviewers: Okular, okular-devel. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20351 To: ahmedbilal, #okular, okular-devel Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D20351: Increase width of preview of rectangle annotation (dashed rectangle) and set its color same as the color of rectangle that will be created once mouseup event happen.

ahmedbilal created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. ahmedbilal requested review of this revision. REPOSITORY R223 Okular BRANCH rectangle_preview_improved REVISION DETAIL https://phabricator.kde.org/D20351 AFFECTED FILES ui/pageview