D20760: Okular Annotation: add support for line ending style for Straight Line tool

knambiar edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20760 To: knambiar, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D20760: Okular Annotation: add support for line ending style for Straight Line tool

knambiar created this revision. knambiar added a reviewer: Okular. knambiar added a project: Okular. Herald added a subscriber: okular-devel. knambiar requested review of this revision. REVISION SUMMARY Poppler and Okular already have support for specifying Line End style (`TermStyle`) for the

D19717: Search function fails to find phrases split over two lines

aacid added a comment. In D19717#454567 , @joaonetto wrote: > In my honest opinion we shouldn't support for '\n' search, unless it's something like regex search, but I see you disagree. I'm not saying to support \n that is not a characte

D19717: Search function fails to find phrases split over two lines

joaonetto added a comment. Hm. I can think of checking if the '\n' is in the search bar. What if we limit the '\n' search to case sensitive? That can be a way, only search what is typed. Right now I don't see exactly how we would do it, because there's no way we can identify whi

[okular] [Bug 406237] PDFs get an added margin when printing

https://bugs.kde.org/show_bug.cgi?id=406237 Matthew Trescott changed: What|Removed |Added Resolution|DUPLICATE |--- Status|RESOLVED

D19717: Search function fails to find phrases split over two lines

aacid added a comment. In D19717#454320 , @joaonetto wrote: > Made the necessary changes to work with any type of space. I don't think this is the way to go. If i took the work to figure out how to type a newline in the search line i

D19717: Search function fails to find phrases split over two lines

joaonetto added a comment. It probably will work, I'll try it REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19717 To: joaonetto, #okular Cc: davidhurka, aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen

D19717: Search function fails to find phrases split over two lines

davidhurka added a comment. In D19717#454323 , @joaonetto wrote: > It should work now, can you test it? Me? Don’t have a wall plug here, so can’t compile now. Additionally, I didn’t really look at your code. But how about QString::s

D19717: Search function fails to find phrases split over two lines

joaonetto added a comment. In D19717#454164 , @davidhurka wrote: > > I think it would make sense to treat all whitespace equally. At least on paper, there are several possible methods to disperse text. (Different line spacing, dif

D19717: Search function fails to find phrases split over two lines

joaonetto updated this revision to Diff 56760. joaonetto added a comment. Made the necessary changes to work with any type of space. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19717?vs=54906&id=56760 BRANCH arcpatch-D19717 REVISION DETAIL https://p

[okular] [Bug 383651] Custom/image stamp annotations are not saved into the PDF file in a way that can be printed or that other readers can see

https://bugs.kde.org/show_bug.cgi?id=383651 Valentin Melot changed: What|Removed |Added CC||valen...@melot.tf --- Comment #26 from Valenti

[okular] [Bug 395497] Menubar - No text

https://bugs.kde.org/show_bug.cgi?id=395497 Jan Przybylak changed: What|Removed |Added Version|1.6.3 |1.7.0 -- You are receiving this mail because:

[okular] [Bug 395497] Menubar - No text

https://bugs.kde.org/show_bug.cgi?id=395497 --- Comment #15 from Jan Przybylak --- Created attachment 119560 --> https://bugs.kde.org/attachment.cgi?id=119560&action=edit My shell.rc file. Renaming it to something else solves the problem Renaming part.rc does nothing. However, renaming shell.r

D19717: Search function fails to find phrases split over two lines

davidhurka added a comment. In D19717#454160 , @joaonetto wrote: > In D19717#454108 , @davidhurka wrote: > > > In D19717#453821 , @aacid wrote: > > >

D19717: Search function fails to find phrases split over two lines

joaonetto marked 4 inline comments as done. joaonetto added a comment. In D19717#454108 , @davidhurka wrote: > In D19717#453821 , @aacid wrote: > > > There's a downside to this is that now if you act

D19717: Search function fails to find phrases split over two lines

davidhurka added a comment. In D19717#453821 , @aacid wrote: > There's a downside to this is that now if you actually put a newline character in the search it will fail where previously it worked. > > On the other hand typing an actual newlin

D19717: Search function fails to find phrases split over two lines

joaonetto marked an inline comment as done. joaonetto added a comment. In my opinion is better to have it this way, I guess most users don't know about the newline. Do you have an opinion in this @ngraham ? INLINE COMMENTS > aacid wrote in textpage.cpp:865 > strNotUsed seems like a weir

[okular] [Bug 377202] Empty DJVU page displayed in black

https://bugs.kde.org/show_bug.cgi?id=377202 --- Comment #6 from Alexander Trufanov --- Created attachment 119550 --> https://bugs.kde.org/attachment.cgi?id=119550&action=edit Djvu doc 2 This djvu contain page 3 which is displayed incorrectly when zoomed. -- You are receiving this mail becaus

[okular] [Bug 377202] Empty DJVU page displayed in black

https://bugs.kde.org/show_bug.cgi?id=377202 Alexander Trufanov changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED