D20760: Okular Annotation: add support for line ending style for Straight Line tool

2019-05-02 Thread Oliver Sander
sander added a comment. > I'd advocate to implement drawing the lines by code, i.e. QPainter::drawLine and friends. Then reuse the same code to draw icons. Agreed, but that is too much for a single patch. Rajeesh, nice patch! Can you get rid of the unicode symbols in the source cod

D20947: [EPubGenerator] Fetch the application palette just once

2019-05-02 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R223:43cf8c8aef98: [EPubGenerator] Fetch the application palette just once (authored by bruns). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20947?vs=57348&id=57393 RE

D20946: [EPubGenerator] Reduce nesting level in loop

2019-05-02 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R223:f7fbbf769be3: [EPubGenerator] Reduce nesting level in loop (authored by bruns). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20946?vs=57347&id=57392 REVISION DETA

[okular] [Bug 407140] Crash, QTextDocument chokes on input and ends up with negative pagecounts

2019-05-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=407140 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail beca

D20947: [EPubGenerator] Fetch the application palette just once

2019-05-02 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20947 To: bruns, #okular, ngraham Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D20946: [EPubGenerator] Reduce nesting level in loop

2019-05-02 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20946 To: bruns, #okular, ngraham Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D19123: Added option to search for whole words only

2019-05-02 Thread Joao Oliveira
joaonetto marked an inline comment as done. joaonetto added inline comments. INLINE COMMENTS > aacid wrote in page.h:192 > Both functions need to have proper documentation. And the new one needs a > since marker (same for all the other "public" functions) in core/*.h you > added/changed > > An

D19123: Added option to search for whole words only

2019-05-02 Thread Joao Oliveira
joaonetto updated this revision to Diff 57388. joaonetto marked 5 inline comments as done. joaonetto added a comment. Added documentation REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19123?vs=55432&id=57388 BRANCH arcpatch-D19123_1 REVISION DETAIL ht