davidhurka added a comment.
Didn’t get far yet. Much information is visible in the source code, but what
should I put into the class/member documentation, and what is clear just
because it’s a Part?
Is there some more KParts literature? I could find KParts on api.kde.org and
the tutoria
davidhurka created this revision.
davidhurka added a reviewer: Okular.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
davidhurka requested review of this revision.
REVISION SUMMARY
This shall add some documentation to the classes Part and PageView,
to describe their
https://bugs.kde.org/show_bug.cgi?id=407463
--- Comment #4 from David Hurka ---
(In reply to Tobias Deiminger from comment #3)
> - LL+Slash: No conflict. No idea what this is good for.
Sometimes, / is used instead of > for dimensions. But the slash should be
centered on the leader line, and not
davidhurka added a comment.
TextPagePrivate::correctTextOrder() calls some complex functions, which are
yet undocumented. Interesting stuff is happening in them, so they should get
some documentation. I added their prototypes to core/textpage_p.h, so I can add
documentation to them.
In
yurchor added a comment.
Thanks for fixing these typos.
INLINE COMMENTS
> textpage.h:179
> /**
> - * Text extraction function.
> + * Text extraction function. Looks for text in the given @param
> area, and concatenates it to a string.
> *
Should be "@p are
davidhurka created this revision.
davidhurka added a reviewer: Okular.
davidhurka added a project: Okular.
Herald added a subscriber: okular-devel.
davidhurka requested review of this revision.
REVISION SUMMARY
This adds some important documentation on TextEntity and other classes, and
improves
https://bugs.kde.org/show_bug.cgi?id=407463
--- Comment #3 from Tobias Deiminger ---
(In reply to Simone Gaiarin from comment #2)
> You are right. I have not thought about that use case.
But you're also right in that not all combinations make sense.
Let's check, how could leader line + arrow X
https://bugs.kde.org/show_bug.cgi?id=407338
Albert Astals Cid changed:
What|Removed |Added
CC||saskat...@net-c.ca
--- Comment #4 from Albe
https://bugs.kde.org/show_bug.cgi?id=407670
Albert Astals Cid changed:
What|Removed |Added
Resolution|--- |DUPLICATE
Status|REPORTED
https://bugs.kde.org/show_bug.cgi?id=407463
--- Comment #2 from Simone Gaiarin ---
You are right. I have not thought about that use case.
--
You are receiving this mail because:
You are the assignee for the bug.
tobiasdeiminger retitled this revision from "WIP: Add line annotation ending
arrows for non PDF documents" to "Add line annotation ending arrows for non PDF
documents".
tobiasdeiminger edited the summary of this revision.
tobiasdeiminger edited the test plan for this revision.
REPOSITORY
R223
tobiasdeiminger updated this revision to Diff 58238.
tobiasdeiminger added a comment.
Added circle, expose LineAnnotPainer.
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21248?vs=58184&id=58238
BRANCH
feature/drawlineendings
REVISION DETAIL
https://ph
https://bugs.kde.org/show_bug.cgi?id=406237
--- Comment #10 from Michael Weghorn ---
(In reply to Matthew Trescott from comment #7)
> [...]
> I just double-checked this to make certain. I turned off WiFi temporarily so
> CUPS would hold my print job (it's a network printer), then printed my
> Let
13 matches
Mail list logo
