D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-23 Thread David Hurka
davidhurka updated this revision to Diff 62411. davidhurka added a comment. - Fix id=current-color-scheme attributes which were removed by scour-icon. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22617?vs=62332&id=62411 BRANCH add-icons-for-pagela

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-23 Thread David Hurka
davidhurka added a comment. I assume that `fill="currentColor"` also doesn’t work as expected, fixing that now... REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg, ndavis Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-23 Thread David Hurka
davidhurka updated this revision to Diff 62415. davidhurka added a comment. - Remove color attributes, which were added by scour-icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22617?vs=62411&id=62415 BRANCH add-icons-for-pagelayouts REVISION D

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-23 Thread David Hurka
davidhurka added a comment. What does `fill:currentColor` mean, by the way? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg, ndavis Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-23 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. LGTM now. Very nice work. @ndavis, are you happy too? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg, ndavis, ngraham Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n,

D22064: General improvements to stamp annotation

2019-07-23 Thread Nathaniel Graham
ngraham added a comment. In D22064#500378 , @simgunz wrote: > I agree with @ngraham. Showing a warning seems the best solution for now. Any suggestions on the best way to display it? Is a string at the bottom of the appearence widget enough?

[okular] [Bug 410108] Two Okular launchers with the same name

2019-07-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=410108 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail beca

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

2019-07-23 Thread Noah Davis
ndavis added a comment. In D22617#500953 , @davidhurka wrote: > What does `fill:currentColor` mean, by the way? The current color is determined by the color class. There has to be a `fill`, so we set it to `currentColor`. INLINE COMMENT

[okular] [Bug 408683] blank page until I scroll

2019-07-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=408683 Albert Astals Cid changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED

[okular] [Bug 345235] Text is hidden when form fields are hidden, text does not export or print

2019-07-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=345235 Albert Astals Cid changed: What|Removed |Added Severity|critical|normal -- You are receiving this mail beca

D22064: General improvements to stamp annotation

2019-07-23 Thread Simone Gaiarin
simgunz updated this revision to Diff 62454. simgunz added a comment. - Add warning regarding broken stamp support in PDF REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22064?vs=62335&id=62454 BRANCH improve-stamp-annotation REVISION DETAIL https://pha