bdbai updated this revision to Diff 70387.
bdbai added a comment.
Fixed code styles
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25484?vs=70349&id=70387
REVISION DETAIL
https://phabricator.kde.org/D25484
AFFECTED FILES
autotests/mainshelltest.cpp
s
vkrause added a task: T11654: Deprecate
SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of
KIconLoader or QIcon API.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D25553
To: vkrause
Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre,
vkrause created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
vkrause requested review of this revision.
REPOSITORY
R223 Okular
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D25553
AFFECTED FILES
conf/dlgperformance.cpp
ui/ktreevie
https://bugs.kde.org/show_bug.cgi?id=414357
Andi Sardina changed:
What|Removed |Added
CC||andysardin...@gmail.com
--- Comment #1 from Andi
ngraham added a comment.
Thanks, this looks great. It works just fine and the UI seems sane to me. I
have some code comments:
INLINE COMMENTS
> shell.cpp:660
> +m_undoCloseTab->setEnabled( true );
> +m_closedTabUrls.push_back( url );
>
prefer `append()`
> shell.cpp:778
>
bdbai updated this revision to Diff 70349.
bdbai added a comment.
- Added "undo tab close"
- Added a test
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25484?vs=70197&id=70349
REVISION DETAIL
https://phabricator.kde.org/D25484
AFFECTED FILES
autotes
