emateli added a comment.
Perhaps this patch might not be it, but Okular does actually need a "Night
Mode" or "Reading Mode" of sorts, in similar fashion to many epub/pdf readers
like @filipf suggests.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D18623
To: ognarb,
emateli abandoned this revision.
emateli added a comment.
Resolved by author
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D6185
To: emateli, #okular, aacid
Cc: aacid
emateli changed the visibility from "All Users" to "Public (No Login Required)".
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D6185
To: emateli, #okular
Cc: aacid
emateli changed the visibility from "Public (No Login Required)" to "All Users".
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D6185
To: emateli, #okular
Cc: aacid
emateli added a comment.
I can see that the source you linked explicitly makes it checked, but If you
inspect the state just before the `if` execution you'd see that it actually is
not checked. Anyhow, if KStandartAction is supposed to handle this, then I
guess the bug(if any) might be there
emateli added a comment.
As far as I can tell from the source it's not Okular that it's doing the
hiding of that specific action, but rather the underlying framework apparently.
The action is visible again if you explicitly call `setVisible(true)` but as
expected, it does nothing when invoke
emateli added a comment.
In https://phabricator.kde.org/D6185#116489, @aacid wrote:
> I don't agree with this patch, the global menu bar should not be setting
actions to invisible, why is it doing that?
>
> I think the bug is on their side not in Okular side
It kind of makes s
emateli created this revision.
emateli added a project: Okular.
REVISION SUMMARY
Okular currently has a minor bug when using menubar style in the title bar or
application menu widget.
The bug: If you right click on Okular's document UI you will be shown an
empty "Tools" separator entry. T