D14310: Fixes url whitespaces in epub documents

gassaf added a comment. Here you go. I created this epub document via a free software tool called sigil. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14310 To: gassaf, #okular Cc: aacid, okular-devel, ngraham

D14310: Fixes url whitespaces in epub documents

gassaf updated this revision to Diff 39469. gassaf added a comment. epub generator unit test added REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14310?vs=38278=39469 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14310 AFFECTED FILES

D14310: Fixes url whitespaces in epub documents

gassaf added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14310 To: gassaf, #okular Cc: okular-devel, ngraham, aacid

D14310: Fixes url whitespaces in epub documents

gassaf created this revision. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. gassaf requested review of this revision. REVISION SUMMARY libepub can't handle whitespace url encodings. This is why epub documents containing whitespaces

D13766: fixed picture scaling issues in epub generator

gassaf added a comment. Same here: Regular DPI without scaling. I did a quick search in Okular source and everywhere, where the QImage `scaled*()` function is used, it is called with `Qt::SmoothTransformation` parameter. Except in the epub generator. REPOSITORY R223 Okular REVISION

D13766: fixed picture scaling issues in epub generator

gassaf added a comment. I did some more tests and epub_get_data() always returned the correct size. Original image file from ebook: F5980094: A978-1-4302-6653-2_CoverFigure_HTML.jpg Screenshot from Okular, build with /*if(img.height() >

D13766: fixed picture scaling issues in epub generator

gassaf added a comment. I tried commenting out the two lines (+if clause, so line 88 - 91) and all pictures are looking fine. Except that they are sometimes to big and break layout. So I would argue Okular does load all pictures with the correct solution, but the down-scaling part made them

D13766: fixed picture scaling issues in epub generator

gassaf edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13766 To: gassaf Cc: okular-devel, ngraham, aacid

D13766: fixed picture scaling issues in epub generator

gassaf created this revision. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. gassaf requested review of this revision. REVISION SUMMARY Images don't look blurry in epub files BUG: 391625 REPOSITORY R223 Okular BRANCH master

Re: Review Request 130057: Bug 288042 - Option to reset forms

it: https://git.reviewboard.kde.org/r/130057/#review103741 --- On Sept. 23, 2017, 7:08 p.m., Gilbert Assaf wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 130057: Bug 288042 - Option to reset forms

ca8bd78a4d78cb2e779b5b682c66fa60bcb3af80 ui/pageviewutils.cpp a46384afb3f976842d6693b60fb01fd474481d0d Diff: https://git.reviewboard.kde.org/r/130057/diff/4/ Changes: https://git.reviewboard.kde.org/r/130057/diff/3-4/ Testing --- Thanks, Gilbert Assaf

Re: Review Request 130226: CHM Generator Lib Update

marked as submitted. Review request for Okular. Changes --- Submitted with commit 6b27aa53fa7ba034f7808601ebdc13bbf8b0e020 by Gilbert Assaf to branch master. Repository: okular Description --- This patch updates our copy of the chm lib from kchmviewer. The lib files itself

[okular] [Bug 288042] Option to reset forms (PDF)

https://bugs.kde.org/show_bug.cgi?id=288042 Gilbert Assaf <gas...@gmx.de> changed: What|Removed |Added CC||gas...@gmx.de --- Comm

Re: Review Request 130226: CHM Generator Lib Update

/lib/libchmtocimage.h c0d98b3ba27596a731fd0ab24386578f6c58fdf8 generators/chm/lib/libchmtocimage.cpp 2952e8604d8c01360eace2826bbf5dc428155ff1 Diff: https://git.reviewboard.kde.org/r/130226/diff/ Testing --- Thanks, Gilbert Assaf

Re: Review Request 130226: CHM Generator Lib Update

> On Aug. 16, 2017, 9:58 p.m., Albert Astals Cid wrote: > > What do they use instead of khtml? Some other html renderer? > > Gilbert Assaf wrote: > QtWebKit > > Albert Astals Cid wrote: > Do we want to use that? Or do maybe as a second step? I.e. this first

Re: Review Request 130226: CHM Generator Lib Update

it: https://git.reviewboard.kde.org/r/130226/#review103610 --- On Aug. 16, 2017, 12:54 nachm., Gilbert Assaf wrote: > > --- > This is an automatically generated e-mail. To rep

Review Request 130226: CHM Generator Lib Update

/libchmtocimage.cpp 2952e8604d8c01360eace2826bbf5dc428155ff1 Diff: https://git.reviewboard.kde.org/r/130226/diff/ Testing --- Thanks, Gilbert Assaf

Re: Review Request 130187: CHMGenerator code modernization

/ Thanks, Gilbert Assaf

Re: Review Request 130187: CHMGenerator code modernization

> > much kchmviewer code has changed and if it makes sense updating our "copy". > > > > What do you think? > > Gilbert Assaf wrote: > Sounds reasonable. I will look into this. kchmviewer did a rewrite of those classes a few years ago. I suggest we use their curre

Re: Review Request 130187: CHMGenerator code modernization

ly, visit: https://git.reviewboard.kde.org/r/130187/#review103466 ------- On July 20, 2017, 2:40 p.m., Gilbert Assaf wrote: > > --- > This is an automatically gen

[okular] [Bug 377024] Add "expand all" to the Review View

https://bugs.kde.org/show_bug.cgi?id=377024 Gilbert Assaf <gas...@gmx.de> changed: What|Removed |Added CC||gas...@gmx.de --- Comm

Review Request 130187: CHMGenerator code modernization

2952e8604d8c01360eace2826bbf5dc428155ff1 Diff: https://git.reviewboard.kde.org/r/130187/diff/ Testing --- With clang4.0 some work was done with clang-tidy: https://www.kdab.com/clang-tidy-part-1-modernize-source-code-using-c11c14/ Thanks, Gilbert Assaf

Re: Review Request 130057: Bug 288042 - Option to reset forms

--- Thanks, Gilbert Assaf

Re: Review Request 130057: Bug 288042 - Option to reset forms

visit: https://git.reviewboard.kde.org/r/130057/#review103403 --- On March 30, 2017, 7 p.m., Gilbert Assaf wrote: > > --- > This is an automatically generated e-mail. To r

[okular] [Bug 262265] crashes with chm (text encoding by LCID)

https://bugs.kde.org/show_bug.cgi?id=262265 Gilbert Assaf <gas...@gmx.de> changed: What|Removed |Added Latest Commit||https://commits.kde.o

[okular] [Bug 236688] Make use of table of contents data to improve page ordering in CHM files

https://bugs.kde.org/show_bug.cgi?id=236688 Gilbert Assaf <gas...@gmx.de> changed: What|Removed |Added Latest Commit||https://commits.kde.o

[okular] [Bug 236688] Make use of table of contents data to improve page ordering in CHM files

https://bugs.kde.org/show_bug.cgi?id=236688 Gilbert Assaf <gas...@gmx.de> changed: What|Removed |Added Resolution|--- |FIXED

[okular] [Bug 164198] CHM: zooming does not change the font size

https://bugs.kde.org/show_bug.cgi?id=164198 Gilbert Assaf <gas...@gmx.de> changed: What|Removed |Added Resolution|--- |FIXED

Re: Review Request 130106: Bug 262265 chmlib should not send qFatal if encoding could not be guessed

utomatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130106/#review103255 --- On Mai 31, 2017, 11:03 vorm., Gilbert Assaf wrote: > > --- > This is an

Re: Review Request 130078: Bug 236688 - Sort pages according to TOC in CHM Files

/130078/diff/ Testing --- I created a small example chm file to test this. I can provide the file, if someone would like to have it. Thanks, Gilbert Assaf

Re: Review Request 130106: Bug 262265 chmlib should not send qFatal if encoding could not be guessed

in this instance. Diffs - generators/chm/lib/libchmfileimpl.cpp 3ae4e98ddf8876a996a34ab710ffa0ab71f52cde Diff: https://git.reviewboard.kde.org/r/130106/diff/ Testing --- Thanks, Gilbert Assaf

Re: Review Request 130113: kio_msits emits mimetype again

0a53e0c9d78373155cd0a0efb7fa667e62fb7e32 Diff: https://git.reviewboard.kde.org/r/130113/diff/ Testing --- Thanks, Gilbert Assaf

Re: Review Request 130113: kio_msits emits mimetype again

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130113/#review103253 --- Ship it! Ship It! - Gilbert Assaf On May 3, 2017, 1

[okular] [Bug 377718] Can you kindly improve support for such CHM file like this ?

https://bugs.kde.org/show_bug.cgi?id=377718 --- Comment #5 from Gilbert Assaf <gas...@gmx.de> --- I have downloaded the file! Thank you very much! -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 377718] Can you kindly improve support for such CHM file like this ?

https://bugs.kde.org/show_bug.cgi?id=377718 Gilbert Assaf <gas...@gmx.de> changed: What|Removed |Added CC||gas...@gmx.de --- Comm

Re: Review Request 130078: Bug 236688 - Sort pages according to TOC in CHM Files

it: https://git.reviewboard.kde.org/r/130078/#review103234 --- On April 26, 2017, 1:40 nachm., Gilbert Assaf wrote: > > --- > This is an automatically generated e-mail. To rep

Review Request 130127: CHM: zooming changes the font size

0edaf87743062476aa12c31947a7d7c147b1e014 generators/chm/generator_chm.cpp 871df9abc24b981b684fa3cb9d9568593fab2e48 Diff: https://git.reviewboard.kde.org/r/130127/diff/ Testing --- Thanks, Gilbert Assaf

[okular] [Bug 377454] Please add ability to "edit outlines (contents)"

https://bugs.kde.org/show_bug.cgi?id=377454 Gilbert Assaf <gas...@gmx.de> changed: What|Removed |Added CC||gas...@gmx.de --- Comm

Review Request 130113: kio_msits emits mimetype again

, Gilbert Assaf

Re: Review Request 130078: Bug 236688 - Sort pages according to TOC in CHM Files

871df9abc24b981b684fa3cb9d9568593fab2e48 Diff: https://git.reviewboard.kde.org/r/130078/diff/ Testing --- I created a small example chm file to test this. I can provide the file, if someone would like to have it. Thanks, Gilbert Assaf

Review Request 130106: Bug 262265 chmlib should not send qFatal if encoding could not be guessed

3ae4e98ddf8876a996a34ab710ffa0ab71f52cde Diff: https://git.reviewboard.kde.org/r/130106/diff/ Testing --- Thanks, Gilbert Assaf

[okular] [Bug 262265] crashes with chm (text encoding by LCID)

https://bugs.kde.org/show_bug.cgi?id=262265 Gilbert Assaf <gas...@gmx.de> changed: What|Removed |Added CC||gas...@gmx.de --- Comm

Re: PDFium plugin

.   On the upside: It has _javascript_ support and sometimes renders things "better" than poppler. But I don't think switching to pdfium is a good idea for Okular in the near future.     Gesendet: Samstag, 21. Januar 2017 um 15:44 Uhr Von: "Gilbert Assaf" <gas...@gmx.de> An: okular

Re: Review Request 130078: Bug 236688 - Sort pages according to TOC in CHM Files

it: https://git.reviewboard.kde.org/r/130078/#review103032 --- On April 18, 2017, 2:09 p.m., Gilbert Assaf wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 130078: Bug 236688 - Sort pages according to TOC in CHM Files

871df9abc24b981b684fa3cb9d9568593fab2e48 Diff: https://git.reviewboard.kde.org/r/130078/diff/ Testing --- I created a small example chm file to test this. I can provide the file, if someone would like to have it. Thanks, Gilbert Assaf

Review Request 130078: Bug 236688 - Sort pages according to TOC in CHM Files

- Diff: https://git.reviewboard.kde.org/r/130078/diff/ Testing (updated) --- I created a small example chm file to test this. I can provide the file, if someone would like to have it. Thanks, Gilbert Assaf

[okular] [Bug 370949] PDF bookmarks off by one

https://bugs.kde.org/show_bug.cgi?id=370949 Gilbert Assaf <gas...@gmx.de> changed: What|Removed |Added CC||gas...@gmx.de --- Comm

Re: Review Request 130057: Bug 288042 - Option to reset forms

a57712ca235b2ca629f5739ad73488d513416d0c Diff: https://git.reviewboard.kde.org/r/130057/diff/ Testing --- Thanks, Gilbert Assaf

Review Request 130057: Bug 288042 - Option to reset forms

43b03b0f677781cb92402e8291335424da210b65 ui/pageview.cpp 88ffe62418f3b68ca8c2314c54f13226d2ed6191 ui/pageviewutils.h ca8bd78a4d78cb2e779b5b682c66fa60bcb3af80 ui/pageviewutils.cpp a57712ca235b2ca629f5739ad73488d513416d0c Diff: https://git.reviewboard.kde.org/r/130057/diff/ Testing --- Thanks, Gilbert Assaf

Re: Review Request 129999: Allow to create bookmarks from the TOC

marked as submitted. Review request for Okular. Changes --- Submitted with commit a2aceadc13ea4917dff2c58f470dd6eb8bc2cf53 by Albert Astals Cid on behalf of Gilbert Assaf to branch Applications/17.04. Bugs: 190203 http://bugs.kde.org/show_bug.cgi?id=190203 Repository: okular

Re: Review Request 129999: Allow to create bookmarks from the TOC

is automatically used. Otherwise the behavior stays unchanged. Diffs (updated) - part.h f4c50ab part.cpp 198197a ui/toc.h 5e7fe2a ui/toc.cpp a205ad1 Diff: https://git.reviewboard.kde.org/r/12/diff/ Testing --- Thanks, Gilbert Assaf

Review Request 129999: Allow to create bookmarks from the TOC

5e7fe2a39ee5245379844fa0392a628a6e7f5c78 ui/toc.cpp a205ad1c577b81e9059620d03ffd86bab033813c Diff: https://git.reviewboard.kde.org/r/12/diff/ Testing --- Thanks, Gilbert Assaf

[okular] [Bug 353302] Txt Backend does not display Arabic text

https://bugs.kde.org/show_bug.cgi?id=353302 Gilbert Assaf <gas...@gmx.de> changed: What|Removed |Added CC||gas...@gmx.de --- Comm

Re: PDFium plugin

pdfium plugin...   Gesendet: Mittwoch, 18. Januar 2017 um 08:02 Uhr Von: "Jonathan Schultz" <jonat...@imatix.com> An: "Okular development" <okular-devel@kde.org>, "Gilbert Assaf" <gas...@gmx.de> Betreff: Re: PDFium plugin Please excuse the sil

PDFium plugin

Hi all,   I worked on an okular pdf plugin using pdfium as a backend. At this point it is little more than a “proof-of-concept”. But you can already view simple pdf files.   I would like to get some feedback on this: maybe somebody else is already working on an okular pdfium plugin? I am