[Okular-devel] Delete branch gsoc2013

2013-10-21 Thread Jaydeep Solanki
Hi, Please delete branch 'gsoc2013'. Also send me a confirmation, so that I can push it again. Cheers, Jaydeep ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Mentorship at Google Code-In

2013-10-17 Thread Jaydeep Solanki
On Thu, Oct 17, 2013 at 2:47 AM, Albert Astals Cid aa...@kde.org wrote: El Dijous, 17 d'octubre de 2013, a les 02:27:27, Jaydeep Solanki va escriure: Hi, Hi I would like to know if anyone of you is going to be a mentor for Google Code-In. I'm not planning to get involved. Also

[Okular-devel] Mentorship at Google Code-In

2013-10-16 Thread Jaydeep Solanki
Hi, I would like to know if anyone of you is going to be a mentor for Google Code-In. Also, can I be a mentor ? I was a GSoC 2013 student under KDE, Okular. Cheers, Jaydeep ___ Okular-devel mailing list Okular-devel@kde.org

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

2013-09-26 Thread Jaydeep Solanki
On Sept. 26, 2013, 2:10 a.m., Albert Astals Cid wrote: I'm again confused, isn't the idea that we respect the colors specified on the file? Or not? Jaydeep, what's the final decision we took? Christoph Feck wrote: Albert, the issue is that some documents do not indicate text color,

Re: [Okular-devel] Review Request 109364: Get background color from KColorScheme (kde system settings)

2013-09-26 Thread Jaydeep Solanki
On July 21, 2013, 9:07 p.m., Albert Astals Cid wrote: Jaydeep, can you confirm you are working so that http://bugs.kde.org/attachment.cgi?id=51488 can be correctly seen in a dark colorscheme? Jaydeep Solanki wrote: I tried it, with color scheme Krita-darker (background colors

Re: [Okular-devel] TextDocument Multithreading

2013-09-26 Thread Jaydeep Solanki
, Jaydeep Solanki jayd...@gmail.com wrote: On Wed, Sep 25, 2013 at 11:40 PM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 25 de setembre de 2013, a les 23:19:11, Jaydeep Solanki va escriure: On Wed, Sep 25, 2013 at 11:01 PM, Jaydeep Solanki jayd...@gmail.com wrote: Running it under

Re: [Okular-devel] TextDocument Multithreading

2013-09-26 Thread Jaydeep Solanki
On Thu, Sep 26, 2013 at 11:50 PM, Jaydeep Solanki jayd...@gmail.com wrote: I have created a small project, uploaded to g...@git.kde.org: scratch/jsolanki/TxtDocumentTest01 may be u'll get a permission denied error when configuring, *fix :* either run cmake as root or change the install_prefix

Re: [Okular-devel] List of bugs / features finished during GSoC

2013-09-25 Thread Jaydeep Solanki
Done! On Wed, Sep 25, 2013 at 4:37 AM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 24 de setembre de 2013, a les 18:28:09, Jaydeep Solanki va escriure: On Tue, Sep 24, 2013 at 2:08 AM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 24 de setembre de 2013, a les 01:44:35

Re: [Okular-devel] TextDocument Multithreading

2013-09-25 Thread Jaydeep Solanki
the warning is trying to say. What is a 'conflict on previous write' ? On Mon, Sep 23, 2013 at 1:40 PM, Jaydeep Solanki jayd...@gmail.com wrote: On Mon, Sep 23, 2013 at 3:17 AM, Albert Astals Cid aa...@kde.org wrote: El Dilluns, 23 de setembre de 2013, a les 02:05:23, Jaydeep Solanki va

Re: [Okular-devel] TextDocument Multithreading

2013-09-25 Thread Jaydeep Solanki
On Wed, Sep 25, 2013 at 11:01 PM, Jaydeep Solanki jayd...@gmail.com wrote: Running it under helgrind, gives thishttps://www.dropbox.com/s/5v3bh1v6le8adkr/helg.txtoutput. It shows a warning near the region where we get a crash saying *conflicts with a previous write of size 4 by thread #4

Re: [Okular-devel] TextDocument Multithreading

2013-09-25 Thread Jaydeep Solanki
On Wed, Sep 25, 2013 at 11:40 PM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 25 de setembre de 2013, a les 23:19:11, Jaydeep Solanki va escriure: On Wed, Sep 25, 2013 at 11:01 PM, Jaydeep Solanki jayd...@gmail.com wrote: Running it under helgrind, gives thishttps

Re: [Okular-devel] List of bugs / features finished during GSoC

2013-09-24 Thread Jaydeep Solanki
On Tue, Sep 24, 2013 at 2:08 AM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 24 de setembre de 2013, a les 01:44:35, Jaydeep Solanki va escriure: Hi, Here's a link https://www.dropbox.com/s/wl8yobpk6oc6i79/GSoC%20patches.pdfto a file showing all the bug fixes and features

Re: [Okular-devel] TextDocument Multithreading

2013-09-23 Thread Jaydeep Solanki
On Mon, Sep 23, 2013 at 3:17 AM, Albert Astals Cid aa...@kde.org wrote: El Dilluns, 23 de setembre de 2013, a les 02:05:23, Jaydeep Solanki va escriure: On Sun, Sep 22, 2013 at 9:21 PM, Albert Astals Cid aa...@kde.org wrote: El Dissabte, 21 de setembre de 2013, a les 23:16:56, Jaydeep

[Okular-devel] List of bugs / features finished during GSoC

2013-09-23 Thread Jaydeep Solanki
Hi, Here's a link https://www.dropbox.com/s/wl8yobpk6oc6i79/GSoC%20patches.pdfto a file showing all the bug fixes and features implemented by me during GSoC. P.S. I have ignored small and tiny commits. Had a great time! More importantly learned a lot, and all the credit goes to Albert. :)

Re: [Okular-devel] TextDocument Multithreading

2013-09-22 Thread Jaydeep Solanki
On Sun, Sep 22, 2013 at 9:21 PM, Albert Astals Cid aa...@kde.org wrote: El Dissabte, 21 de setembre de 2013, a les 23:16:56, Jaydeep Solanki va escriure: On Sat, Sep 21, 2013 at 9:25 PM, Albert Astals Cid aa...@kde.org wrote: El Dissabte, 21 de setembre de 2013, a les 14:50:50, Jaydeep

[Okular-devel] TextDocument Multithreading

2013-09-21 Thread Jaydeep Solanki
Hi, @Albert, Welcome back :) As you might be aware GSoC is coming to an end, I want to wrap things up. I have a few days, and I want to finish multi-threading support for ePubs before GSoC ends. I have created a patch, but it crashes sometimes, I'm unable to find a reason to that. So, can we

Re: [Okular-devel] TextDocument Multithreading

2013-09-21 Thread Jaydeep Solanki
On Sat, Sep 21, 2013 at 9:25 PM, Albert Astals Cid aa...@kde.org wrote: El Dissabte, 21 de setembre de 2013, a les 14:50:50, Jaydeep Solanki va escriure: Hi, Hi @Albert, Welcome back :) Thanks :-) As you might be aware GSoC is coming to an end, I want to wrap things up. I

[Okular-devel] Test embedded audio - Epub

2013-09-12 Thread Jaydeep Solanki
Hi, Anyone interested in testing patch related to epub containing embedded audio ? Cheers, Jaydeep ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Epub video support - done!

2013-09-07 Thread Jaydeep Solanki
Hi, As you all might be knowing, I was struggling a lot to make this happen, it has come to an end. It's working fine with me. But during this process, I removed a line of code, which I didn't understand and without it everything's working fine. Just to make sure I don't break anything after

[Okular-devel] Struggling with Annotations

2013-09-03 Thread Jaydeep Solanki
Hi, Guys, as Albert (who was a great helping hand to me) is away, it would be great if you all can fill in :) Problem : Unable to position video widget. Here's what we know till now : - As epubs use TextDocuments, in core/textdocumentgenerator.cpp there's a signal named

[Okular-devel] Patch test

2013-08-30 Thread Jaydeep Solanki
Hello, I'm working to get videos working in epubs, and I'm not sure if it's my Phonon Gstreamer backend that's causing problem or what. So if someone can help me test my patch it would be great. I have attached the patch, use branch 'epub-qtextdocument', and here's the link

Re: [Okular-devel] Dt. 28th August - status

2013-08-29 Thread Jaydeep Solanki
On Thu, Aug 29, 2013 at 2:41 AM, Fabio D'Urso fabiodu...@hotmail.it wrote: On Thursday, August 29, 2013 01:23:48 AM Jaydeep Solanki wrote: On Wed, Aug 28, 2013 at 2:00 AM, Jaydeep Solanki jayd...@gmail.com wrote: Hi, I noticed that the (movie) annotation version actually works, it's

Re: [Okular-devel] Dt. 28th August - status

2013-08-28 Thread Jaydeep Solanki
On Wed, Aug 28, 2013 at 2:00 AM, Jaydeep Solanki jayd...@gmail.com wrote: Hi, I noticed that the (movie) annotation version actually works, it's just that it takes a few seconds to start. Current status is I can hear the video playing but no visual. I have visual now, working on playing

[Okular-devel] Dt. 28th August - status

2013-08-27 Thread Jaydeep Solanki
Hi, I noticed that the (movie) annotation version actually works, it's just that it takes a few seconds to start. Current status is I can hear the video playing but no visual. To debug this, I turned off a lot of features like drawingContent (because the video player is not drawn using

Re: [Okular-devel] Multimedia annotations / actions - Dt. 24th August 2013

2013-08-24 Thread Jaydeep Solanki
On Sat, Aug 24, 2013 at 3:01 AM, Albert Astals Cid aa...@kde.org wrote: El Dissabte, 24 d'agost de 2013, a les 00:27:34, Jaydeep Solanki va escriure: Hi, I still have two more exams left, on Monday Tuesday, but I can work on weekend. In the effort to make ePubs view video and play

Re: [Okular-devel] Receiving emails from build.kde.org on build failures

2013-08-24 Thread Jaydeep Solanki
I think it's great, it's definitely better to know if your commit broke something. There might be many people like me who don't build tests, unless it is necessary. ;) On Sat, Aug 24, 2013 at 5:24 PM, Albert Astals Cid aa...@kde.org wrote: Hi guys, what do you think about build.kde.org

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

2013-08-20 Thread Jaydeep Solanki
work.) Jaydeep Solanki wrote: For sure, you patch addresses a bigger issue by fixing this for all generators that use TextDocumentGenerator. I'd be happy to remove my patch for this patch, but I'm still not finding the links in blue color. Albert can you please confirm

Re: [Okular-devel] Dt. 9th August - status

2013-08-17 Thread Jaydeep Solanki
On Sat, Aug 17, 2013 at 2:06 AM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 16 d'agost de 2013, a les 22:29:38, Jaydeep Solanki va escriure: How it occurs : 1) Open an ePub 2) As soon as it opens, hold Right arrow key, till it reaches the end of document or crashes

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

2013-08-17 Thread Jaydeep Solanki
On Aug. 17, 2013, 2:28 a.m., Albert Astals Cid wrote: To be honest i'm a bit confused by all the different patches trying to fix the same thing, there's this one, the other one that tries to use kcolorscheme, the other one that tries to let the user choose. And what I don't

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

2013-08-17 Thread Jaydeep Solanki
work.) Jaydeep Solanki wrote: For sure, you patch addresses a bigger issue by fixing this for all generators that use TextDocumentGenerator. I'd be happy to remove my patch for this patch, but I'm still not finding the links in blue color. Albert can you please confirm

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

2013-08-17 Thread Jaydeep Solanki
/r/111681/#comment28138 This isn't necessary, after clicking a link, the images aren't going to update. So, if it is never going to be displayed, it's better not to write it. - Jaydeep Solanki On Aug. 17, 2013, 2:28 a.m., Christoph Feck wrote

Re: [Okular-devel] Dt. 9th August - status

2013-08-16 Thread Jaydeep Solanki
is very low, thus it gets difficult to debug. On Tue, Aug 13, 2013 at 3:17 AM, Albert Astals Cid aa...@kde.org wrote: El Dissabte, 10 d'agost de 2013, a les 01:19:14, Jaydeep Solanki va escriure: Hi, I have tested yesterday's patch (without lock) with about 15 different epubs, and it crashed

[Okular-devel] Dt. 14th August - status

2013-08-14 Thread Jaydeep Solanki
Hi, I talked with qt guys, one thing I found out is no more features will be added to 4.8, so the visibility patch will be added to qt5. May be it will be helpful when KDE Frameworks 5 will release and Okular will be using qt5. Secondly, I'm trying to implement something that will let users play

Re: [Okular-devel] Dt. 12th August - status

2013-08-13 Thread Jaydeep Solanki
On Tue, Aug 13, 2013 at 3:46 AM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 13 d'agost de 2013, a les 00:27:48, Jaydeep Solanki va escriure: Hi, Setup gerrit and created review request, for visibility : collapse. https://codereview.qt-project.org/#change,62839 Nice :-) I'll

[Okular-devel] Dt. 12th August - status

2013-08-12 Thread Jaydeep Solanki
Hi, Setup gerrit and created review request, for visibility : collapse. https://codereview.qt-project.org/#change,62839 I'll be working on updating it as and when I get more info. I'm kind of free besides it, so I was thinking to start with MathML. I saw a few libs but mostly available in

[Okular-devel] Dt. 10th August - status

2013-08-10 Thread Jaydeep Solanki
Hi, I talked with Konstantin Ritt (irc nick : rittk) on #qt-labs, he told me to submit a review request for the changes that I have done till now. I'll submit a review request soon, because I have a read only copy of Qt, and cloning it again from my home connection will take ages. I tried

[Okular-devel] Dt. 9th August - status

2013-08-09 Thread Jaydeep Solanki
Hi, I have tested yesterday's patch (without lock) with about 15 different epubs, and it crashed only once. I tried the same epub that made it crash once a few more times, but it didn't crash. Thus, crash doesn't depend on the epub. I observed a few things, it crashes only when I'm scrolling the

[Okular-devel] Dt. 8th August - status

2013-08-08 Thread Jaydeep Solanki
Hi, Finally an end to cloning and threading issue. Diff attached. I have kept QElapsedTimer, just in case you if you want to check performance. I'll remove it and qDebug() when pushing it. *A possible improvement:* While a non UI thread is creating a cloned object using

Re: [Okular-devel] Dt. 8th August - status

2013-08-08 Thread Jaydeep Solanki
forgot to attach On Fri, Aug 9, 2013 at 1:07 AM, Jaydeep Solanki jayd...@gmail.com wrote: Hi, Finally an end to cloning and threading issue. Diff attached. I have kept QElapsedTimer, just in case you if you want to check performance. I'll remove it and qDebug() when pushing

Re: [Okular-devel] Dt. 6th August - status

2013-08-08 Thread Jaydeep Solanki
On Thu, Aug 8, 2013 at 2:25 AM, Albert Astals Cid aa...@kde.org wrote: El Dijous, 8 d'agost de 2013, a les 01:36:12, Jaydeep Solanki va escriure: On Thu, Aug 8, 2013 at 1:21 AM, Albert Astals Cid aa...@kde.org wrote: El Dijous, 8 d'agost de 2013, a les 01:09:27, Jaydeep Solanki va escriure

Re: [Okular-devel] Dt. 8th August - status

2013-08-08 Thread Jaydeep Solanki
On Fri, Aug 9, 2013 at 1:31 AM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 9 d'agost de 2013, a les 01:09:18, Jaydeep Solanki va escriure: forgot to attach Can you explain your locking, not sure i understand it. QMutexLocker will lock the mutex in its constructor and unlock

Re: [Okular-devel] Dt. 6th August - status

2013-08-08 Thread Jaydeep Solanki
yes it won't wait On Fri, Aug 9, 2013 at 1:33 AM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 9 d'agost de 2013, a les 01:11:25, Jaydeep Solanki va escriure: On Thu, Aug 8, 2013 at 2:25 AM, Albert Astals Cid aa...@kde.org wrote: El Dijous, 8 d'agost de 2013, a les 01:36:12

Re: [Okular-devel] Dt. 6th August - status

2013-08-08 Thread Jaydeep Solanki
On Fri, Aug 9, 2013 at 1:44 AM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 9 d'agost de 2013, a les 01:36:18, Jaydeep Solanki va escriure: yes it won't wait So the UI thread won't block, right? Because you said it would. yes, if there are two QTextDocuments one used in UI thread

Re: [Okular-devel] Dt. 6th August - status

2013-08-07 Thread Jaydeep Solanki
a document and open another document images displayed are of the previous document. On Wed, Aug 7, 2013 at 6:11 AM, Fabio D'Urso fabiodu...@hotmail.it wrote: Hi, On Wednesday, August 07, 2013 12:31:41 AM Albert Astals Cid wrote: El Dimarts, 6 d'agost de 2013, a les 20:52:25, Jaydeep Solanki va

Re: [Okular-devel] Dt. 6th August - status

2013-08-07 Thread Jaydeep Solanki
dependency, then ? Those were the two I can think of. On Thu, Aug 8, 2013 at 12:57 AM, Albert Astals Cid aa...@kde.org wrote: El Dijous, 8 d'agost de 2013, a les 00:37:42, Jaydeep Solanki va escriure: I tried a lot of approaches for TextDocument threading and finally I settled to a really

Re: [Okular-devel] Dt. 6th August - status

2013-08-07 Thread Jaydeep Solanki
On Thu, Aug 8, 2013 at 1:21 AM, Albert Astals Cid aa...@kde.org wrote: El Dijous, 8 d'agost de 2013, a les 01:09:27, Jaydeep Solanki va escriure: Yes I know I have not took care of it here, I just wanted to show you the approach. And I still have no clue on how to delete the static object

[Okular-devel] Dt. 6th August - status

2013-08-06 Thread Jaydeep Solanki
Hi, I have implemented a simple Qt Visibility support, which hides text, it's doesn't hide the exact area of the text, because the way QTextDocument is developed it is impossible to implement an approach that hides only a part of line. Either we can hide a line or not hide it. And implementing an

Re: [Okular-devel] Dt. 4th August - status

2013-08-05 Thread Jaydeep Solanki
On Mon, Aug 5, 2013 at 12:25 AM, Albert Astals Cid aa...@kde.org wrote: El Diumenge, 4 d'agost de 2013, a les 23:31:02, Jaydeep Solanki va escriure: Hi, Regarding the TextDocument threaded rendering issue, I implemented a clone method to return an EpubDocument. QTextDocument::clone

[Okular-devel] Dt. 4th August - status

2013-08-04 Thread Jaydeep Solanki
Hi, Regarding the TextDocument threaded rendering issue, I implemented a clone method to return an EpubDocument. QTextDocument::clone() is not a virtual method, so either we'll have to make it virtual or change the signature of clone method in EpubDocument. I made QTextDocument::clone() virtual.

Re: [Okular-devel] Dt. 4th August - status

2013-08-04 Thread Jaydeep Solanki
And for the comparisons, I have Intel i5-2430M Processorhttp://ark.intel.com/products/53450 On Sun, Aug 4, 2013 at 11:31 PM, Jaydeep Solanki jayd...@gmail.com wrote: Hi, Regarding the TextDocument threaded rendering issue, I implemented a clone method to return an EpubDocument

[Okular-devel] Dt. 3rd August - status

2013-08-03 Thread Jaydeep Solanki
Hi, So, today we found out TextDocument threaded rendering is not ready. I'll submit a patch tomorrow. I'm still working on getting the text unselectable. What I'm trying to do is somehow get the cursor to increment and not insert the text. If it can be done, it will be the best solution. Lack

Re: [Okular-devel] Dt. 29th July - status

2013-08-02 Thread Jaydeep Solanki
On Fri, Aug 2, 2013 at 2:24 AM, Albert Astals Cid aa...@kde.org wrote: El Dijous, 1 d'agost de 2013, a les 23:04:23, Jaydeep Solanki va escriure: On Thu, Aug 1, 2013 at 1:49 AM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 31 de juliol de 2013, a les 23:32:46, Jaydeep Solanki va

Re: [Okular-devel] Dt. 29th July - status

2013-08-02 Thread Jaydeep Solanki
Let's meet on #okular, tomorrow (3rd August) around 7pm european time. On Fri, Aug 2, 2013 at 11:57 AM, Jaydeep Solanki jayd...@gmail.com wrote: On Fri, Aug 2, 2013 at 2:24 AM, Albert Astals Cid aa...@kde.org wrote: El Dijous, 1 d'agost de 2013, a les 23:04:23, Jaydeep Solanki va escriure

[Okular-devel] Dt. 2nd August - status

2013-08-02 Thread Jaydeep Solanki
Hi, Collapse support is done. For hidden visibility, I think I'm going to need some time, may be a day, the main reason being I'm not aware with QTextCursor code, for hiding text it is needed. Cheers, Jaydeep ___ Okular-devel mailing list

Re: [Okular-devel] Dt. 29th July - status

2013-08-01 Thread Jaydeep Solanki
On Thu, Aug 1, 2013 at 1:49 AM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 31 de juliol de 2013, a les 23:32:46, Jaydeep Solanki va escriure: On Wed, Jul 31, 2013 at 3:13 AM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 30 de juliol de 2013, a les 11:19:45, Jaydeep Solanki

Re: [Okular-devel] Dt. 29th July - status

2013-07-31 Thread Jaydeep Solanki
On Wed, Jul 31, 2013 at 3:13 AM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 30 de juliol de 2013, a les 11:19:45, Jaydeep Solanki va escriure: On Tue, Jul 30, 2013 at 1:41 AM, Albert Astals Cid aa...@kde.org wrote: El Dilluns, 29 de juliol de 2013, a les 23:57:38, Jaydeep Solanki

[Okular-devel] Dt. 31th July - status

2013-07-31 Thread Jaydeep Solanki
Hi, Today, gui/text/QCssParser made some sense to me. So, I tried to take a small step, make it detect visibility property in css. I made some changes, but found it doesn't work. I met a person on #qt-labs who was familiar with QCssParser, but the time I finished making changes he was gone. I'm

[Okular-devel] Dt. 30th July - status

2013-07-30 Thread Jaydeep Solanki
Hi, I'm reading and reading and reading the source, if I get something useful, I try it out. I have got a rough idea about what they are doing and what I have to do. But I guess it will take me some time to get it working. I have started modifying the source, but I'm just at the beginning.

Re: [Okular-devel] Dt. 30th July - status

2013-07-30 Thread Jaydeep Solanki
QCssParser On Wed, Jul 31, 2013 at 2:56 AM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 31 de juliol de 2013, a les 00:42:07, Jaydeep Solanki va escriure: Hi, I'm reading and reading and reading the source, if I get something useful, I try it out. I have got a rough idea

Re: [Okular-devel] Dt. 30th July - status

2013-07-30 Thread Jaydeep Solanki
And ya, I have submitted the Midterm Evaluation On Wed, Jul 31, 2013 at 7:51 AM, Jaydeep Solanki jayd...@gmail.com wrote: QCssParser On Wed, Jul 31, 2013 at 2:56 AM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 31 de juliol de 2013, a les 00:42:07, Jaydeep Solanki va escriure

Re: [Okular-devel] Dt. 30th July - status

2013-07-30 Thread Jaydeep Solanki
QCssParser from the files you sent me. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Dt. 29th July - status

2013-07-29 Thread Jaydeep Solanki
Hi, As compared to other days, I didn't do much today. But found some really interesting facts about our image not loading problem. I know it's not possible but some how the override is not called instead the default implementation is called, I found out this by placing the images next to the

Re: [Okular-devel] Dt. 29th July - status

2013-07-29 Thread Jaydeep Solanki
On Tue, Jul 30, 2013 at 1:41 AM, Albert Astals Cid aa...@kde.org wrote: El Dilluns, 29 de juliol de 2013, a les 23:57:38, Jaydeep Solanki va escriure: Hi, As compared to other days, I didn't do much today. But found some really interesting facts about our image not loading problem. I

[Okular-devel] Dt. 28th July - status

2013-07-28 Thread Jaydeep Solanki
Hi, All the bugs reported on bugs.kde.org related to epub backend, have been fixed (except 1 that says elements with visibility:none also show up in epubs, the reason for it is quite obvious, QTextdocument doesn't support visibility), so today I thought to give other bugs a shot. Since long I

[Okular-devel] Dt. 27th July - status

2013-07-27 Thread Jaydeep Solanki
Hi, As we were discussing about the two files mentioned in Bug 318485, not displaying images, there's really something strange with it. I tried loading that epub without its CSS, nothing changed. I copy-pasted the html from the epub to QTextDocument::setHtml() in converter.cpp, still not loading

[Okular-devel] Dt. 26th July - status

2013-07-26 Thread Jaydeep Solanki
Hi, Yesterday while I was testing for Bug 318485, I found that both the files mentioned there have a small bug ( they fail to load images ). I'm facing this issue with only those two files, for every other file it works. So today, I though to fix it first. I have been trying to find the reason

Re: [Okular-devel] Dt. 26th July - status

2013-07-26 Thread Jaydeep Solanki
On Fri, Jul 26, 2013 at 11:20 PM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 26 de juliol de 2013, a les 21:58:43, Jaydeep Solanki va escriure: Hi, Yesterday while I was testing for Bug 318485, I found that both the files mentioned there have a small bug ( they fail to load

Re: [Okular-devel] Dt. 26th July - status

2013-07-26 Thread Jaydeep Solanki
On Fri, Jul 26, 2013 at 11:51 PM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 26 de juliol de 2013, a les 23:31:00, Jaydeep Solanki va escriure: On Fri, Jul 26, 2013 at 11:20 PM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 26 de juliol de 2013, a les 21:58:43, Jaydeep

Re: [Okular-devel] Review Request 111554: SVG support for Epubs

2013-07-25 Thread Jaydeep Solanki
generators/epub/converter.cpp 74df151 generators/epub/epubdocument.h 714ede6 Diff: http://git.reviewboard.kde.org/r/111554/diff/ Testing --- The below link contains two epub files having svg images as cover. https://www.dropbox.com/sh/xcqfwn8khbqac0d/vDRuFRw9vq Thanks, Jaydeep Solanki

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

2013-07-25 Thread Jaydeep Solanki
this http://goo.gl/Rknh6N - Jaydeep Solanki On July 25, 2013, 4:50 p.m., Christoph Feck wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

2013-07-25 Thread Jaydeep Solanki
- Jaydeep Solanki On July 25, 2013, 5:30 p.m., Christoph Feck wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681

[Okular-devel] Dt.24th July - status

2013-07-25 Thread Jaydeep Solanki
Hi, Fixed Bug 318485 https://bugs.kde.org/show_bug.cgi?id=318485. While pushing it, sometimes I get, 403 forbidden sometimes 502 Bad Gateway. I don't know the reason. I'll try later tonight. Cheers, Jaydeep ___ Okular-devel mailing list

Re: [Okular-devel] Review Request 111640: Remove Magic Stuff from Epub Generator

2013-07-24 Thread Jaydeep Solanki
generators/epub/epubdocument.cpp ae19f8a Diff: http://git.reviewboard.kde.org/r/111640/diff/ Testing --- Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Dt. 23rd July - status

2013-07-24 Thread Jaydeep Solanki
. On Tue, Jul 23, 2013 at 11:59 PM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 23 de juliol de 2013, a les 23:07:14, Jaydeep Solanki va escriure: Hi, Hi Regarding the unreadable text issue, in dark color scheme, I thought it would be great if Okular can detect background color

Re: [Okular-devel] Review Request 109364: Get background color from KColorScheme (kde system settings)

2013-07-23 Thread Jaydeep Solanki
On July 21, 2013, 9:07 p.m., Albert Astals Cid wrote: Jaydeep, can you confirm you are working so that http://bugs.kde.org/attachment.cgi?id=51488 can be correctly seen in a dark colorscheme? Jaydeep Solanki wrote: I tried it, with color scheme Krita-darker (background colors

[Okular-devel] Dt. 23rd July - status

2013-07-23 Thread Jaydeep Solanki
Hi, Regarding the unreadable text issue, in dark color scheme, I thought it would be great if Okular can detect background color of the document set text color accordingly. So far I'm able to get the background color of the document. I use QRegExp to get the background color from CSS. By

[Okular-devel] Review Request 111640: Remove Magic Stuff from Epub Generator

2013-07-22 Thread Jaydeep Solanki
implementation. Diffs - generators/epub/converter.h 969dc9f generators/epub/converter.cpp 74df151 Diff: http://git.reviewboard.kde.org/r/111640/diff/ Testing --- Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel

Re: [Okular-devel] Review Request 111554: SVG support for Epubs

2013-07-22 Thread Jaydeep Solanki
, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 109364: Get background color from KColorScheme (kde system settings)

2013-07-21 Thread Jaydeep Solanki
/ --- (Updated July 21, 2013, 3:36 p.m.) Review request for Okular and Jaydeep Solanki. Description --- Instead of just force it to white. This must fix bug 306572. https://bugs.kde.org/show_bug.cgi?id=306572 This addresses bug 306572. http://bugs.kde.org/show_bug.cgi?id

Re: [Okular-devel] Review Request 111554: SVG support for Epubs

2013-07-19 Thread Jaydeep Solanki
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111554/#review36121 --- On July 17, 2013, 8:13 p.m., Jaydeep Solanki wrote

Re: [Okular-devel] Review Request 111554: SVG support for Epubs

2013-07-19 Thread Jaydeep Solanki
generators/epub/converter.cpp 74df151 generators/epub/epubdocument.h 714ede6 Diff: http://git.reviewboard.kde.org/r/111554/diff/ Testing --- The below link contains two epub files having svg images as cover. https://www.dropbox.com/sh/xcqfwn8khbqac0d/vDRuFRw9vq Thanks, Jaydeep Solanki

Re: [Okular-devel] Review Request 111554: SVG support for Epubs

2013-07-19 Thread Jaydeep Solanki
On July 18, 2013, 2:31 p.m., Albert Astals Cid wrote: generators/epub/converter.cpp, line 220 http://git.reviewboard.kde.org/r/111554/diff/1/?file=171295#file171295line220 Where does this 718/560 come from? Jaydeep Solanki wrote: Width of a page is 600, and as we are having

[Okular-devel] Review Request 111554: SVG support for Epubs

2013-07-17 Thread Jaydeep Solanki
: http://git.reviewboard.kde.org/r/111554/diff/ Testing --- The below link contains two epub files having svg images as cover. https://www.dropbox.com/sh/xcqfwn8khbqac0d/vDRuFRw9vq Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel

Re: [Okular-devel] SVG support for Epubs

2013-07-17 Thread Jaydeep Solanki
For your convenience, here https://git.reviewboard.kde.org/r/111554/'s a review request. On Tue, Jul 16, 2013 at 10:06 PM, Jaydeep Solanki jayd...@gmail.com wrote: Hi, I'm attaching here a patch that adds support for SVG images in Epubs. I'm sending you the patch in mail because Review

[Okular-devel] Reading TOC using 'ebook-tools'

2013-07-11 Thread Jaydeep Solanki
Hello, I guess PinoTree is the maintainer of 'ebook-tools'. I noticed that epubs with a prefix in toc.ncx don't succeed in parsing toc. In my case I have an epub which contains the following in toc.ncx: ncx:elementName / where 'ncx' is a prefix. Seeing a function named '_get_possible_namespace',

Re: [Okular-devel] Reading TOC using 'ebook-tools'

2013-07-11 Thread Jaydeep Solanki
Here's the diff file. On Thu, Jul 11, 2013 at 8:37 PM, Jaydeep Solanki jayd...@gmail.com wrote: Hello, I guess PinoTree is the maintainer of 'ebook-tools'. I noticed that epubs with a prefix in toc.ncx don't succeed in parsing toc. In my case I have an epub which contains the following

[Okular-devel] PartTest - accessing private members

2013-07-02 Thread Jaydeep Solanki
Hi, In parttest.cpp, I see that private members have been accessed. It would be nice if someone can throw a light on how is it done, because when I try to do it, it doesn't compile saying cannot access private members. Cheers, Jaydeep ___ Okular-devel

Re: [Okular-devel] Branch 'epub-qtextdoc' review

2013-06-25 Thread Jaydeep Solanki
On Tue, Jun 25, 2013 at 4:50 AM, Fabio D'Urso fabiodu...@hotmail.it wrote: On Monday, June 24, 2013 11:57:35 PM Jaydeep Solanki wrote: Hello, I have put together some of my work, in a branch named 'epub-qtextdoc'. It would be really nice if you can review it. Hi Jaydeep, I've never

Re: [Okular-devel] Branch 'epub-qtextdoc' review

2013-06-25 Thread Jaydeep Solanki
On Tue, Jun 25, 2013 at 7:39 PM, Fabio D'Urso fabiodu...@hotmail.it wrote: On Tuesday, June 25, 2013 06:32:52 PM Jaydeep Solanki wrote: On Tue, Jun 25, 2013 at 4:50 AM, Fabio D'Urso fabiodu...@hotmail.it wrote: On Monday, June 24, 2013 11:57:35 PM Jaydeep Solanki wrote: Hello, I

Re: [Okular-devel] Branch 'epub-qtextdoc' review

2013-06-25 Thread Jaydeep Solanki
On Wed, Jun 26, 2013 at 1:57 AM, Albert Astals Cid aa...@kde.org wrote: El Dilluns, 24 de juny de 2013, a les 23:57:35, Jaydeep Solanki va escriure: Hello, I have put together some of my work, in a branch named 'epub-qtextdoc'. It would be really nice if you can review it. What's

Re: [Okular-devel] Branch 'epub-qtextdoc' review

2013-06-25 Thread Jaydeep Solanki
On Wed, Jun 26, 2013 at 2:16 AM, Luigi Toscano luigi.tosc...@tiscali.itwrote: Jaydeep Solanki wrote: I don't have permission to change/delete refs. Sorry for jumping in here: in order to avoid such issue, wouldn't be better to use a personal repository (a clone repository in this case

Re: [Okular-devel] Branch 'epub-qtextdoc' review

2013-06-25 Thread Jaydeep Solanki
On Wed, Jun 26, 2013 at 1:57 AM, Albert Astals Cid aa...@kde.org wrote: El Dilluns, 24 de juny de 2013, a les 23:57:35, Jaydeep Solanki va escriure: Hello, I have put together some of my work, in a branch named 'epub-qtextdoc'. It would be really nice if you can review it. What's

Re: [Okular-devel] Branch 'epub-qtextdoc' review

2013-06-25 Thread Jaydeep Solanki
Pushed, branch name 'epub-qtextdoc'. On Wed, Jun 26, 2013 at 3:00 AM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 26 de juny de 2013, a les 02:45:31, Jaydeep Solanki va escriure: On Wed, Jun 26, 2013 at 2:32 AM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 26 de juny de

[Okular-devel] Branch 'epub-qtextdoc' review

2013-06-24 Thread Jaydeep Solanki
Hello, I have put together some of my work, in a branch named 'epub-qtextdoc'. It would be really nice if you can review it. Cheers, Jaydeep ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 111138: Make TextDocument_Generator Threaded

2013-06-23 Thread Jaydeep Solanki
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/38/#review34919 --- On June 19, 2013, 7:26 p.m., Jaydeep Solanki wrote

[Okular-devel] Review Request 111138: Make TextDocument_Generator Threaded

2013-06-19 Thread Jaydeep Solanki
drawingContent. Diffs - CMakeLists.txt 217337f core/textdocumentgenerator.cpp b260b3f Diff: http://git.reviewboard.kde.org/r/38/diff/ Testing --- Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https

Re: [Okular-devel] Epub qtextdocument high cpu usage

2013-06-17 Thread Jaydeep Solanki
On Sun, Jun 16, 2013 at 8:42 PM, Albert Astals Cid aa...@kde.org wrote: El Diumenge, 16 de juny de 2013, a les 20:29:37, Jaydeep Solanki va escriure: Hello, As I was finding it difficult to make progress using webkit to render epub, I spent some time experimenting around

Re: [Okular-devel] Epub qtextdocument high cpu usage

2013-06-17 Thread Jaydeep Solanki
On Mon, Jun 17, 2013 at 11:31 PM, Albert Astals Cid aa...@kde.org wrote: El Dilluns, 17 de juny de 2013, a les 21:42:23, Jaydeep Solanki va escriure: On Sun, Jun 16, 2013 at 8:42 PM, Albert Astals Cid aa...@kde.org wrote: El Diumenge, 16 de juny de 2013, a les 20:29:37, Jaydeep Solanki va

[Okular-devel] Epub qtextdocument high cpu usage

2013-06-16 Thread Jaydeep Solanki
Hello, As I was finding it difficult to make progress using webkit to render epub, I spent some time experimenting around with QTextDocument. A small patch is attached which fixes the issues with the body tag (eg : background color). It works fine with me, the only issue I'm facing is that it

[Okular-devel] Need sample epub

2013-06-13 Thread Jaydeep Solanki
Hello, If you have an epub with non-white background, please forward it to me. I have had some success with an epub created by me [linkhttps://dl.dropboxusercontent.com/u/81573349/firstBlue.epub ]. But I want to test it with a proper epub file. Cheers, Jaydeep

  1   2   3   >