marked as submitted.
Review request for Okular.
Changes
---
Submitted with commit 223092aa0e1fd5fd1b48a34702d2102fdb1acccf by Albert Astals
Cid on behalf of Jonathan Doman to branch Applications/15.04.
Repository: okular
Description
---
Wow, I have no idea how this happened. I
de it into release... ugh
Diffs
-
core/script/kjs_document.cpp 4422953b0e157a9b0554a949969aaf9b13f44974
part.cpp 5b03e56e194bf84a9f02ceaf94cad13526715157
Diff: https://git.reviewboard.kde.org/r/123680/diff/
Testing
---
Tabs work again.
Thanks,
Jonathan
marked as submitted.
Review request for Okular.
Changes
---
Submitted with commit 1cfb007b6339fa51c010fdd27e8de4838dadb5a5 by Albert Astals
Cid on behalf of Jonathan Doman to branch Applications/15.04.
Bugs: 335852
http://bugs.kde.org/show_bug.cgi?id=335852
Repository: okular
abled.
- Restore session config describing multible tabs, even though tabs are disabled
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
Restore session config describing multible tabs, even though tabs are disabled
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
tiple windows, tabs enabled or disabled.
- Restore session config describing multible tabs, even though tabs are disabled
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
twice.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122570/#review76430
-------
On Feb. 22, 2015, 2:54 p.m., Jonathan Doman wrote:
ibing multible tabs, even though tabs are disabled
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
think is how
KDE does it behind the scenes.
- Restore one or more documents in single window with tabs enabled.
- Restore multiple windows, tabs enabled or disabled.
- Restore session config describing multible tabs, even though tabs are disabled
Thank
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122570/#review76160
---
On Feb. 14, 2015, 8:31 p.m., Jonathan Doman wrote:
>
> -
automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122570/#review76161
---
On Feb. 14, 2015, 8:31 p.m., Jonathan Doman wrote:
>
> ---
> This is an
ingle window with tabs enabled.
- Restore multiple windows, tabs enabled or disabled.
- Restore session config describing multible tabs, even though tabs are disabled
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://bugs.kde.org/show_bug.cgi?id=335852
--- Comment #5 from Jonathan Doman ---
I'm trying to work on this bug but hitting some roadblocks due to the Part
plugin design. The Shell needs to get and set some information on each Part
(the viewport), and this can't really be done usi
ui/pageview.cpp 17e66f4a3b420bbcaf281532fa9d84379c74d48c
Diff: https://git.reviewboard.kde.org/r/120660/diff/
Testing
---
Followed steps in bug report for both tabs and windows to make sure different
tools are allowed.
Thanks,
Jonathan Doman
___
Okular-devel mail
diff/
Testing
---
Followed steps in bug report for both tabs and windows to make sure different
tools are allowed.
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
https://bugs.kde.org/show_bug.cgi?id=334251
--- Comment #6 from Jonathan Doman ---
So I tested an older version (tag v4.10.97) and this bug exists for multiple
windows as well. It's probably been around forever. And there are similar bugs
for other settings like continuous view mode. Basica
https://bugs.kde.org/show_bug.cgi?id=334251
--- Comment #3 from Jonathan Doman ---
I took some time to look at this and I'm not sure how to fix it. The problem is
that changing the mouse mode writes the global Settings, which triggers all the
Parts to reload (and potentially overwrite
code looks good to me.
- Jonathan Doman
On Aug. 3, 2014, 3 p.m., Albert Astals Cid wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
ments are
made absolute.
Diffs
-
shell/main.cpp d2e0ec72fd43b560d25ac7f903462641cdbbff51
Diff: https://git.reviewboard.kde.org/r/119550/diff/
Testing
---
Tested steps described in bug report.
Thanks,
Jonathan Doman
___
Okular-
Testing
---
Tested steps described in bug report.
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
https://bugs.kde.org/show_bug.cgi?id=334510
--- Comment #3 from Jonathan Doman ---
Thanks for the tip, Willem. The patch is posted.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel
shell/main.cpp d2e0ec72fd43b560d25ac7f903462641cdbbff51
Diff: https://git.reviewboard.kde.org/r/119550/diff/
Testing
---
Tested steps described in bug report.
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kd
bff51
Diff: https://git.reviewboard.kde.org/r/119550/diff/
Testing
---
Tested steps described in bug report.
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
, the tool selections aren't quite coherent, but that's for another patch.
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
. As
before, the tool selections aren't quite coherent, but that's for another patch.
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
abWidget is a QTabWidget and is setting its tabbar with
> >
> > setTabBar( new KTabBar( this ) );
> >
> > so how would QTabWidget::tabBar not return something valid?
>
> Jonathan Doman wrote:
> That function is protected. I would have to
to subclass {K,Q}TabWidget to gain
access to it.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118685/#review62426
-----
ard.kde.org/r/118685/#review62354
---
On June 11, 2014, 11:52 p.m., Jonathan Doman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
https://bugs.kde.org/show_bug.cgi?id=335852
--- Comment #2 from Jonathan Doman ---
Okay, got it. I'm settled in a new city now, so I'll put up patches as fast as
you can review them.
--
You are receiving this mail because:
You are the assignee f
://git.reviewboard.kde.org/r/118685/diff/
Testing
---
Tested that the GUI remains coherent when moving two tabs around many times. As
before, the tool selections aren't quite coherent, but that's for another patch.
Thanks,
Jonathan Doman
___
Ok
https://bugs.kde.org/show_bug.cgi?id=334251
Bug ID: 334251
Summary: Tools don't work if any tab is in review mode
Classification: Unclassified
Product: okular
Version: 0.19.0
Platform: Archlinux Packages
OS: Linux
https://bugs.kde.org/show_bug.cgi?id=334100
Jonathan Doman changed:
What|Removed |Added
CC||jonathan.do...@gmail.com
--- Comment #1 from
https://bugs.kde.org/show_bug.cgi?id=334018
--- Comment #1 from Jonathan Doman ---
I'm happy to implement this, but it may be a month before I have time to do it.
It's really just one line of code, but there are a few other tab improvements
I'd like to do at the same time.
--
Yo
https://bugs.kde.org/show_bug.cgi?id=334019
--- Comment #2 from Jonathan Doman ---
I'm happy to implement this, but it may be a month before I have time to do it.
--
You are receiving this mail because:
You are the assignee for the bug.
___
O
debar.h 036d7788096366d6bab7d7f2a41d55b7a31d303a
ui/pageview.h 577b908633bd0778df33d0a15961ab16071a1500
ui/thumbnaillist.cpp 72b557e6624e8229cf1e5e4c5dc69ed77fec54cb
Diff: https://git.reviewboard.kde.org/r/116700/diff/
Testing
---
Thanks,
Jonathan Doman
___
Okular-dev
pageview.cpp dd4199450672c18ebfa146327d8e9b7eb034ddc8
ui/sidebar.h 036d7788096366d6bab7d7f2a41d55b7a31d303a
ui/pageview.h 577b908633bd0778df33d0a15961ab16071a1500
ui/thumbnaillist.cpp 72b557e6624e8229cf1e5e4c5dc69ed77fec54cb
Diff: https://git.reviewboa
30940b27b727608e5
shell/shell.h 3b9aae061cd6be0c7a86c885fc06d00d9275bd50
part.cpp 4ce7e28e1071772921e6292e61a88c905a62d7f6
shell/main.cpp e0ca587ba167c4020d5af5bd33a2dc1b4923cac4
Diff: https://git.reviewboard.kde.org/r/116700/diff/
Testing
---
Thanks,
Jonathan Doman
___
0d9275bd50
part.cpp 4ce7e28e1071772921e6292e61a88c905a62d7f6
part.h 010e9de1f2b5c27531a48b943d821ccc3f3f7205
Diff: https://git.reviewboard.kde.org/r/116700/diff/
Testing
---
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
onous if it would be worthwhile.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116700/#review53282
-------
On Ma
> On March 17, 2014, 4:29 p.m., Albert Astals Cid wrote:
> > Does this also solve drag&drop as described in
> > https://bugs.kde.org/show_bug.cgi?id=332238 ?
>
> Jonathan Doman wrote:
> No, I have avoided modifying the part/pageview.
>
> Albert Astals
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116700/#review53284
---
On March 10, 2014, 5:45 p.m., Jonathan Doman wrote:
>
> -
> On March 17, 2014, 4:29 p.m., Albert Astals Cid wrote:
> > Does this also solve drag&drop as described in
> > https://bugs.kde.org/show_bug.cgi?id=332238 ?
>
> Jonathan Doman wrote:
> No, I have avoided modifying the part/pageview.
>
> Albert Astals
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116700/#review53260
---
On March 10, 2014, 5:45 p.m., Jonathan Doman wrote:
>
> ---
https://bugs.kde.org/show_bug.cgi?id=330991
Jonathan Doman changed:
What|Removed |Added
CC||jonathan.do...@gmail.com
--- Comment #4 from
27608e5
shell/shell.h 3b9aae061cd6be0c7a86c885fc06d00d9275bd50
shell/main.cpp e0ca587ba167c4020d5af5bd33a2dc1b4923cac4
Diff: https://git.reviewboard.kde.org/r/116700/diff/
Testing
---
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
https://bugs.kde.org/show_bug.cgi?id=331872
--- Comment #3 from Jonathan Doman ---
Okay, I'm not an official developer but I'll try to implement this and get it
reviewed. How would you expect this to behave when there are multiple okular
windows already opened? Should it open a new
https://bugs.kde.org/show_bug.cgi?id=331872
Jonathan Doman changed:
What|Removed |Added
CC||jonathan.do...@gmail.com
--- Comment #1 from
remove the frame.
Diffs
-
shell/shell.cpp 822615351a91386c51dad4f4afe67db53c3ec97d
Diff: https://git.reviewboard.kde.org/r/115636/diff/
Testing
---
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https
: https://git.reviewboard.kde.org/r/115636/diff/
Testing
---
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110914/#review49254
---
On Feb. 8, 2014, 11:16 a.m., Jonathan Doman wrote:
>
>
93fbc417588312792bab39b693c65e5d414c87c6
Diff: https://git.reviewboard.kde.org/r/110914/diff/
Testing
---
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
https://bugs.kde.org/show_bug.cgi?id=219121
Jonathan Doman changed:
What|Removed |Added
CC||jonathan.do...@gmail.com
--- Comment #11 from
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110914/#review48432
---
On Jan. 19, 2014, 9:34 p.m., Jonathan Doman wrote:
>
> --
/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6
Diff: https://git.reviewboard.kde.org/r/110914/diff/
Testing
---
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
o tab 1
> > * Go to tab 2
> > * Press Esc
> > * Search bar does not close
> >
>
> Jonathan Doman wrote:
> As you may have noticed, the problem is that the Part::m_closeFindBar
> action loses its shortcut (Key_Escape) after switching tabs. However, I can
ly generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110914/#review47475
---
On Jan. 13, 2014, 12:24 a.m., Jonathan Doman wrote:
>
> ---
> Th
> you want one check there shouldn't you be doing something like
> > activeTab < m_tabs.size?
> >
> > But this can't happen, no?
>
> Jonathan Doman wrote:
> Yes, you are right. I was specifically trying to change the code as
> litt
/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6
Diff: https://git.reviewboard.kde.org/r/110914/diff/
Testing
---
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
this program and others) are camel cased.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110914/#review47271
---
On Jan. 11,
/shell.h c065c560fb4ddfcf181601cf35e9ca14581731f6
shell/shell.cpp 1708501daaef817a1ce35fa5d96701a66ab66983
shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6
Diff: https://git.reviewboard.kde.org/r/110914/diff/
Testing
---
Thanks,
Jonathan Doman
t; > setting so people were not forced to use tabs if they don't like them
>
> Jonathan Doman wrote:
> Where should the interface for this setting be?
>
> Albert Astals Cid wrote:
> Settings -> Configure -> General -> Program features looks good to me.
/shell.cpp 1708501daaef817a1ce35fa5d96701a66ab66983
shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6
Diff: https://git.reviewboard.kde.org/r/110914/diff/
Testing
---
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
t; > setting so people were not forced to use tabs if they don't like them
>
> Jonathan Doman wrote:
> Where should the interface for this setting be?
>
> Albert Astals Cid wrote:
> Settings -> Configure -> General -> Program features looks good to me.
-
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110914/#review46407
---
On Jan. 3, 2014, 2:24 a.m., Jonathan Doman wrote:
>
> ---
/jrmrjnck/okular-tabbed
Diffs (updated)
-
shell/shell.cpp 1708501daaef817a1ce35fa5d96701a66ab66983
shell/shell.h c065c560fb4ddfcf181601cf35e9ca14581731f6
Diff: https://git.reviewboard.kde.org/r/110914/diff/
Testing
---
Thanks,
Jonathan Doman
://git.reviewboard.kde.org/r/110914/diff/
Testing
---
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
o open new documents in the MRU existing window?
No one has given their opinion on this yet. If not, then it's easy to keep
documents in the same process and I'll do that.
I'll take a look at the other stuff and upload a new diff when I get some time.
- Jonathan
--
https://bugs.kde.org/show_bug.cgi?id=155515
--- Comment #67 from Jonathan Doman ---
The code is ready to merge from my perspective, but we are still working
through the review stage. Unfortunately, we have not really gotten into any
discussion about the UI design decisions yet, and I suspect the
gt; for anything other than for calling unregisterObject, is this something
> > stale from old changes?
>
> Jonathan Doman wrote:
> I accidentally removed the initialization in the last update. I believe
> it's necessary so that closed tabs don't show up in DBus.
>
&g
to yours.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110914/#review38244
---
On Aug. 23, 2013, 8:06 p.m., Jonathan Doman
1708501daaef817a1ce35fa5d96701a66ab66983
shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6
Diff: http://git.reviewboard.kde.org/r/110914/diff/
Testing
---
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo
gt; for anything other than for calling unregisterObject, is this something
> > stale from old changes?
>
> Jonathan Doman wrote:
> I accidentally removed the initialization in the last update. I believe
> it's necessary so that closed tabs don't show up in DBus.
>
&g
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110914/#review38086
---
On Aug. 18, 2013, 11:37 p.m., Jonathan Doman wrote:
>
>
1708501daaef817a1ce35fa5d96701a66ab66983
shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6
Diff: http://git.reviewboard.kde.org/r/110914/diff/
Testing
---
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110914/#review38086
---
On Aug. 17, 2013, 3:06 p.m., Jonathan Doman wrote:
>
> -
1708501daaef817a1ce35fa5d96701a66ab66983
shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6
Diff: http://git.reviewboard.kde.org/r/110914/diff/
Testing
---
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo
to me
that they be different.
- Jonathan
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110914/#review37814
-------
On Au
oard.kde.org/r/110914/#review37814
---
On Aug. 3, 2013, 10:03 p.m., Jonathan Doman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
.reviewboard.kde.org/r/110914/#review34000
---
On Aug. 3, 2013, 10:03 p.m., Jonathan Doman wrote:
>
> ---
> This is an automatically generated e-mail. To repl
1708501daaef817a1ce35fa5d96701a66ab66983
shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6
Diff: http://git.reviewboard.kde.org/r/110914/diff/
Testing
---
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https
://git.reviewboard.kde.org/r/110914/diff/
Testing
---
Thanks,
Jonathan Doman
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
https://bugs.kde.org/show_bug.cgi?id=155515
--- Comment #62 from Jonathan Doman ---
Thank you for your feedback. I had not considered the case presented in #58. I
will take these comments into consideration and open a review request when I
think the tabs behave reasonably.
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=155515
Jonathan Doman changed:
What|Removed |Added
CC||jonathan.do...@gmail.com
--- Comment #57 from
83 matches
Mail list logo
