This revision was automatically updated to reflect the committed changes.
Closed by commit R223:cb691f70dcb0: Fix some clazy warning (authored by
mlaurent).
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20832?vs=57003&id=58700
REVISION DETAIL
https://phabri
mlaurent added a comment.
Ping ?
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D20832
To: mlaurent, aacid
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
mlaurent added a comment.
Ok albert send me an email in private :)
he will look at it in several days :)
tha,ks :)
(I didn't have internet access before to see his email :)
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D20832
To: mlaurent, aacid
Cc: okular-d
mlaurent added a comment.
new ping :)
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D20832
To: mlaurent, aacid
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
mlaurent added a comment.
ping ? :)
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D20832
To: mlaurent, aacid
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
mlaurent updated this revision to Diff 57003.
mlaurent added a comment.
Fix comment gave by albert
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20832?vs=56998&id=57003
BRANCH
fix_some_clazy_warning (branched from master)
REVISION DETAIL
https://phabr
mlaurent added a reviewer: aacid.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D20832
To: mlaurent, aacid
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
mlaurent created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
mlaurent requested review of this revision.
REVISION SUMMARY
fix clazy warning
REPOSITORY
R223 Okular
BRANCH
fix_some_clazy_warning (branched from master)
REVISION DETAIL
https://pha
mlaurent added a comment.
@rkflx void signalPartialPixmapRequest( Okular::PixmapRequest * request,
const QImage &image ); it seems that it's not fixed no ? still space no ?
But after fixing it it's ok for me
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D8379
To:
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> documenttest.cpp:112
> +QCOMPARE( m_document->isDocdataMigrationNeeded(), false );
> +m_document->closeDocument();
> +}
closeDocument delete m_doc
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R223 Okular
BRANCH
queueTextRequest
REVISION DETAIL
https://phabricator.kde.org/D8378
To: aacid, #okular, mlaurent
Cc: michaelweghorn, dvratil, mlaurent, #okular, aacid
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> generator_p.h:135
>
> +public slots:
> +void startGeneration( Okular::Page *page );
it seems that okular use Q_SLOTS
REPOSITORY
R223 Okul
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> generator.h:584
> + */
> +void signalPartialPixmapRequest( Okular::PixmapRequest * request,
> const QImage &image );
> +
Coding style:
vo
mlaurent added inline comments.
INLINE COMMENTS
> generator_pdf.cpp:929
> +auto payload = static_cast(payloadA);
> +QMetaObject::invokeMethod(payload->generator,
> "signalPartialPixmapRequest", Qt::QueuedConnection,
> Q_ARG(Okular::PixmapRequest *, payload->request), Q_ARG(QImage, image
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
Seems ok for me.
REPOSITORY
R223 Okular
BRANCH
queueTextRequest
REVISION DETAIL
https://phabricator.kde.org/D8378
To: aacid, #okular, mlaurent
Cc: mlaurent, #okular, aacid
TION
ui/presentationwidget.h fd9d462
ui/presentationwidget.cpp 257dcb0
ui/quickselectiontoolselectaction.h PRE-CREATION
ui/quickselectiontoolselectaction.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/124614/diff/
Testing
---
I tested it in real :)
Thanks,
Laur
TION
ui/quickselectiontoolselectaction.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/124614/diff/
Testing
---
I tested it in real :)
Thanks,
Laurent Montel
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailma
17 matches
Mail list logo