BUG:213508 Autotests

2019-08-24 Thread Mayank Choudhary
I am trying to write the autotests for BUG:213508. I want to shift the focus to the document when collapsing the sidebar. Can you please give me the first initial plan ?

D22262: Thumbnails sidebar always open when okular starts

2019-08-09 Thread Mayank Choudhary
mayankchoudhary added a comment. I want to use the mouse to click on the sidebar. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D22262 To: mayankchoudhary, aacid, ngraham, #okular Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen

D22262: Thumbnails sidebar always open when okular starts

2019-07-04 Thread Mayank Choudhary
mayankchoudhary added a comment. When I am trying to write autotests the pointer moves outside of the okular window. I tried QTest::mouseMove() & QPoint() methods. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D22262 To: mayankchoudhary, aac

D22262: Thumbnails sidebar always open when okular starts

2019-07-04 Thread Mayank Choudhary
mayankchoudhary added reviewers: aacid, ngraham, Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D22262 To: mayankchoudhary, aacid, ngraham, #okular Cc: okular-devel, maguirre, fbampaloukas, joaonetto, tfella, ngraham, darcyshen, aacid

D22262: Thumbnails sidebar always open when okular starts

2019-07-04 Thread Mayank Choudhary
mayankchoudhary added a comment. Should i write autotests ? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D22262 To: mayankchoudhary, aacid, ngraham, #okular Cc: okular-devel, maguirre, fbampaloukas, joaonetto, tfella, ngraham, darcyshen, aacid

D22262: Thumbnails sidebar always open when okular starts

2019-07-04 Thread Mayank Choudhary
mayankchoudhary created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. mayankchoudhary requested review of this revision. REVISION SUMMARY Every time Okular starts, one of the items of the Sidebar is open (usually the Thumbnails panel).There is no way to

Re: How to select a sidebar item when the sidebar is collapsed in autotests/parttest

2019-07-02 Thread Mayank Choudhary
I tried QTest::mouseMove() & QPoint() method but the cursor moves out of the okular instead of the sidebar. Does part.m_sidebar is the right candidate for selecting the sidebar? On Tue, 2 Jul 2019, 4:30 am Albert Astals Cid, wrote: > El dimarts, 2 de juliol de 2019, a les 0:52:42 CEST,

How to select a sidebar item when the sidebar is collapsed in autotests/parttest

2019-07-01 Thread Mayank Choudhary
Hello, I'm writing an autotest in parttest.cpp where initially when the part is opened, the sidebar is collapsed. Now I need to click on thumbnails item (say) in order to open it. How can I? I tried part.m_sidebar->setCurrentItem(thumbsbox) but as thumbsbox is declared in Part ctor, I'm unable to

D22118: Shifts focus to the document when collapsing a sidebar view

2019-07-01 Thread Mayank Choudhary
mayankchoudhary added a comment. Please before the merge commit, change my username to "Mayank Choudhary". REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D22118 To: mayankchoudhary, #okular, aacid, sander, ngraham Cc: ngraham, okular-devel

D22118: Shifts focus to the document when collapsing a sidebar view

2019-07-01 Thread Mayank Choudhary
mayankchoudhary added a comment. @aacid May you please review this ? REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D22118 To: mayankchoudhary, #okular, aacid, sander, ngraham Cc: ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, tfella, dar

[okular] [Bug 213508] Closing a navigation pane should shift focus to the document (away from the navigation panel)

2019-06-27 Thread Mayank Choudhary
https://bugs.kde.org/show_bug.cgi?id=213508 --- Comment #5 from Mayank Choudhary --- As per Syam request, I have sent a patch here: https://phabricator.kde.org/D22118 -- You are receiving this mail because: You are the assignee for the bug.

D22118: Closing the sidebar shifts focus to the document/away from the sidebar.

2019-06-27 Thread Mayank Choudhary
mayankchoudhary created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. mayankchoudhary requested review of this revision. REVISION SUMMARY If we click on a sidebar item to collapse it, the focus remains on the sidebar item list and pressing the up/down a

How can i call pageview's isOpened() function in sidebar.cpp

2019-06-25 Thread Mayank Choudhary
I want to access the isOpened() function and externalKeyPressEvent( QKeyEvent *); of pageview.cpp in sidebar.cpp. How can I do that?

D21910: Preferences dialog is resized from its default size, such that the complete content is visible.

2019-06-21 Thread Mayank Choudhary
mayankchoudhary added a comment. what to do? Is it still a junior job now? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21910 To: mayankchoudhary, ngraham, #okular Cc: ngraham, okular-devel, fbampaloukas, joaonetto, tfella, darcyshen, aacid

D21910: Preferences dialog is resized from its default size, such that the complete content is visible.

2019-06-19 Thread Mayank Choudhary
mayankchoudhary added a comment. We get default size because of kconfigdialog. If we make changes in kconfigdialog, all the Dialogs sizes will be changed. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21910 To: mayankchoudhary, ngraham, #okular Cc: ngraham, okular-

[okular] [Bug 397678] Configure window is squeezed too much

2019-06-19 Thread Mayank Choudhary
https://bugs.kde.org/show_bug.cgi?id=397678 --- Comment #4 from Mayank Choudhary --- I have sent a patch here: https://phabricator.kde.org/D21910 -- You are receiving this mail because: You are the assignee for the bug.

D21910: Preferences dialog is resized from its default size, such that the complete content is visible.

2019-06-19 Thread Mayank Choudhary
mayankchoudhary created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. mayankchoudhary requested review of this revision. REVISION SUMMARY Preferences dialog have pages like "General" and "Presentation" where the user need to scroll down in order to see

[okular] [Bug 397678] Configure window is squeezed too much

2019-06-19 Thread Mayank Choudhary
https://bugs.kde.org/show_bug.cgi?id=397678 Mayank Choudhary changed: What|Removed |Added CC||mayankch...@gmail.com -- You are receiving

[okular] [Bug 408743] Typewriter tool not showing in okular annotations.

2019-06-15 Thread Mayank Choudhary
https://bugs.kde.org/show_bug.cgi?id=408743 --- Comment #2 from Mayank Choudhary --- I’m trying with the latest poppler and let me add a comment if it works. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 408743] Typewriter tool not showing in okular annotations.

2019-06-15 Thread Mayank Choudhary
https://bugs.kde.org/show_bug.cgi?id=408743 Mayank Choudhary changed: What|Removed |Added CC||mayankch...@gmail.com Summary

[okular] [Bug 408743] New: Typewriter tool not showing in okular review tools

2019-06-15 Thread Mayank Choudhary
https://bugs.kde.org/show_bug.cgi?id=408743 Bug ID: 408743 Summary: Typewriter tool not showing in okular review tools Product: okular Version: 1.7.2 Platform: Other OS: Linux Status: REPORTED Severity: n

[okular] [Bug 213508] Closing a navigation pane should shift focus to the document (away from the navigation panel)

2019-06-12 Thread Mayank Choudhary
https://bugs.kde.org/show_bug.cgi?id=213508 Mayank Choudhary changed: What|Removed |Added CC||mayankch...@gmail.com -- You are receiving