[okular] [Bug 424937] Okular sends blank pages do printer

https://bugs.kde.org/show_bug.cgi?id=424937 --- Comment #10 from Michael Weghorn --- (In reply to Michael from comment #9) > don't forget when I print the same file from another PDF viewer it is > printing right, I guess that means the problem isn't in the printer or > somewhe

[okular] [Bug 424937] Okular sends blank pages do printer

https://bugs.kde.org/show_bug.cgi?id=424937 Michael Weghorn changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED

[okular] [Bug 425289] Printing problem: 2 copies on a double sided printer

https://bugs.kde.org/show_bug.cgi?id=425289 --- Comment #6 from Michael Weghorn --- (In reply to Axel Braun from comment #5) > (In reply to Michael Weghorn from comment #4) > > Looking at the PPD: > > > > There's this line in there: > > > *cupsManualCopies: f

[okular] [Bug 425289] Printing problem: 2 copies on a double sided printer

https://bugs.kde.org/show_bug.cgi?id=425289 --- Comment #4 from Michael Weghorn --- Looking at the PPD: There's this line in there: > *cupsManualCopies: false What you can *try* is changing that to > *cupsManualCopies: true and see whether it helps. -- You are receiving this m

[okular] [Bug 425289] Printing problem: 2 copies on a double sided printer

https://bugs.kde.org/show_bug.cgi?id=425289 Michael Weghorn changed: What|Removed |Added Resolution|WAITINGFORINFO |UPSTREAM Status|NEEDSINFO

[okular] [Bug 415986] Printing to HP1120C with gutenprint driver from Okular not working.

https://bugs.kde.org/show_bug.cgi?id=415986 Michael Weghorn changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED

[okular] [Bug 396879] Full screen mode doesn't work in wayland

https://bugs.kde.org/show_bug.cgi?id=396879 --- Comment #4 from Michael Weghorn --- *** Bug 396880 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 396880] Presentation mode in wayland shows panel, obscuring part of the document

https://bugs.kde.org/show_bug.cgi?id=396880 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de Resolution

[okular] [Bug 396879] Full screen mode doesn't work in wayland

https://bugs.kde.org/show_bug.cgi?id=396879 Michael Weghorn changed: What|Removed |Added Resolution|--- |WORKSFORME Status|REPORTED

[okular] [Bug 424937] Okular sends blank pages do printer

https://bugs.kde.org/show_bug.cgi?id=424937 Michael Weghorn changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED

[okular] [Bug 425289] Printing problem: 2 copies on a double sided printer

https://bugs.kde.org/show_bug.cgi?id=425289 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de Resolution

D20868: Support '#page=' fragment to open at page

michaelweghorn abandoned this revision. michaelweghorn added a comment. In D20868#615357 , @aacid wrote: > Please move as a Merge Request in https://invent.kde.org/kde/okular > > We have pre-commit CI and lots of checks including clazy and cla

[okular] [Bug 423694] Prints the square of the quantity requested: ask for 2,get 4; ask for 3, get 9, ask for 4,get 16 sheets.

https://bugs.kde.org/show_bug.cgi?id=423694 Michael Weghorn changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED

[okular] [Bug 422690] Margins often cut when printing (2020 - Okular-1.10.0)

https://bugs.kde.org/show_bug.cgi?id=422690 Michael Weghorn changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[okular] [Bug 422600] Okular is unable to print to fit page

https://bugs.kde.org/show_bug.cgi?id=422600 --- Comment #4 from Michael Weghorn --- And does it work if you explicitly enable rasterization? This might help to avoid issues with the CUPS filter chain, s.a. bug 422690. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 422690] Margins often cut when printing (2020 - Okular-1.10.0)

https://bugs.kde.org/show_bug.cgi?id=422690 --- Comment #5 from Michael Weghorn --- Since this works OK with CUPS-PDF and the same issue happens when printing using command line, I think this is not an Okular issue, but rather somewhere in the CUPS filter chain. Closing as RESOLVED UPSTREAM

[okular] [Bug 422600] Okular is unable to print to fit page

https://bugs.kde.org/show_bug.cgi?id=422600 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de --- Comment #3 from

[okular] [Bug 422690] Margins often cut when printing (2020 - Okular-1.10.0)

https://bugs.kde.org/show_bug.cgi?id=422690 Michael Weghorn changed: What|Removed |Added Resolution|--- |WAITINGFORINFO CC

[okular] [Bug 351849] Margins often cut when printing

https://bugs.kde.org/show_bug.cgi?id=351849 Michael Weghorn changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution

[okular] [Bug 406053] Top of the page is cut of when printing

https://bugs.kde.org/show_bug.cgi?id=406053 --- Comment #15 from Michael Weghorn --- (In reply to Matthias from comment #12) > (In reply to Michael Weghorn from comment #11) > > > 1) Did you select any additional information in the print dialog, e.g. set > > the "Force

[okular] [Bug 415986] Printing to HP1120C with gutenprint driver from Okular not working.

https://bugs.kde.org/show_bug.cgi?id=415986 Michael Weghorn changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED

[okular] [Bug 406053] Top of the page is cut of when printing

https://bugs.kde.org/show_bug.cgi?id=406053 Michael Weghorn changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution

[okular] [Bug 406053] Top of the page is cut of when printing

https://bugs.kde.org/show_bug.cgi?id=406053 Michael Weghorn changed: What|Removed |Added Resolution|--- |WAITINGFORINFO CC

[okular] [Bug 415985] Okular is not printing to HP1120C printer with driver HP DeskJet 1120C Foomatic/pcl3

https://bugs.kde.org/show_bug.cgi?id=415985 --- Comment #5 from Michael Weghorn --- Note: There's also bug 415986 describing mostly the same issue for the same printer with another PPD/driver in use. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 415986] Printing to HP1120C with gutenprint driver from Okular not working.

https://bugs.kde.org/show_bug.cgi?id=415986 Michael Weghorn changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution

[okular] [Bug 415985] Okular is not printing to HP1120C printer with driver HP DeskJet 1120C Foomatic/pcl3

https://bugs.kde.org/show_bug.cgi?id=415985 Michael Weghorn changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution

[okular] [Bug 418551] Duplex printing setting ignored

https://bugs.kde.org/show_bug.cgi?id=418551 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de Resolution

[okular] [Bug 407998] Okular scales down pages when printing

https://bugs.kde.org/show_bug.cgi?id=407998 --- Comment #16 from Michael Weghorn --- (In reply to Éric Brunet from comment #15) > (In reply to Michael Weghorn from comment #11) > > This is https://phabricator.kde.org/D10974 and I quickly verified that > > current development ve

[okular] [Bug 418485] unable to find the Okular component: The shared library was not found ubuntu

https://bugs.kde.org/show_bug.cgi?id=418485 --- Comment #5 from Michael Weghorn --- (In reply to LASSOUED Ghassen from comment #4) > (In reply to Michael Weghorn from comment #3) > > OK, let's close as WORKSFORME then. > Sorry, i have not meant that you should close or some

[okular] [Bug 418485] unable to find the Okular component: The shared library was not found ubuntu

https://bugs.kde.org/show_bug.cgi?id=418485 Michael Weghorn changed: What|Removed |Added Resolution|WAITINGFORINFO |WORKSFORME Status|NEEDSINFO

[okular] [Bug 418485] unable to find the Okular component: The shared library was not found ubuntu

https://bugs.kde.org/show_bug.cgi?id=418485 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de Resolution

[okular] [Bug 416796] Display of music on staff lines are difficult to read

https://bugs.kde.org/show_bug.cgi?id=416796 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de Status

[okular] [Bug 263042] XFA Forms are not supported

https://bugs.kde.org/show_bug.cgi?id=263042 --- Comment #19 from Michael Weghorn --- (In reply to Albert Astals Cid from comment #18) > There's non-Free apps on Linux that let you work with XFA files if you > really really need to, use your favourite search engine to find them.

[okular] [Bug 375012] cannot print in custom dimensions

https://bugs.kde.org/show_bug.cgi?id=375012 --- Comment #19 from Michael Weghorn --- (In reply to bruce.samha...@samhaber.ca from comment #18) > (In reply to Bug Janitor Service from comment #17) > > The upgrade to openSUSE 15.1 LEAP is complete. HPLIP version 3.18.6 is > install

[okular] [Bug 375012] cannot print in custom dimensions

https://bugs.kde.org/show_bug.cgi?id=375012 --- Comment #12 from Michael Weghorn --- (In reply to bruce.samha...@samhaber.ca from comment #11) > I am using OpenSUSE 13.2 which appears to use qt3. qt4 and qt5 are not even > install options, so I guess I need to upgrade to a more recent Op

[okular] [Bug 375012] cannot print in custom dimensions

https://bugs.kde.org/show_bug.cgi?id=375012 Michael Weghorn changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED

[okular] [Bug 375012] cannot print in custom dimensions

https://bugs.kde.org/show_bug.cgi?id=375012 --- Comment #6 from Michael Weghorn --- (In reply to bruce.samha...@samhaber.ca from comment #2) > Created attachment 122940 [details] > Okular print properties Page Custom size media > > When printing from Okular with a page that is a

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

https://bugs.kde.org/show_bug.cgi?id=408270 Michael Weghorn changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

https://bugs.kde.org/show_bug.cgi?id=408270 Michael Weghorn changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

https://bugs.kde.org/show_bug.cgi?id=408270 --- Comment #17 from Michael Weghorn --- (In reply to Matthew Trescott from comment #16) > Created attachment 121353 [details] > CUPS error log when printing with LibreOffice > > No, neither of those files exist. And as I said, LibreOf

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

https://bugs.kde.org/show_bug.cgi?id=408270 Michael Weghorn changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution

[okular] [Bug 408818] Ark crashed when trying to open *.fb2 file

https://bugs.kde.org/show_bug.cgi?id=408818 Michael Weghorn changed: What|Removed |Added Resolution|--- |UPSTREAM Status|REPORTED

[okular] [Bug 408851] Crash when trying to open *.fb2 file

https://bugs.kde.org/show_bug.cgi?id=408851 Michael Weghorn changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REPORTED

[okular] [Bug 408818] Ark crashed when trying to open *.fb2 file

https://bugs.kde.org/show_bug.cgi?id=408818 --- Comment #9 from Michael Weghorn --- *** Bug 408851 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 407998] Okular scales down pages when printing

https://bugs.kde.org/show_bug.cgi?id=407998 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de --- Comment #11 from

[okular] [Bug 185636] More printing options for page control

https://bugs.kde.org/show_bug.cgi?id=185636 Michael Weghorn changed: What|Removed |Added Resolution|--- |UPSTREAM Status|CONFIRMED

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

https://bugs.kde.org/show_bug.cgi?id=408270 Michael Weghorn changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

https://bugs.kde.org/show_bug.cgi?id=408270 --- Comment #8 from Michael Weghorn --- Created attachment 120617 --> https://bugs.kde.org/attachment.cgi?id=120617&action=edit file in /var/spool/cups/ generated by Okular with dummy printer using same PPD I cannot reproduce on Debian

[okular] [Bug 408272] The default scaling method should be "Fit to Full Page"

https://bugs.kde.org/show_bug.cgi?id=408272 --- Comment #6 from Michael Weghorn --- (In reply to Oliver Sander from comment #5) > > Make Okular remember the last scaling setting setting rather than always > > resetting to the default value > > +1 for this approach. It als

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

https://bugs.kde.org/show_bug.cgi?id=408270 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de -- You are receiving

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

https://bugs.kde.org/show_bug.cgi?id=408270 --- Comment #6 from Michael Weghorn --- *** Bug 406237 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 408273] Scaling mode "Print original size" is confusing

https://bugs.kde.org/show_bug.cgi?id=408273 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de -- You are receiving

[okular] [Bug 406237] PDFs get an added margin when printing

https://bugs.kde.org/show_bug.cgi?id=406237 Michael Weghorn changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[okular] [Bug 408272] The default scaling method should be "Fit to Full Page"

https://bugs.kde.org/show_bug.cgi?id=408272 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de -- You are receiving

[okular] [Bug 408271] Print-to-PDF defaults to A4 regardless of locale or original document size

https://bugs.kde.org/show_bug.cgi?id=408271 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de -- You are receiving

[okular] [Bug 406237] PDFs get an added margin when printing

https://bugs.kde.org/show_bug.cgi?id=406237 Michael Weghorn changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution

[okular] [Bug 406237] PDFs get an added margin when printing

https://bugs.kde.org/show_bug.cgi?id=406237 --- Comment #10 from Michael Weghorn --- (In reply to Matthew Trescott from comment #7) > [...] > I just double-checked this to make certain. I turned off WiFi temporarily so > CUPS would hold my print job (it's a network printer), t

[okular] [Bug 406237] PDFs get an added margin when printing

https://bugs.kde.org/show_bug.cgi?id=406237 Michael Weghorn changed: What|Removed |Added Status|NEEDSINFO |REPORTED Ever confirmed|1

[okular] [Bug 406831] RFC compliant URL to specify page number not treated properly

https://bugs.kde.org/show_bug.cgi?id=406831 --- Comment #5 from Michael Weghorn --- Change on Phabricator: https://phabricator.kde.org/D20868 -- You are receiving this mail because: You are the assignee for the bug.

D20868: Support '#page=' fragment to open at page

michaelweghorn created this revision. michaelweghorn added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. michaelweghorn requested review of this revision. REVISION SUMMARY Support the '#page=' fragment to specify which page to open the document at

[okular] [Bug 406831] RFC compliant URL to specify page number not treated properly

https://bugs.kde.org/show_bug.cgi?id=406831 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de --- Comment #4 from

[okular] [Bug 406237] PDFs get an added margin when printing

https://bugs.kde.org/show_bug.cgi?id=406237 Michael Weghorn changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REOPENED

[okular] [Bug 406646] Okular Can not really change page color

https://bugs.kde.org/show_bug.cgi?id=406646 Michael Weghorn changed: What|Removed |Added Resolution|WAITINGFORINFO |--- CC|m.wegh...@posteo.de

[okular] [Bug 406646] Okular Can not really change page color

https://bugs.kde.org/show_bug.cgi?id=406646 Michael Weghorn changed: What|Removed |Added Resolution|--- |WAITINGFORINFO CC

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn added a comment. In D18179#450252 , @ngraham wrote: > OK, let's go for it! > > @michaelweghorn I hope you know this means you're on the hook to fix any bugs that crop up, right? :) @ngraham: Thanks for landing this! Yes

[okular] [Bug 406237] PDFs get an added margin when printing

https://bugs.kde.org/show_bug.cgi?id=406237 Michael Weghorn changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REOPENED

[okular] [Bug 348172] Scaling options missing in print dialog

https://bugs.kde.org/show_bug.cgi?id=348172 --- Comment #27 from Michael Weghorn --- *** Bug 406237 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 406237] PDFs get an added margin when printing

https://bugs.kde.org/show_bug.cgi?id=406237 Michael Weghorn changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REPORTED

[okular] [Bug 348172] Scaling options missing in print dialog

https://bugs.kde.org/show_bug.cgi?id=348172 Michael Weghorn changed: What|Removed |Added CC||matthewtresc...@gmail.com --- Comment #26

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn marked 2 inline comments as done. REPOSITORY R223 Okular BRANCH arcpatch-D18179 REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngraham, sander Cc: aacid, fvogt, okular-devel, joaonetto, tfella, ngraham, darcyshen

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn updated this revision to Diff 55394. michaelweghorn added a comment. Changes in this revision: - Update the '@since' comments from version 1.7 to 1.8 - Rename 'ScaleMode::None' to 'ScaleMode::NoScaling' REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabric

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn added a comment. In D18179#442948 , @ngraham wrote: > Never mind, removing the dependency made it work. Stupid Arc. :( Testing now... Yet, it also took me a while to figure this out... Looking forward to the GitLab migrati

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn added a comment. In D10974#442825 , @ngraham wrote: > Do you really not have commit access yet? You should apply. :) https://techbase.kde.org/Contribute/Get_a_Contributor_Account > > Meanwhile, I'll land this for you. T

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn removed a dependency: D10974: Add option to ignore print margins for non-PDF generators. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngraham, sander Cc: aacid, fvogt, okular-devel, joaonetto, tfella, ngraham, darcyshe

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn removed a dependent revision: D18179: PDF: Implement scaling options for non-rasterized printing. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10974 To: michaelweghorn, #okular, ngraham Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngra

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn added a comment. In D10974#442598 , @aacid wrote: > If someone wants to test it and approve it and Michael says he'll fix any bug that arises from here i'm happy enough I promise that I'll try to fix any issues arising from

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn added a comment. In D10974#442381 , @ngraham wrote: > I'm still not thrilled about the {nav Force Rasterization} situation (I think it should be implicitly turned on when the user chooses an option that requires it) but the comb

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn added a comment. Is there anything I can still do right now or do I just need to wait for the review? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10974 To: michaelweghorn, #okular Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngrah

[okular] [Bug 405709] [Feature request] Printing to PDF - remember last used location

https://bugs.kde.org/show_bug.cgi?id=405709 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de --- Comment #2 from

[okular] [Bug 396879] Full screen mode doesn't work in wayland

https://bugs.kde.org/show_bug.cgi?id=396879 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de -- You are receiving

[okular] [Bug 404549] Printing N copies results in N^2 copies printed instead

https://bugs.kde.org/show_bug.cgi?id=404549 Michael Weghorn changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution

[okular] [Bug 404549] Printing N copies results in N^2 copies printed instead

https://bugs.kde.org/show_bug.cgi?id=404549 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de Resolution

D18744: Add action in Edit menu to select the current page

michaelweghorn added a comment. In D18744#412409 , @michaelweghorn wrote: > The test plan still says that Ctrl+P will select the page ("or press combination of CTRL and P to select the entire page"). As far as I understand the previous comments

D18744: Add action in Edit menu to select the current page

michaelweghorn added a comment. The test plan still says that Ctrl+P will select the page ("or press combination of CTRL and P to select the entire page"). As far as I understand the previous comments, this is Alt+P now, isn't it? (I didn't do any tests.) Can you update the description accor

[okular] [Bug 403848] Redundant warning on close for unmodified documents in multiple tabs view

https://bugs.kde.org/show_bug.cgi?id=403848 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de --- Comment #2 from

[okular] [Bug 403772] Support animation from latex package 'animate'

https://bugs.kde.org/show_bug.cgi?id=403772 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de -- You are receiving

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn added a comment. In D18179#394712 , @aacid wrote: > The only way i can think of is making the long form not havve default values > > https://paste.kde.org/p55lx6vrh Thanks, that looks good. I have done it this way now.

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn updated this revision to Diff 49715. michaelweghorn added a comment. Changes in this revision: - make new 'printFiles()' have no default values for parameters, so that param order can be the same as in the original one (thanks Albert!) - add "TODO" comment to merge bot

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn added a comment. In D10974#394709 , @aacid wrote: > I don't really have the time to spend print stuff to check if this does what it says it does, so i'm just doing code review from the pure formal way. Many thanks for takin

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn marked 4 inline comments as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10974 To: michaelweghorn, #okular Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, tfella, darcyshen

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn updated this revision to Diff 49697. michaelweghorn added a comment. Adapted according to Albert's feedback: - Remove (now) unneeded imclude - remove 'virtual' keyword in derived class REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1097

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn added a comment. If you have any other idea on how to avoid that issue with the printFiles() methods, I'd be thankful to hear about this. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngraham, sander Cc: aacid, fvog

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn added a comment. In D18179#394030 , @aacid wrote: > We would need a @since marker for the enum and for the new methods and a > // TODO merge with function above when a BIC change happens somehwere else > would also make sense

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn updated this revision to Diff 49614. michaelweghorn marked an inline comment as done. michaelweghorn added a comment. - Adapt order of ScaleMode enum values as implicitly suggested in Albert's comment (I missed that at first) REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn updated this revision to Diff 49612. michaelweghorn retitled this revision from "PDF: Implement scaling for non-rasterized printing" to "PDF: Implement scaling options for non-rasterized printing". michaelweghorn edited the summary of this revision. michaelweghorn added a comment.

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn updated this revision to Diff 49608. michaelweghorn added a comment. Changes in this revision: - undo changes in 'interfaces/' - emit a qWarning() when 'dynamic_cast' fails REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10974?vs=49510&i

D18179: PDF: Implement scaling for non-rasterized printing

michaelweghorn marked an inline comment as done. michaelweghorn added a comment. Thanks for the feedback and info. I've update the change accordingly now. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngraham, sander Cc: aacid, fvo

D18179: PDF: Implement scaling for non-rasterized printing

michaelweghorn marked 2 inline comments as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngraham, sander Cc: aacid, fvogt, okular-devel, tfella, ngraham, darcyshen

D18179: PDF: Implement scaling for non-rasterized printing

michaelweghorn updated this revision to Diff 49519. michaelweghorn added a comment. Undo accidental whitespace changes REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18179?vs=49518&id=49519 BRANCH michaelweghorn/UPDATE_20191115_D18179_allowScaledPrintingW

D18179: PDF: Implement scaling for non-rasterized printing

michaelweghorn updated this revision to Diff 49518. michaelweghorn added a comment. Implement improvements suggested by Albert: - use an enum rather than a bool for scale mode - avoid ABI breakage by adding extra methods that take an additional parameter for scale mode and make existing

  1   2   3   4   >