[okular] [Bug 358065] Popup note icon in configuration dialog differs from real one

https://bugs.kde.org/show_bug.cgi?id=358065 Simone Gaiarin changed: What|Removed |Added Version|0.24.0 |22.08.3 -- You are receiving this mail

[okular] [Bug 358065] Popup note icon in configuration dialog differs from real one

https://bugs.kde.org/show_bug.cgi?id=358065 Simone Gaiarin changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO

Re: Feature Request: Improve usability of Reviews--Highlight

Hi Gordon, I agree that there is space for improvement in the annotations sidebar. At the moment, you can use the two buttons at the bottom left of the annotations sidebar that allows you to hide the pages and authors. In this way to navigate the annotations you can use Up/Down arrow + Enter. More

Re: Do we want to force braces even for 1 line if/for/etc?

Yes, let's do that. On Thu, Mar 3, 2022 at 11:42 PM Albert Astals Cid wrote: > El divendres, 6 de novembre de 2020, a les 0:27:05 (CET), Albert Astals > Cid va escriure: > > El divendres, 11 de setembre de 2020, a les 22:00:30 CET, Albert Astals > Cid va escriure: > > > El divendres, 21 d’ago

Re: Feature Request: make annotation stuck

Hi Gordon, the feature you are requesting already exists. To activate it: 1. Show the annotation toolbar by selecting Settings > Annotations 2. Click on the "pin" icon with the tooltip "Keep the annotation tool active after use" Bye On Sat, Mar 5, 2022 at 4:10 PM Gordon Shawn wrote: > When

[okular] [Bug 425598] When the annotation toolbar is visible, quick annotations are less quick to access than other annotations

https://bugs.kde.org/show_bug.cgi?id=425598 Simone Gaiarin changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap

[okular] [Bug 425438] About the new UI of Annotations tools.

https://bugs.kde.org/show_bug.cgi?id=425438 Simone Gaiarin changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap

Re: Mutlti-color highlighting

buttons go there? > > Thanks very much, > Julius > > > > > > On Sun, Jun 20, 2021, 10:27 Simone Gaiarin wrote: > >> Well the main toolbar is there, but it is text only in your case. >> >> >> This is how it looks in my case: >> [image

Re: Mutlti-color highlighting

r example, I press "d", then click on one of my > highlights, and it's deleted. > > Thanks very much, > Julius > > > > On Sat, Jun 19, 2021, 18:45 Simone Gaiarin wrote: > >> Hi Julius, >> you can find 'highlighter' under 'text markup'

Re: Mutlti-color highlighting

Hi Julius, you can find 'highlighter' under 'text markup'. You can create multiple highlighter quick annotation tools for different colors and access them from the quick annotation drop down menu action in the main toolbar. Bye On Sat, Jun 19, 2021 at 1:16 PM Julius Hamilton wrote: > Hey ever

[okular] [Bug 358069] Browse mode pointer should be an arrow not an hand to improve precision

https://bugs.kde.org/show_bug.cgi?id=358069 Simone Gaiarin changed: What|Removed |Added Resolution|--- |INTENTIONAL Status|CONFIRMED

[okular] [Bug 437377] Leaving annotation mode with mouse is complicated

https://bugs.kde.org/show_bug.cgi?id=437377 --- Comment #2 from Simone Gaiarin --- I'll try to fix this soon -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 425438] About the new UI of Annotations tools.

https://bugs.kde.org/show_bug.cgi?id=425438 --- Comment #19 from Simone Gaiarin --- Actually this is not completely fixed, to make everyone happy we still need: https://invent.kde.org/graphics/okular/-/merge_requests/414 -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 426026] Changes to annotation tool first correctly applied after re-selecting tool

https://bugs.kde.org/show_bug.cgi?id=426026 Simone Gaiarin changed: What|Removed |Added Version Fixed In||21.08 Latest Commit

[okular] [Bug 425438] About the new UI of Annotations tools.

https://bugs.kde.org/show_bug.cgi?id=425438 --- Comment #17 from Simone Gaiarin --- Git commit 0fb2058e2ad8f0436ccba9bdff8c277b849dfdaa by Simone Gaiarin. Committed on 10/05/2021 at 05:36. Pushed by gaiarin into branch 'master'. Make quick annotation tools checkable M +26

[okular] [Bug 430540] Save annotation color

https://bugs.kde.org/show_bug.cgi?id=430540 Simone Gaiarin changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution

[okular] [Bug 433949] Customizing annotations has no effect on the annotation toolbar

https://bugs.kde.org/show_bug.cgi?id=433949 Simone Gaiarin changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution

[okular] [Bug 425438] About the new UI of Annotations tools.

https://bugs.kde.org/show_bug.cgi?id=425438 Simone Gaiarin changed: What|Removed |Added CC||chantal.kel...@wanadoo.fr --- Comment #15

Re: Okular mini virtual sprint

participated in the sprint. Cheers Simone On Thu, Feb 25, 2021 at 3:32 PM David Hurka wrote: > > El divendres, 19 de febrer de 2021, a les 7:38:26 CET, Simone Gaiarin va > escriure: > > As a date I propose: > > Friday 26/02/2020, 21:00 - 23:30 CET (UTC+1) > &g

Re: Okular mini virtual sprint

As a date I propose: Friday 26/02/2020, 21:00 - 23:30 CET (UTC+1) Meeting virtual room: https://meet.kde.org/b/sim-cpk-nuv @David is this slot ok for you? It was not totally clear from your answer what slots are ok for you. On Fri, Feb 12, 2021 at 1:38 PM Oliver Sander wrote: > Currently all

Re: Okular mini virtual sprint

I replied too soon and missed your suggestion on https://framadate.org, which indeed I'll use in the future. Yes I meant CET time. On Thu, Feb 11, 2021 at 11:57 PM Albert Astals Cid wrote: > El dijous, 11 de febrer de 2021, a les 9:05:40 CET, Simone Gaiarin va > escriure: > &

Re: Okular mini virtual sprint

Next time I'll use a more privacy-sensitive doodle service, maybe https://framadate.org/. Yes I think the discussion is going to be technical, and I was thinking that we could also have a coding session where we actually fix what needs to be fixed. On Thu, Feb 11, 2021 at 10:12 PM David Hurka

Okular mini virtual sprint

Hi all, I would like to organize a mini virtual sprint with the goal of completing some stale MRs regarding Okular annotations. Me and David Hurka had lengthy discussions on some aspects of these MR but we still have not managed to complete them. I hope that someone else could join this sprint in o

Re: Question about Bug 402110

Hi Steven, great to hear you want to contribute to Okular. I suggest you the method I use for locating the relevant areas of code for a particular feature/bug: - Install ripgrep - From the top level okular folder run `rg RELEVANT_SEARCH_TERM`, for example `rg TableSel` given that you are looking f

[okular] [Bug 398553] Upper/lower dark border of search result highlight not drawn sometimes

https://bugs.kde.org/show_bug.cgi?id=398553 Simone Gaiarin changed: What|Removed |Added Ever confirmed|1 |0 Resolution|WAITINGFORINFO

[okular] [Bug 398553] Upper/lower dark border of search result highlight not drawn sometimes

https://bugs.kde.org/show_bug.cgi?id=398553 --- Comment #3 from Simone Gaiarin --- Created attachment 133680 --> https://bugs.kde.org/attachment.cgi?id=133680&action=edit invisible search highlight border -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 358064] Popup note icon size is too big and not configurable

https://bugs.kde.org/show_bug.cgi?id=358064 Simone Gaiarin changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO

[okular] [Bug 358064] Popup note icon size is too big and not configurable

https://bugs.kde.org/show_bug.cgi?id=358064 --- Comment #6 from Simone Gaiarin --- Created attachment 133653 --> https://bugs.kde.org/attachment.cgi?id=133653&action=edit large popup note icon on page that is normal (A4) -- You are receiving this mail because: You are the assignee

[okular] [Bug 358064] Popup note icon size is too big and not configurable

https://bugs.kde.org/show_bug.cgi?id=358064 --- Comment #5 from Simone Gaiarin --- Created attachment 133652 --> https://bugs.kde.org/attachment.cgi?id=133652&action=edit tiny popup note icon on page that is large -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 358063] Popup note icon should be centered on click point

https://bugs.kde.org/show_bug.cgi?id=358063 Simone Gaiarin changed: What|Removed |Added Resolution|WAITINGFORINFO |WORKSFORME Status|NEEDSINFO

[okular] [Bug 426026] Changes to annotation tool first correctly applied after re-selecting tool

https://bugs.kde.org/show_bug.cgi?id=426026 --- Comment #4 from Simone Gaiarin --- The proposed merge request "solves" this problem by deselecting the tool when it is modified, so that it has to be reselected. Given that the settings of the quick annotation tools are supposed to b

[okular] [Bug 427463] Imposible to insert annotations to pdf files

https://bugs.kde.org/show_bug.cgi?id=427463 Simone Gaiarin changed: What|Removed |Added Component|PDF backend |general -- You are receiving this mail

[okular] [Bug 427463] Imposible to insert annotations to pdf files

https://bugs.kde.org/show_bug.cgi?id=427463 Simone Gaiarin changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REPORTED

[okular] [Bug 425597] Annotation Toolbar not shown

https://bugs.kde.org/show_bug.cgi?id=425597 Simone Gaiarin changed: What|Removed |Added CC||ha.boukhou...@gmail.com --- Comment #11 from

[okular] [Bug 426658] Okular crashed while annotating document

https://bugs.kde.org/show_bug.cgi?id=426658 --- Comment #9 from Simone Gaiarin --- I confirm the problem regarding not being able to highlight text, but not the crash. I have repeated all the steps as described. The problem appears also with this simplified list of steps: 1. Select a text tool

[okular] [Bug 186797] remove "review" term and use annotations consistently

https://bugs.kde.org/show_bug.cgi?id=186797 Simone Gaiarin changed: What|Removed |Added Version Fixed In||20.12.0 Latest Commit

[okular] [Bug 426658] Okular crashed while annotating document

https://bugs.kde.org/show_bug.cgi?id=426658 Simone Gaiarin changed: What|Removed |Added CC||simg...@gmail.com --- Comment #4 from Simone

[okular] [Bug 186797] remove "review" term and use annotations consistently

https://bugs.kde.org/show_bug.cgi?id=186797 Simone Gaiarin changed: What|Removed |Added CC||simg...@gmail.com Status|REPORTED

[okular] [Bug 425438] About the new UI of Annotations tools.

https://bugs.kde.org/show_bug.cgi?id=425438 --- Comment #13 from Simone Gaiarin --- I'll share a preview once we reach that point. The shortcuts have been already swapped, should see it in 1.11.2. Now the quick annotations have shortcuts 1, 2, 3, ... as it was in Okular < 1.11. --

[okular] [Bug 425597] Annotation Toolbar not shown

https://bugs.kde.org/show_bug.cgi?id=425597 --- Comment #8 from Simone Gaiarin --- The file .local/share/kxmlgui5/okular/part.rc is automatically deleted if its version is < 47 (i.e. the version where the annotation toolbar has been added). If Okular was tested from master in a certain per

[okular] [Bug 425438] About the new UI of Annotations tools.

https://bugs.kde.org/show_bug.cgi?id=425438 Simone Gaiarin changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED

[okular] [Bug 426026] Changes to annotation tool first correctly applied after re-selecting tool

https://bugs.kde.org/show_bug.cgi?id=426026 Simone Gaiarin changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED

[okular] [Bug 426009] Annotations are broken after upgrade

https://bugs.kde.org/show_bug.cgi?id=426009 Simone Gaiarin changed: What|Removed |Added CC||simg...@gmail.com Resolution

[okular] [Bug 426026] Changes to annotation tool first correctly applied after re-selecting tool

https://bugs.kde.org/show_bug.cgi?id=426026 Simone Gaiarin changed: What|Removed |Added CC||simg...@gmail.com --- Comment #1 from Simone

[okular] [Bug 425354] In recent version 1.11 the actions are mostly wrong

https://bugs.kde.org/show_bug.cgi?id=425354 Simone Gaiarin changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit

[okular] [Bug 425438] About the new UI of Annotations tools.

https://bugs.kde.org/show_bug.cgi?id=425438 Simone Gaiarin changed: What|Removed |Added CC||simg...@gmail.com --- Comment #3 from Simone

[okular] [Bug 425887] toolsQuick.xml not installed together with KDE Neon

https://bugs.kde.org/show_bug.cgi?id=425887 Simone Gaiarin changed: What|Removed |Added CC||simg...@gmail.com --- Comment #1 from Simone

[okular] [Bug 425597] Annotation Toolbar not shown

https://bugs.kde.org/show_bug.cgi?id=425597 --- Comment #6 from Simone Gaiarin --- If you still have the original configuration files can you attach them here? If not, do you remember the name of the files that were in that folder? -- You are receiving this mail because: You are the assignee

[okular] [Bug 425597] Annotation Toolbar not shown

https://bugs.kde.org/show_bug.cgi?id=425597 --- Comment #4 from Simone Gaiarin --- Could you also try to remove the files in '.local/share/kxmlgui5/okular/' (if any), restart okular, and see if the toolbar is shown? -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 425354] In recent version 1.11 the actions are mostly wrong

https://bugs.kde.org/show_bug.cgi?id=425354 --- Comment #8 from Simone Gaiarin --- I agree on the solution proposed by David of renaming the key 'AnnotationTools' to something else. I should have done this in the first place given that it has no drawbacks, and avoids the issue report

[okular] [Bug 424810] Assert crash when selecting quick annotation tool that was added in the config dialog

https://bugs.kde.org/show_bug.cgi?id=424810 --- Comment #4 from Simone Gaiarin --- I wrongly pushed my branch to upstream instead that on my fork and I think it triggered something here. I have removed the branch from upstream and created it on my fork now. Hopefully I have not messed up

[okular] [Bug 424810] Assert crash when selecting quick annotation tool that was added in the config dialog

https://bugs.kde.org/show_bug.cgi?id=424810 Simone Gaiarin changed: What|Removed |Added Version Fixed In||1.11.0 Status|CONFIRMED

[okular] [Bug 424616] Annotation toolbar buttons are all wrong

https://bugs.kde.org/show_bug.cgi?id=424616 Simone Gaiarin changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0

[okular] [Bug 424542] Inline text annotation: “Current annotation has no fill color”

https://bugs.kde.org/show_bug.cgi?id=424542 Simone Gaiarin changed: What|Removed |Added Status|REPORTED|CONFIRMED CC

[okular] [Bug 424296] Quick annotation action gets wrongly activated on protected pdf

https://bugs.kde.org/show_bug.cgi?id=424296 --- Comment #2 from Simone Gaiarin --- Sorry for the bad wording, Gets activated > become enabled. See: https://invent.kde.org/graphics/okular/-/merge_requests/221 -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 424296] New: Quick annotation action gets wrongly activated on protected pdf

https://bugs.kde.org/show_bug.cgi?id=424296 Bug ID: 424296 Summary: Quick annotation action gets wrongly activated on protected pdf Product: okular Version: unspecified Platform: Manjaro OS: Linux

[okular] [Bug 424249] Segmentation fault when closing a tab by using the keyboard shortcuts

https://bugs.kde.org/show_bug.cgi?id=424249 --- Comment #12 from Simone Gaiarin --- >From what I understand from the gdb backtrace it seems that it fails in the cast after the assert, so does not seem exactly 423335 (sorry for changing my mind three times). I would be good to test this ag

[okular] [Bug 424249] Segmentation fault when closing a tab by using the keyboard shortcuts

https://bugs.kde.org/show_bug.cgi?id=424249 --- Comment #9 from Simone Gaiarin --- Can you execute `gdb okular` then `run` and attach the trace of gdb after the crash. (should say something about an assert failing). Actually seems to be 423335, now that I've read better the trace. This s

[okular] [Bug 424249] Segmentation fault when closing a tab by using the keyboard shortcuts

https://bugs.kde.org/show_bug.cgi?id=424249 --- Comment #5 from Simone Gaiarin --- Does not seem to be 423335. Does the crash happen if you close the current focused tab with the middle click of the mouse or the X close button? -- You are receiving this mail because: You are the assignee for

[okular] [Bug 423335] Assert crash at closing focused tab with new annotation toolbar

https://bugs.kde.org/show_bug.cgi?id=423335 --- Comment #3 from Simone Gaiarin --- See https://invent.kde.org/graphics/okular/-/merge_requests/200 -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 423335] Assert crash at closing tabs with new annotation toolbar

https://bugs.kde.org/show_bug.cgi?id=423335 Simone Gaiarin changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED

[okular] [Bug 422827] Annotation toolbar fails to appear, unless rc-files are wiped out

https://bugs.kde.org/show_bug.cgi?id=422827 Simone Gaiarin changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED

[okular] [Bug 422828] New annotation toolbar button/action mismatch

https://bugs.kde.org/show_bug.cgi?id=422828 --- Comment #3 from Simone Gaiarin --- >From what I have seen this mismatch should be caused by a dirty ~/.config/okularpartrc file (or the one in your prefix). The fact is that the standard tools in the toolbar are read from the key AnnotationTo

[okular] [Bug 422827] Annotation toolbar fails to appear, unless rc-files are wiped out

https://bugs.kde.org/show_bug.cgi?id=422827 --- Comment #2 from Simone Gaiarin --- I am not sure there is a way to migrate part.rc automatically, possibly the only solution is to manually delete that file. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 422827] Annotation toolbar fails to appear, unless rc-files are wiped out

https://bugs.kde.org/show_bug.cgi?id=422827 Simone Gaiarin changed: What|Removed |Added CC||n...@kde.org --- Comment #1 from Simone

[okular] [Bug 421354] Form fields bad rendering when scrolling

https://bugs.kde.org/show_bug.cgi?id=421354 --- Comment #5 from Simone Gaiarin --- Tested on the original problematic PDF and it seems to fix the problem. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 421508] New: Cannot type anything in some form fields

https://bugs.kde.org/show_bug.cgi?id=421508 Bug ID: 421508 Summary: Cannot type anything in some form fields Product: okular Version: 20.04.0 Platform: Manjaro OS: Linux Status: REPORTED Severity: normal

[okular] [Bug 421354] Form fields bad rendering when scrolling

https://bugs.kde.org/show_bug.cgi?id=421354 --- Comment #3 from Simone Gaiarin --- Commit 09cb524f seems to be the responsible of the bug. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 421354] Form fields bad rendering when scrolling

https://bugs.kde.org/show_bug.cgi?id=421354 --- Comment #1 from Simone Gaiarin --- Created attachment 128369 --> https://bugs.kde.org/attachment.cgi?id=128369&action=edit original pdf -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 421354] New: Form fields bad rendering when scrolling

https://bugs.kde.org/show_bug.cgi?id=421354 Bug ID: 421354 Summary: Form fields bad rendering when scrolling Product: okular Version: 20.04.0 Platform: Manjaro OS: Linux Status: REPORTED Severity: normal

[okular] [Bug 418531] New: Esc to deselect annotation tool ignored after closing an annotation popup with Esc

https://bugs.kde.org/show_bug.cgi?id=418531 Bug ID: 418531 Summary: Esc to deselect annotation tool ignored after closing an annotation popup with Esc Product: okular Version: 1.9.3 Platform: Manjaro OS: Lin

D15580: New annotation toolbar

simgunz added a comment. When you create the merge request: - set the title to `WIP: title of merge request` to mark it as work in progress - push the commits as you work so you have a backup, can see the results of the CI tests and possibly receive feedbacks REPOSITORY R223 Okular

D24606: Prevent user changing the stamp opacity

simgunz abandoned this revision. simgunz added a comment. Moved to KDE invent. https://invent.kde.org/kde/okular/merge_requests/120 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D24606 To: simgunz, #okular, #vdg, aacid Cc: aacid, ngraham, okular-devel, johnzh, a

D15580: New annotation toolbar

simgunz abandoned this revision. simgunz added a comment. Moved to KDE invent. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg, ngraham Cc: kde-doc-english, andreashurka, yurchor, trickyricky26, simgunz, ltoscano, cfeck, aacid, davidh

D15580: New annotation toolbar

simgunz added a comment. In D15580#605913 , @davidhurka wrote: > In D15580#605611 , @simgunz wrote: > > > aacid requested to write some autotest for the ToggleActionMenu before merging this. I'll m

D15580: New annotation toolbar

simgunz added a comment. aacid requested to write some autotest for the ToggleActionMenu before merging this. I'll merge master in this review and work on the autotests soon. REPOSITORY R223 Okular BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL https://phabricator.kde.

D21971: Replace ToolAction by ToggleActionMenu

simgunz accepted this revision. simgunz added a comment. This revision is now accepted and ready to land. I compiled and it works. Looks good to me. @aacid Can you also have a look at this? REPOSITORY R223 Okular BRANCH create-configurable-toggleactionmenu REVISION DETAIL https://

D21971: Replace ToolAction by ToggleActionMenu

simgunz added inline comments. INLINE COMMENTS > simgunz wrote in toggleactionmenu.cpp:93 > Change to `qAsConst( menu->actions() )`. > Change `a` to `action` for clarity. Actually `qAsConst` should not be added here. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21971

D21971: Replace ToolAction by ToggleActionMenu

simgunz added a comment. You need to merge master into this review or rebase because there is a merge conflict. I suggested you the modifications that were introduced in master (`qAsConst`) and few other changes. INLINE COMMENTS > toggleactionmenu.cpp:93 > +{ > +for ( QAction * a : menu

D21971: Replace ToolAction by ToggleActionMenu

simgunz requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21971 To: davidhurka, simgunz Cc: aacid, ngraham, simgunz, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, j

D21971: Replace ToolAction by ToggleActionMenu

simgunz added a comment. It does not compile indeed. My fault in the review process, I missed the last commit. I have added the inline comments to fix the bug. INLINE COMMENTS > pageview.cpp:660 > +d->aMouseModeMenu = new ToggleActionMenu( QIcon(),QString(), this, > +

D21971: Replace ToolAction by ToggleActionMenu

simgunz accepted this revision. simgunz added a comment. This revision is now accepted and ready to land. The class has the features needed for both D15580 and D21195 and I do not see evident bugs. For me, this revisio

D21971: Replace ToolAction by ToggleActionMenu

simgunz added a comment. In D21971#560810 , @davidhurka wrote: > - Restrict toolbar button popup mode to DelayedPopup and MenuButtonPopup using a custom enum > > Honestly, I’m not sure whether this is good. We say no one wants to use Inst

D21971: Replace ToolAction by ToggleActionMenu

simgunz added a comment. In D21971#560495 , @davidhurka wrote: > In D21971#559485 , @simgunz wrote: > > > To sum it up, if I understand correctly: > > > > - we can remove `InstantPopup` given th

D15580: New annotation toolbar

simgunz updated this revision to Diff 69406. simgunz added a comment. - Apply KDE Frameworks astyle REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15580?vs=69405&id=69406 BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL https://phabricato

D15580: New annotation toolbar

simgunz updated this revision to Diff 69405. simgunz added a comment. - Minor refactor REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15580?vs=69380&id=69405 BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL https://phabricator.kde.org/D15

D15580: New annotation toolbar

simgunz added a comment. > Might it be a hint that there are too many toolbars? I think only the part should have the annotation toolbar, so it is clear which is affected by the hide action. Not defining the annotation toolbar also in `shell.rc` makes the implementation of the action to

D15580: New annotation toolbar

simgunz marked 2 inline comments as done. REPOSITORY R223 Okular BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg, ngraham Cc: kde-doc-english, andreashurka, yurchor, trickyricky26, simgunz, ltoscano, cfeck, aaci

D15580: New annotation toolbar

simgunz updated this revision to Diff 69380. simgunz added a comment. - Merge remote-tracking branch 'origin/master' into new-annotation-toolbar_ToggleActionMenu REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15580?vs=69379&id=69380 BRANCH new-annotation

D15580: New annotation toolbar

simgunz updated this revision to Diff 69379. simgunz added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. - Add setToolBarVisible method - Fix annotation toolbar only hidden in first main window REPOSITORY R223 Okular CHANGES SINCE LAST UPDAT

D21971: Replace ToolAction by ToggleActionMenu

simgunz added a comment. To sum it up, if I understand correctly: - you agree in removing `DefaultLogic` - we can remove `InstantPopup` given that we can use `KActionMenu` or `KSelectAction` to provide that use case (so no need to raise exceptions) The change to `ToggleActionMenu::

[okular] [Bug 413695] bug in review bar, custom tool, text comment color gets reverted

https://bugs.kde.org/show_bug.cgi?id=413695 --- Comment #6 from Simone Gaiarin --- The settings look correct. The fact that when the annotation is moved the color is set to the correct one suggests that it is something related to how the annotation is rendered. The new annotation toolbar is not

D21195: [RFC] Create a Change Colors menu (with toolbar button)

simgunz added inline comments. INLINE COMMENTS > davidhurka wrote in pageview.h:75 > In the meantime I learned more about this. > > The Color Mode menu will stay here in PageView::setupViewerActions(), because > it is needed only in viewer modes, and is page view related. > > m_embedMode is no

D21971: Replace ToolAction by ToggleActionMenu

simgunz added a comment. I also would like to get rid of `DefaultLogic` and just use `ImplicitDefaultAction`, but I am not sure if this creates problem when `ToggleActionMenu` is placed in a menu. Should it behave as a standard `KActionMenu` when in a menu? I think that when in a menu there

D21971: Replace ToolAction by ToggleActionMenu

simgunz added a comment. I have tried to analyze all the possible cases regarding `ToggleActionMenu` placed in a toolbar. From what I understand: - `DefaultLogic` means, the developer needs to manage everything manually calling/connecting `setDefaultAction`. - `ImplicitDefaultActi

[okular] [Bug 413595] Have a setting to show review bar by default

https://bugs.kde.org/show_bug.cgi?id=413595 --- Comment #3 from Simone Gaiarin --- In the current state of the new annotation toolbar, the toolbar visibility is kept across sessions, so the current behavior solves this bug. We have multiple ways to hide it, so I believe that it won't

[okular] [Bug 413695] bug in review bar, custom tool, text comment color gets reverted

https://bugs.kde.org/show_bug.cgi?id=413695 --- Comment #3 from Simone Gaiarin --- I cannot reproduce it in the current okular version (1.8.2). Just to be clear, with 'text comment' you mean 'Typewriter', right? Can you: - post the result of `grep Annotation ~/.config/ok

D15580: New annotation toolbar

simgunz updated this revision to Diff 69254. simgunz added a comment. - Use full ellipsis - Ignore locale when saving numbers in config files REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15580?vs=68843&id=69254 BRANCH new-annotation-toolbar_ToggleActi

D15580: New annotation toolbar

simgunz added a comment. > I did that for a few minutes now and figured out that the same happens with line width (arrow) as well, as long as you choose x.5 . Looks like the toolbar menus are saving double/float/long (whatever) in a different format from how the menu does: > Toolbar ="0\

D15580: New annotation toolbar

simgunz added inline comments. INLINE COMMENTS > davidhurka wrote in shell.cpp:370 > This (maybe) causes one problem now. The default is to open new documents in > new windows. > > Open a new document with the Open action of an existing shell, so a new > Okular window appears. Open the annotat

  1   2   3   4   >