[okular] [Bug 419109] Preserve extended attributes when saving a file

2020-04-16 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=419109 --- Comment #8 from Stefan Brüns --- (In reply to Manu from comment #6) > maybe out of my depth here, but I think that goes against the baloo > philosophy: if you do that, then *every* program handling the file must know > about those a

[okular] [Bug 419109] Preserve extended attributes when saving a file

2020-04-16 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=419109 --- Comment #7 from Stefan Brüns --- (In reply to tagwerk19 from comment #5) > What would happen if this information was part of the file (rather than in > the extended attributes)? It would be copied/saved as part of the file and > manag

[okular] [Bug 419109] Preserve extended attributes when saving a file

2020-04-09 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=419109 --- Comment #2 from Stefan Brüns --- For "Save", I would definitely vote for "preserve as much as possible". For "Save as ...", I am not sure. There are pros and cons for both possibilities. Cons: - It may lead to infor

[okular] [Bug 390709] Create a reader mode/horizontal continous mode

2019-12-06 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390709 --- Comment #6 from Stefan Brüns --- (In reply to David Hurka from comment #5) > Does Bug 343910 request the same what you want? I think in most parts, yes. The "Overview" + "unlimited pages" + "Autofit" + "Fulls

[okular] [Bug 407140] Crash, QTextDocument chokes on input and ends up with negative pagecounts

2019-05-09 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=407140 --- Comment #2 from Stefan Brüns --- (In reply to Albert Astals Cid from comment #1) > That's not a pdf ;) > > This is most probably a duplicate of 406738 > > Do you have time to check? The backtrace is the same. -- You are rece

D20947: [EPubGenerator] Fetch the application palette just once

2019-05-02 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R223:43cf8c8aef98: [EPubGenerator] Fetch the application palette just once (authored by bruns). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20947?vs=57348=57393

D20946: [EPubGenerator] Reduce nesting level in loop

2019-05-02 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R223:f7fbbf769be3: [EPubGenerator] Reduce nesting level in loop (authored by bruns). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20946?vs=57347=57392 REVISION DETAIL

D20949: [EPubGenerator] Avoid crashes due to bogus wrapping of content in table

2019-05-01 Thread Stefan Brüns
bruns edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20949 To: bruns, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D20949: [EPubGenerator] Avoid crashes due to bogus wrapping of content in table

2019-05-01 Thread Stefan Brüns
bruns added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20949 To: bruns, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D20949: [EPubGenerator] Avoid crashes due to bogus wrapping of content in table

2019-05-01 Thread Stefan Brüns
bruns updated this revision to Diff 57352. bruns added a comment. remove unrelated code from patch REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20949?vs=57350=57352 BRANCH fix_epub REVISION DETAIL https://phabricator.kde.org/D20949 AFFECTED FILES

D20950: [EPubGenerator] Use proper UserResource enum value for custom resource

2019-05-01 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. bruns requested review of this revision. REVISION SUMMARY QTextDocument::ResourceType uses values 0 through 3, and provides UserResource = 100 for custom

D20948: [EPubGenerator] Avoid pointless scans of the whole document

2019-05-01 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. bruns requested review of this revision. REVISION SUMMARY The "" tag is a placeholder, and should only be processed when it has been inserted for this toc

D20949: [EPubGenerator] Avoid crashes due to bogus wrapping of content in table

2019-05-01 Thread Stefan Brüns
bruns created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. bruns requested review of this revision. REVISION SUMMARY QTextDocument chokes badly when a some documents are wrapped inside a table, returning e.g. a pagecount of -41292 afterwards. On

D20947: [EPubGenerator] Fetch the application palette just once

2019-05-01 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. bruns requested review of this revision. REVISION SUMMARY There is no reason to fetch the palette once per loop, just do it once REPOSITORY R223 Okular

D20946: [EPubGenerator] Reduce nesting level in loop

2019-05-01 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. bruns requested review of this revision. REVISION SUMMARY The loop body is skipped when `epub_it_get_curr(it)` is invalid. Make it more obvious there is no

[okular] [Bug 407140] Crash, QTextDocument chokes on input and ends up with negative pagecounts

2019-05-01 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=407140 Stefan Brüns changed: What|Removed |Added See Also||https://bugs.kde.org/show_b

[okular] [Bug 390706] Two-finger touchscreen zoom gesture needs final refresh

2018-02-23 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390706 Stefan Brüns <stefan.bru...@rwth-aachen.de> changed: What|Removed |Added Status|NEEDSINFO |UNCON

[okular] [Bug 390706] Two-finger touchscreen zoom gesture needs final refresh

2018-02-22 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390706 --- Comment #7 from Stefan Brüns <stefan.bru...@rwth-aachen.de> --- It is sometimes hard to see the misrendering, and it does not happen all the time, or it is immediately cleared, because on lifting the finger a small movement happens. -

[okular] [Bug 390706] Two-finger touchscreen zoom gesture needs final refresh

2018-02-22 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390706 Stefan Brüns <stefan.bru...@rwth-aachen.de> changed: What|Removed |Added Resolution|WAITINGF

[okular] [Bug 390709] Create a reader mode/horizontal continous mode

2018-02-19 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390709 --- Comment #4 from Stefan Brüns <stefan.bru...@rwth-aachen.de> --- This is specially useful for e.g. datasheets, when you want/need to see multiple pages at once. One possible approach would be to allow moving pagewise in the overview mode. Cur

[okular] [Bug 390706] Two-finger touchscreen zoom gesture needs final refresh

2018-02-19 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390706 --- Comment #3 from Stefan Brüns <stefan.bru...@rwth-aachen.de> --- Created attachment 110828 --> https://bugs.kde.org/attachment.cgi?id=110828=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 390706] Two-finger touchscreen zoom gesture needs final refresh

2018-02-19 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390706 --- Comment #2 from Stefan Brüns <stefan.bru...@rwth-aachen.de> --- When I zoom in using Ctrl + Mouse Wheel Up, the page contents are magnified immediately, but for a very short time the contents are "blocky". This is not persistent,

[okular] [Bug 390709] Create a reader mode/horizontal continous mode

2018-02-19 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390709 Stefan Brüns <stefan.bru...@rwth-aachen.de> changed: What|Removed |Added Resolution|WAITINGF

[okular] [Bug 390708] Allow to move backward in presentations using touch

2018-02-19 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390708 --- Comment #4 from Stefan Brüns <stefan.bru...@rwth-aachen.de> --- (In reply to Oliver Sander from comment #3) > We are talking about touch screens, right? Not about touch pad gestures? Yes, touch screens. -- You are receiving this mai

[okular] [Bug 390708] Allow to move backward in presentations using touch

2018-02-19 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390708 --- Comment #2 from Stefan Brüns <stefan.bru...@rwth-aachen.de> --- (In reply to Oliver Sander from comment #1) > You can go back and forth in presentations using left/right swiping > gestures. Note that Qt swipe gestures need three(!) f

[okular] [Bug 390709] New: Create a reader mode/horizontal continous mode

2018-02-18 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390709 Bug ID: 390709 Summary: Create a reader mode/horizontal continous mode Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED

[okular] [Bug 390708] New: Allow to move backward in presentations using touch

2018-02-18 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390708 Bug ID: 390708 Summary: Allow to move backward in presentations using touch Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED

[okular] [Bug 390707] New: Two-finger touchscreen zoom gesture should respect finger position

2018-02-18 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390707 Bug ID: 390707 Summary: Two-finger touchscreen zoom gesture should respect finger position Product: okular Version: unspecified Platform: Other OS: Linux

[okular] [Bug 390706] New: Two-finger touchscreen zoom gesture needs final refresh

2018-02-18 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390706 Bug ID: 390706 Summary: Two-finger touchscreen zoom gesture needs final refresh Product: okular Version: unspecified Platform: Other OS: Linux Status: