Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-05-05 Thread Tingnan Zhang
pageview.h 287da3a26297e39a275cac9b5276181987640a86 ui/pageview.cpp b00dd3e9201f6b606ae4c064bb95d504563cab09 Diff: https://git.reviewboard.kde.org/r/112370/diff/ Testing --- done on local machine Thanks, Tingnan Zhang ___ Okular-devel mailing list Okular-devel@kde

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-05-05 Thread Tingnan Zhang
od idea - Tingnan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112370/#review56806 --- On May 5, 2014, 8 p.m., Tingna

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-05-05 Thread Tingnan Zhang
geview.cpp b00dd3e9201f6b606ae4c064bb95d504563cab09 Diff: https://git.reviewboard.kde.org/r/112370/diff/ Testing --- done on local machine Thanks, Tingnan Zhang ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-04-27 Thread Tingnan Zhang
pageview.h 287da3a26297e39a275cac9b5276181987640a86 Diff: https://git.reviewboard.kde.org/r/112370/diff/ Testing --- done on local machine Thanks, Tingnan Zhang ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-04-26 Thread Tingnan Zhang
it: https://git.reviewboard.kde.org/r/112370/#review56336 --- On Nov. 28, 2013, 7:35 a.m., Tingnan Zhang wrote: > > --- > This is an automatically generated e-mail. To rep

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-01-09 Thread Tingnan Zhang
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112370/#review46423 --- On Nov. 28, 2013, 7:35 a.m., Tingnan Zhang wrote: > > --- > This i

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-11-27 Thread Tingnan Zhang
pageview.h 9c15af674e22c2b162fbd330228eb92545cbf805 ui/pageview.cpp 65967bf9399980e89953cce3c6d7145f41155c86 Diff: http://git.reviewboard.kde.org/r/112370/diff/ Testing --- done on local machine Thanks, Tingnan Zhang ___ Okular-devel ma

[Okular-devel] Advise needed to fix bug 323434/323435

2013-11-22 Thread Tingnan Zhang
modes is only calculated when the function slotRelayoutPages() is called, which as the name suggests, will also update the page view. My idea is to separate the code that calculates the zoom ratio to a new function which can be called at other places. Any ideas? Tingnan Zhang

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-10-14 Thread Tingnan Zhang
like it. What do you guys > > think, is it valuable? > > Tingnan Zhang wrote: > I think with my modification it will go back to 140% (not 144%). > > And currently, if you put 194% and press the zoom in + zoom out, you will > not get 194%, but 184% instead. Al

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-10-02 Thread Tingnan Zhang
---------- On Oct. 1, 2013, 11:52 p.m., Tingnan Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112370/ > --

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-10-01 Thread Tingnan Zhang
Diff: http://git.reviewboard.kde.org/r/112370/diff/ Testing --- done on local machine Thanks, Tingnan Zhang ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-09-28 Thread Tingnan Zhang
e modified version. with the definitions now inside the case. - Tingnan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112370/#review40818 ---------

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-09-26 Thread Tingnan Zhang
12370/diff/ Testing --- done on local machine Thanks, Tingnan Zhang ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-08-30 Thread Tingnan Zhang
12370/diff/ Testing --- done on local machine Thanks, Tingnan Zhang ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-08-29 Thread Tingnan Zhang
. Zoom factor now are rounded. Diffs - ui/pageview.cpp 0d6c567d836340555b3101b58178a9247959543a Diff: http://git.reviewboard.kde.org/r/112370/diff/ Testing --- done on local machine Thanks, Tingnan Zhang ___ Okular-devel mailing list