Re: [Okular-devel] Review Request: Remember position on the page in bookmark

2012-03-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104365/#review11884 --- This review has been submitted with commit bd9087f20ae4a99495c

Re: [Okular-devel] Review Request: Remember position on the page in bookmark

2012-03-26 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104365/#review11883 --- Ship it! Ship It! - Albert Astals Cid On March 26, 2012, 3:

Re: [Okular-devel] Review Request: Remember position on the page in bookmark

2012-03-25 Thread Mailson Menezes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104365/ --- (Updated March 26, 2012, 3:57 a.m.) Review request for Okular and Albert A

Re: [Okular-devel] Review Request: Remember position on the page in bookmark

2012-03-25 Thread Albert Astals Cid
> On March 23, 2012, 1:40 a.m., Eike Hein wrote: > > I've tried the patch, and it appears to work well. Existing bookmarks > > continue to work, and new bookmarks remember the page position. Renaming > > bookmarks still works, too. And I agree this is a nice improvement to the > > bookmarking

Re: [Okular-devel] Review Request: Remember position on the page in bookmark

2012-03-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104365/#review11844 --- Looks good for a first attempt :-) Some comments inline core/

Re: [Okular-devel] Review Request: Remember position on the page in bookmark

2012-03-23 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104365/#review11774 --- I've tried the patch, and it appears to work well. Existing boo

[Okular-devel] Review Request: Remember position on the page in bookmark

2012-03-22 Thread Mailson Menezes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104365/ --- Review request for Okular and Albert Astals Cid. Description --- This