Re: [Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated March 11, 2013, 9:53 p.m.) Status -- This change has been ma

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review29033 --- This review has been submitted with commit 5ab30aae15ac69e0306

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

> On March 3, 2013, 4:38 p.m., Albert Astals Cid wrote: > > I have found a bug, if you do: > > okular filethatdoesnotexist.pdf -unique -print > > okular filethatdoesexist.pdf -unique > > You get the printing dialog when opening the second one, i think that's a > > bit unexpected, no? Yes you

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated March 8, 2013, 8:17 p.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review28457 --- I have found a bug, if you do: okular filethatdoesnotexist.pdf

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated March 1, 2013, 11:36 a.m.) Review request for Okular. Descripti

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated March 1, 2013, 11:34 a.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

> On Feb. 28, 2013, 11:45 p.m., Albert Astals Cid wrote: > > kdocumentviewer.h, line 50 > > > > > > Do we need this? If not i'd prefer not to change this public header. Yes, it is like startPresentation. I was thi

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review28312 --- kdocumentviewer.h

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

> On Feb. 27, 2013, 10:35 p.m., Albert Astals Cid wrote: > > part.cpp, line 1322 > > > > > > Why are you using invokeMethod here? I'm sorry my fault. I was not thinking about it. Calling method is better. I hop

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 27, 2013, 11:58 p.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review28234 --- part.cpp

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review28230 --- part.cpp

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

> On Feb. 23, 2013, 11:50 p.m., Albert Astals Cid wrote: > > Should move it to a bool like we do in start presentation, otherwise > > okular https://bugs.freedesktop.org/attachment.cgi?id=46889 --print > > won't work I have rewritten it. I do not know if we need to change the version of inter

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 24, 2013, 3:01 p.m.) Review request for Okular. Descriptio

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 24, 2013, 3:01 p.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review27946 --- Should move it to a bool like we do in start presentation, othe

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

> On Feb. 23, 2013, 12:16 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 182 > > > > > > Using QueuedConnections is by default evil and you shouldn't use them > > unless strictly necessary. I guess you'

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 23, 2013, 1:35 p.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review27925 --- shell/shell.cpp

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 22, 2013, 9:12 p.m.) Review request for Okular. Descriptio

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 22, 2013, 9:11 p.m.) Review request for Okular. Descriptio

Re: [Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 22, 2013, 9:09 p.m.) Review request for Okular. Descriptio

[Okular-devel] Review Request 109096: Open print dialog from command line

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- Review request for Okular. Description --- Added command line options