Re: [Okular-devel] Review Request 109632: Annotation eraser

2014-04-23 Thread Peter Grasch
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109632/ --- (Updated April 23, 2014, 11:01 p.m.) Status -- This change has been

Re: [Okular-devel] Review Request 109632: Annotation eraser

2014-04-23 Thread Albert Astals Cid
On March 24, 2013, 1:06 a.m., Jon Mease wrote: Comments on the functionality (not the implementation): 1) I'm really excited to have this functionality in Okular (My work on the undo functionality was also primarily motivated by the desire to replace Xournal with Okular for tablet

Re: [Okular-devel] Review Request 109632: Annotation eraser

2013-09-25 Thread Albert Astals Cid
On March 24, 2013, 1:06 a.m., Jon Mease wrote: Comments on the functionality (not the implementation): 1) I'm really excited to have this functionality in Okular (My work on the undo functionality was also primarily motivated by the desire to replace Xournal with Okular for tablet

Re: [Okular-devel] Review Request 109632: Annotation eraser

2013-03-24 Thread Peter Grasch
On March 24, 2013, 1:06 a.m., Jon Mease wrote: Comments on the functionality (not the implementation): 1) I'm really excited to have this functionality in Okular (My work on the undo functionality was also primarily motivated by the desire to replace Xournal with Okular for tablet

Re: [Okular-devel] Review Request 109632: Annotation eraser

2013-03-23 Thread Peter Grasch
On March 22, 2013, 8:19 p.m., Albert Astals Cid wrote: So yeah, besides what Fabio comments on it may well be a bit slow (no way to speed it up unless you change poppler to do two pass rendering that might even be possible) code looks ok *but* it will stop working when the undo/redo

Re: [Okular-devel] Review Request 109632: Annotation eraser

2013-03-23 Thread Jon Mease
On March 22, 2013, 8:19 p.m., Albert Astals Cid wrote: So yeah, besides what Fabio comments on it may well be a bit slow (no way to speed it up unless you change poppler to do two pass rendering that might even be possible) code looks ok *but* it will stop working when the undo/redo

Re: [Okular-devel] Review Request 109632: Annotation eraser

2013-03-23 Thread Jon Mease
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/#review29779 --- Comments on the functionality (not the implementation): 1)

Re: [Okular-devel] Review Request 109632: Annotation eraser

2013-03-22 Thread Peter Grasch
On March 21, 2013, 11:29 p.m., Albert Astals Cid wrote: It does indeed look cool, but is there a use case? I mean do you usually have so much complex Ink annotations that you need to cut them only partially? For example: 1. Correct a shoddily drawn shape 2. Remove an accidentally drawn

Re: [Okular-devel] Review Request 109632: Annotation eraser

2013-03-22 Thread Albert Astals Cid
On March 21, 2013, 11:29 p.m., Albert Astals Cid wrote: It does indeed look cool, but is there a use case? I mean do you usually have so much complex Ink annotations that you need to cut them only partially? Peter Grasch wrote: For example: 1. Correct a shoddily drawn shape

Re: [Okular-devel] Review Request 109632: Annotation eraser

2013-03-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/#review29738 --- So yeah, besides what Fabio comments on it may well be a bit

[Okular-devel] Review Request 109632: Annotation eraser

2013-03-21 Thread Peter Grasch
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/ --- Review request for Okular. Description --- This introduces a new

Re: [Okular-devel] Review Request 109632: Annotation eraser

2013-03-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/#review29667 --- It does indeed look cool, but is there a use case? I mean do

Re: [Okular-devel] Review Request 109632: Annotation eraser

2013-03-20 Thread Peter Grasch
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/ --- (Updated March 21, 2013, 1:26 a.m.) Review request for Okular.