Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111681/#review52850 --- This review has been submitted with commit 60cc5dc98e502afd59

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111681/ --- (Updated March 12, 2014, 10:07 p.m.) Status -- This change has been

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On Feb. 15, 2014, 5:39 p.m., Albert Astals Cid wrote: > > I'm going to hate myself for suggeting this but what about > > > > diff --git a/generators/epub/converter.cpp b/generators/epub/converter.cpp > > index 394d852..cea74f7 100644 > > --- a/generators/epub/converter.cpp > > +++ b/generators

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111681/#review49849 --- I'm going to hate myself for suggeting this but what about di

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On Sept. 26, 2013, 2:10 a.m., Albert Astals Cid wrote: > > I'm again confused, isn't the idea that we respect the colors specified on > > the file? Or not? Jaydeep, what's the final decision we took? > > Christoph Feck wrote: > Albert, the issue is that some documents do not indicate text

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On Sept. 25, 2013, 8:40 p.m., Albert Astals Cid wrote: > > I'm again confused, isn't the idea that we respect the colors specified on > > the file? Or not? Jaydeep, what's the final decision we took? > > Christoph Feck wrote: > Albert, the issue is that some documents do not indicate text

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On Sept. 25, 2013, 8:40 p.m., Albert Astals Cid wrote: > > I'm again confused, isn't the idea that we respect the colors specified on > > the file? Or not? Jaydeep, what's the final decision we took? > > Christoph Feck wrote: > Albert, the issue is that some documents do not indicate text

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On Sept. 25, 2013, 8:40 p.m., Albert Astals Cid wrote: > > I'm again confused, isn't the idea that we respect the colors specified on > > the file? Or not? Jaydeep, what's the final decision we took? > > Christoph Feck wrote: > Albert, the issue is that some documents do not indicate text

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On Sept. 25, 2013, 8:40 p.m., Albert Astals Cid wrote: > > I'm again confused, isn't the idea that we respect the colors specified on > > the file? Or not? Jaydeep, what's the final decision we took? Albert, the issue is that some documents do not indicate text color, they just assume. - C

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/#review40816 --- I'm again confused, isn't the idea that we respect the colors s

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote: > > To be honest i'm a bit confused by all the different patches trying to fix > > the same thing, there's this one, the other one that tries to use > > kcolorscheme, the other one that tries to let the user choose. > > > > And what I don

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On Aug. 17, 2013, 2:28 a.m., Albert Astals Cid wrote: > > To be honest i'm a bit confused by all the different patches trying to fix > > the same thing, there's this one, the other one that tries to use > > kcolorscheme, the other one that tries to let the user choose. > > > > And what I don

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote: > > To be honest i'm a bit confused by all the different patches trying to fix > > the same thing, there's this one, the other one that tries to use > > kcolorscheme, the other one that tries to let the user choose. > > > > And what I don

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/ --- (Updated Aug. 20, 2013, 10:40 a.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote: > > To be honest i'm a bit confused by all the different patches trying to fix > > the same thing, there's this one, the other one that tries to use > > kcolorscheme, the other one that tries to let the user choose. > > > > And what I don

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/#review38048 --- core/textdocumentgenerator.cpp

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On Aug. 17, 2013, 2:28 a.m., Albert Astals Cid wrote: > > To be honest i'm a bit confused by all the different patches trying to fix > > the same thing, there's this one, the other one that tries to use > > kcolorscheme, the other one that tries to let the user choose. > > > > And what I don

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On Aug. 17, 2013, 2:28 a.m., Albert Astals Cid wrote: > > To be honest i'm a bit confused by all the different patches trying to fix > > the same thing, there's this one, the other one that tries to use > > kcolorscheme, the other one that tries to let the user choose. > > > > And what I don

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote: > > To be honest i'm a bit confused by all the different patches trying to fix > > the same thing, there's this one, the other one that tries to use > > kcolorscheme, the other one that tries to let the user choose. > > > > And what I don

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote: > > To be honest i'm a bit confused by all the different patches trying to fix > > the same thing, there's this one, the other one that tries to use > > kcolorscheme, the other one that tries to let the user choose. > > > > And what I don

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote: > > To be honest i'm a bit confused by all the different patches trying to fix > > the same thing, there's this one, the other one that tries to use > > kcolorscheme, the other one that tries to let the user choose. > > > > And what I don

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote: > > To be honest i'm a bit confused by all the different patches trying to fix > > the same thing, there's this one, the other one that tries to use > > kcolorscheme, the other one that tries to let the user choose. > > > > And what I don

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/#review37994 --- To be honest i'm a bit confused by all the different patches tr

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/ --- (Updated Aug. 16, 2013, 8:58 p.m.) Review request for Okular. Descriptio

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On July 25, 2013, 12:59 p.m., Jaydeep Solanki wrote: > > Can you please confirm if the links are shown properly > > Albert Astals Cid wrote: > Christoph? Oh, I had the impression the question was directed to you (I looked at the To: field in the mail) The link color now works as intende

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

> On July 25, 2013, 12:59 p.m., Jaydeep Solanki wrote: > > Can you please confirm if the links are shown properly Christoph? - Albert --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/11168

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/#review36480 --- Can you please confirm if the links are shown properly - Jayde

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/ --- (Updated July 25, 2013, noon) Review request for Okular and Albert Astals

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/#review36476 --- Links still suffer from Bug 322547. Below is an epub, showing t

[Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111681/ --- Review request for Okular and Albert Astals Cid. Description --- As i