Re: [Okular-devel] Review Request 123249: Fixing the KActivities integration (Frameworks branch)

2015-05-04 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123249/ --- (Updated May 4, 2015, 10:21 p.m.) Status -- This change has been mar

Re: [Okular-devel] Review Request 123249: Fixing the KActivities integration (Frameworks branch)

2015-05-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123249/#review79872 --- Ship it! Ship It! - Albert Astals Cid On abr. 3, 2015, 8:3

Re: [Okular-devel] Review Request 123249: Fixing the KActivities integration (Frameworks branch)

2015-05-04 Thread Ivan Čukić
> On May 3, 2015, 11:04 p.m., Albert Astals Cid wrote: > > Can you please remind me again what this kactivities code exactly does and > > what's the benefit for the end user? It reports the currently open document to kamd (K Activity Manager Daemon). - kamd saves the events (it is configurabl

Re: [Okular-devel] Review Request 123249: Fixing the KActivities integration (Frameworks branch)

2015-05-03 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123249/#review79821 --- Can you please remind me again what this kactivities code exac

Re: [Okular-devel] Review Request 123249: Fixing the KActivities integration (Frameworks branch)

2015-04-26 Thread Ivan Čukić
> On April 9, 2015, 1:58 a.m., Jan Kundrát wrote: > > -1 from me. The unconditional dep got introduced in > > 93918b1ec8f585dd135db1449e1b22b878f82fbc, which looks like a mistake to me. > > Why not: > > - > > -find_package(KF5 CONFIG COMPONENTS Activities) > > Ivan Čukić wrote: > While

Re: [Okular-devel] Review Request 123249: Fixing the KActivities integration (Frameworks branch)

2015-04-25 Thread Jan Kundrát
> On April 9, 2015, 1:58 a.m., Jan Kundrát wrote: > > -1 from me. The unconditional dep got introduced in > > 93918b1ec8f585dd135db1449e1b22b878f82fbc, which looks like a mistake to me. > > Why not: > > - > > -find_package(KF5 CONFIG COMPONENTS Activities) > > Ivan Čukić wrote: > While

Re: [Okular-devel] Review Request 123249: Fixing the KActivities integration (Frameworks branch)

2015-04-25 Thread Ivan Čukić
> On April 9, 2015, 1:58 a.m., Jan Kundrát wrote: > > -1 from me. The unconditional dep got introduced in > > 93918b1ec8f585dd135db1449e1b22b878f82fbc, which looks like a mistake to me. > > Why not: > > - > > -find_package(KF5 CONFIG COMPONENTS Activities) > > Ivan Čukić wrote: > While

Re: [Okular-devel] Review Request 123249: Fixing the KActivities integration (Frameworks branch)

2015-04-25 Thread Ivan Čukić
> On April 9, 2015, 1:58 a.m., Jan Kundrát wrote: > > -1 from me. The unconditional dep got introduced in > > 93918b1ec8f585dd135db1449e1b22b878f82fbc, which looks like a mistake to me. > > Why not: > > - > > -find_package(KF5 CONFIG COMPONENTS Activities) > > Ivan Čukić wrote: > While

Re: [Okular-devel] Review Request 123249: Fixing the KActivities integration (Frameworks branch)

2015-04-25 Thread Jan Kundrát
> On April 9, 2015, 1:58 a.m., Jan Kundrát wrote: > > -1 from me. The unconditional dep got introduced in > > 93918b1ec8f585dd135db1449e1b22b878f82fbc, which looks like a mistake to me. > > Why not: > > - > > -find_package(KF5 CONFIG COMPONENTS Activities) > > Ivan Čukić wrote: > While

Re: [Okular-devel] Review Request 123249: Fixing the KActivities integration (Frameworks branch)

2015-04-25 Thread Ivan Čukić
> On April 9, 2015, 1:58 a.m., Jan Kundrát wrote: > > -1 from me. The unconditional dep got introduced in > > 93918b1ec8f585dd135db1449e1b22b878f82fbc, which looks like a mistake to me. > > Why not: > > - > > -find_package(KF5 CONFIG COMPONENTS Activities) While I don't mind making it agai

Re: [Okular-devel] Review Request 123249: Fixing the KActivities integration (Frameworks branch)

2015-04-08 Thread Jan Kundrát
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123249/#review78690 --- -1 from me. The unconditional dep got introduced in 93918b1ec

[Okular-devel] Review Request 123249: Fixing the KActivities integration (Frameworks branch)

2015-04-03 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123249/ --- Review request for Okular and Albert Astals Cid. Repository: okular Des